DMC/boka3
12
0
Fork 0
Code Issues13 Pull Requests Projects Releases Wiki Activity

Added handling of invalid inventory IDs and added error messages for all invalid IDs

Browse Source
This commit is contained in:
Erik Thuning 2019-04-15 10:27:58 +02:00
parent 2aee184390
commit 1349cd608c
2 changed files with 25 additions and 9 deletions

9
include/db.php

@ -961,7 +961,14 @@ class Inventory {
}
public function __construct($id) {
$this->id = $id;
$search = prepare('select `id` from `inventory` where `id`=?');
bind($search, 'i', $id);
execute($search);
$result = result_single($search);
if($result === null) {
throw new Exception('Invalid id');
}
$this->id = $result['id'];
$this->update_fields();
}

25
include/view.php

@ -315,13 +315,6 @@ abstract class Page extends Responder {
'seen_count' => count($seen),
'hide' => $hidden),
$this->fragments['inventory_do']);
$out .= replace(array('title' => 'Inventerade artiklar'),
$this->fragments['subtitle']);
if($seen) {
$out .= $this->build_product_table($seen);
} else {
$out .= 'Inga artiklar inventerade.';
}
$out .= replace(array('title' => $missing),
$this->fragments['subtitle']);
if($unseen) {
@ -329,6 +322,13 @@ abstract class Page extends Responder {
} else {
$out .= 'Inga artiklar saknas.';
}
$out .= replace(array('title' => 'Inventerade artiklar'),
$this->fragments['subtitle']);
if($seen) {
$out .= $this->build_product_table($seen);
} else {
$out .= 'Inga artiklar inventerade.';
}
return $out;
}
}
@ -469,6 +469,7 @@ class ProductPage extends Page {
$this->template = new Template($template, 'name');
} catch(Exception $e) {
$this->template = null;
$this->error = 'Det finns ingen mall med det namnet.';
}
}
}
@ -480,6 +481,7 @@ class ProductPage extends Page {
} catch(Exception $e) {
$this->action = 'list';
$this->product = null;
$this->error = 'Det finns ingen artikel med det ID-numret.';
}
}
}
@ -593,6 +595,7 @@ class UserPage extends Page {
} catch(Exception $e) {
$this->user = null;
$this->action = 'list';
$this->error = 'Det finns ingen användare med det ID-numret.';
}
}
}
@ -725,7 +728,13 @@ class HistoryPage extends Page {
$this->action = $_GET['action'];
}
if(isset($_GET['id'])) {
$this->inventory = new Inventory($_GET['id']);
try {
$this->inventory = new Inventory($_GET['id']);
} catch(Exception $e) {
$this->inventory = null;
$this->action = 'list';
$this->error = 'Det finns ingen inventering med det ID-numret.';
}
}
switch($this->action) {
case 'show':