Enforce injecting dependencies via parameters instead of direct method calling in @Bean definitions.

This is done to cause extra pain for classes with too many dependencies in the hopes that it will be re-architectured in a better way with fewer dependencies.
This commit is contained in:
Andreas Svanberg 2024-05-30 12:51:45 +02:00
parent bae694b888
commit 3a5b462d2f
6 changed files with 6 additions and 6 deletions

@ -10,7 +10,7 @@ import org.springframework.security.web.SecurityFilterChain;
import org.springframework.security.web.servlet.util.matcher.MvcRequestMatcher;
import org.springframework.web.servlet.handler.HandlerMappingIntrospector;
@Configuration
@Configuration(proxyBeanMethods = false)
@ComponentScan("se.su.dsv.scipro.api")
public class ApiConfig {
@Bean

@ -179,7 +179,7 @@ import se.su.dsv.scipro.workerthreads.WorkerDataServiceImpl;
import java.time.Clock;
@Configuration
@Configuration(proxyBeanMethods = false)
public class CoreConfig {
@Bean
public EventBus eventBus() {

@ -14,7 +14,7 @@ import se.su.dsv.scipro.profiles.CurrentProfile;
import java.util.Properties;
@Configuration
@Configuration(proxyBeanMethods = false)
public class MailConfig {
@Bean
public MailFacade mailFacade() {

@ -36,7 +36,7 @@ import java.util.List;
import java.util.Optional;
import java.util.Set;
@SpringBootApplication
@SpringBootApplication(proxyBeanMethods = false)
@EntityScan("se.su.dsv.scipro")
@Import({CoreConfig.class, ApiConfig.class, WorkerConfig.class, MailConfig.class, RepositoryConfiguration.class})
public class Main extends SpringBootServletInitializer implements ServletContainerInitializer {

@ -50,7 +50,7 @@ import se.su.dsv.scipro.system.FooterLinkRepoImpl;
import se.su.dsv.scipro.system.PasswordRepoImpl;
import se.su.dsv.scipro.system.UserRepoImpl;
@Configuration
@Configuration(proxyBeanMethods = false)
public class RepositoryConfiguration {
@Bean
public GradingHistoryEventRepositoryImpl gradingHistoryEventRepository(Provider<EntityManager> em) {

@ -50,7 +50,7 @@ import java.time.Clock;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
@Configuration
@Configuration(proxyBeanMethods = false)
@Import(WorkerConfig.Workers.class)
public class WorkerConfig {
private static final int NUMBER_OF_WORKER_THREADS = 4;