From 532b93f008d8bcaff78339d86b282fb8e219ef15 Mon Sep 17 00:00:00 2001 From: mpeters <mpeters@dsv.su.se> Date: Thu, 28 Jul 2011 15:45:11 +0200 Subject: [PATCH] Fix of hiding of "Last 12 months" on peer portal page depending on what's currently visible Change-Id: I6b0b25817373bacc2af8e3413fc432955b7d9f4a --- .../java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.html | 2 +- .../java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.java | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/main/java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.html b/src/main/java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.html index 721f5125e9..21fac7dd7d 100644 --- a/src/main/java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.html +++ b/src/main/java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.html @@ -89,7 +89,7 @@ <span class="box-title">Best rated reviewers</span> <div wicket:id="bestRatedPanel" class="append-bottom"></div> </div> - <div> + <div wicket:id="statsTimespanContainer"> <i><span class="small right">Last 12 months</span></i> </div> </div> diff --git a/src/main/java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.java b/src/main/java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.java index 3d70815e37..d4db753c68 100644 --- a/src/main/java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.java +++ b/src/main/java/se/su/dsv/scipro/peer/panels/PeerPortalPanel.java @@ -221,16 +221,23 @@ public class PeerPortalPanel extends Panel { int displayedReviews = gsettings.getNumberOfLatestReviewsDisplayed(); + boolean showStatsTimespan = false; if(gsettings.isPeerDisplayNumberOfReviewsPerformed()){ add(new MostFrequentReviewersPanel(mostFrequentPanel)); + showStatsTimespan = true; } else { add(new InvisiblePanel(mostFrequentPanel)); } if( gsettings.isPeerRatingsEnabled() ){ add(new WebMarkupContainer(bestRatedContainer).add(new BestRatedReviewersPanel("bestRatedPanel") ) ); + showStatsTimespan = true; } else { add(new InvisiblePanel(bestRatedContainer)); } + WebMarkupContainer statsTimespanContainer = new WebMarkupContainer("statsTimespanContainer"); + statsTimespanContainer.setVisible(showStatsTimespan); + add(statsTimespanContainer); + if(gsettings.isPeerDisplayLatestReviews()) { // Checkbox on the AdminPeerSettingsPage is not visible since it's // not decided what kind of info that should be public for students.