From 7f613a17ad7115de5e51f25dd78bddebf0b42864 Mon Sep 17 00:00:00 2001
From: Nico Athanassiadis <nico@dsv.su.se>
Date: Wed, 20 Nov 2024 14:12:06 +0100
Subject: [PATCH] TR fix minor code styling improvements
---
.../main/java/se/su/dsv/scipro/grading/CriteriaPanel.java | 4 +++-
.../se/su/dsv/scipro/project/panels/FinalStepsPanel.java | 6 +++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/view/src/main/java/se/su/dsv/scipro/grading/CriteriaPanel.java b/view/src/main/java/se/su/dsv/scipro/grading/CriteriaPanel.java
index cb90f4d9f2..011cb74f9f 100644
--- a/view/src/main/java/se/su/dsv/scipro/grading/CriteriaPanel.java
+++ b/view/src/main/java/se/su/dsv/scipro/grading/CriteriaPanel.java
@@ -270,8 +270,10 @@ public class CriteriaPanel extends GenericPanel<SupervisorGradingReport> {
Project project = CriteriaPanel.this.getModelObject().getProject();
return reflectionService.getReflection(project, author.getObject());
});
- IModel<String> improvementsNeeded = reflection.as(Reflection.ImprovementsNeeded.class)
+ IModel<String> improvementsNeeded = reflection
+ .as(Reflection.ImprovementsNeeded.class)
.map(Reflection.ImprovementsNeeded::commentBySupervisor);
+
add(new MultiLineLabel("improvementsNeeded", improvementsNeeded) {
@Override
protected void onConfigure() {
diff --git a/view/src/main/java/se/su/dsv/scipro/project/panels/FinalStepsPanel.java b/view/src/main/java/se/su/dsv/scipro/project/panels/FinalStepsPanel.java
index 085ff9178d..8fc9216ea3 100644
--- a/view/src/main/java/se/su/dsv/scipro/project/panels/FinalStepsPanel.java
+++ b/view/src/main/java/se/su/dsv/scipro/project/panels/FinalStepsPanel.java
@@ -80,9 +80,9 @@ public class FinalStepsPanel extends GenericPanel<Project> {
this.currentReflection = currentReflection;
- IModel<Reflection.ImprovementsNeeded> i = this.currentReflection.as(Reflection.ImprovementsNeeded.class);
+ IModel<Reflection.ImprovementsNeeded> improvementsNeeded = this.currentReflection.as(Reflection.ImprovementsNeeded.class);
- IModel<String> oldReflection = i.map(Reflection.ImprovementsNeeded::oldReflection);
+ IModel<String> oldReflection = improvementsNeeded.map(Reflection.ImprovementsNeeded::oldReflection);
add(new MultiLineLabel("old_reflection", oldReflection) {
@Override
protected void onConfigure() {
@@ -91,7 +91,7 @@ public class FinalStepsPanel extends GenericPanel<Project> {
}
});
- add(new MultiLineLabel("supervisor_comment", i.map(Reflection.ImprovementsNeeded::commentBySupervisor)) {
+ add(new MultiLineLabel("supervisor_comment", improvementsNeeded.map(Reflection.ImprovementsNeeded::commentBySupervisor)) {
@Override
protected void onConfigure() {
super.onConfigure();