DMC/scipro
7
0
Fork 0
Code Issues43 Pull Requests9 Actions Projects1 Releases Wiki Activity

87: Improve test

Browse Source
This commit is contained in:
Tom Zhao 2025-04-10 14:18:59 +02:00
parent 4be16af51c
commit 80694e2c14
1 changed files with 13 additions and 3 deletions

16
core/src/test/java/se/su/dsv/scipro/project/split/SplitOrRestartProjectServiceIntegrationTest.java

@ -19,6 +19,7 @@ import se.su.dsv.scipro.test.IntegrationTest;
import java.io.InputStream; import java.io.InputStream;
import java.time.LocalDate; import java.time.LocalDate;
import java.time.Year;
import java.util.HashSet; import java.util.HashSet;
import java.util.List; import java.util.List;
import java.util.Optional; import java.util.Optional;
@ -30,6 +31,9 @@ import static se.su.dsv.scipro.project.split.SplitOrRestartProjectService.Splitt
import static se.su.dsv.scipro.project.split.SplitOrRestartProjectService.SplittableStatusRecord; import static se.su.dsv.scipro.project.split.SplitOrRestartProjectService.SplittableStatusRecord;
public class SplitOrRestartProjectServiceIntegrationTest extends IntegrationTest { public class SplitOrRestartProjectServiceIntegrationTest extends IntegrationTest {
private static int TARGET = 3;
private static int REMAINING_TARGET = 2;
@Inject @Inject
private SplitOrRestartProjectService splitOrRestartProjectService; private SplitOrRestartProjectService splitOrRestartProjectService;
@ -45,7 +49,7 @@ public class SplitOrRestartProjectServiceIntegrationTest extends IntegrationTest
private ResearchArea researchArea; private ResearchArea researchArea;
private Project parentProject; private Project parentProject;
private User supervisor; private User supervisor;
private User reviwer; private User reviewer;
private User author1; private User author1;
private User author2; private User author2;
@ -110,6 +114,11 @@ public class SplitOrRestartProjectServiceIntegrationTest extends IntegrationTest
assertTrue(status == SplittableStatus.OK); assertTrue(status == SplittableStatus.OK);
splitOrRestartProjectService.splitProject(parentProject.getId()); splitOrRestartProjectService.splitProject(parentProject.getId());
ReviewerCapacityService.RemainingTargets remainingTargets = reviewerCapacityService.getRemainingTargets(reviewer, Year.now());
assertTrue(remainingTargets.spring() == REMAINING_TARGET ||
remainingTargets.autumn() == REMAINING_TARGET);
List<Project> childProjects = splitOrRestartProjectService.getChildProjects(parentProject.getId()); List<Project> childProjects = splitOrRestartProjectService.getChildProjects(parentProject.getId());
assertTrue(parentProject.getProjectStatus() ==ProjectStatus.INACTIVE); assertTrue(parentProject.getProjectStatus() ==ProjectStatus.INACTIVE);
@ -183,8 +192,9 @@ public class SplitOrRestartProjectServiceIntegrationTest extends IntegrationTest
roughDraftApprovalService.requestApproval(parentProject, dummyFile(), "comment"); roughDraftApprovalService.requestApproval(parentProject, dummyFile(), "comment");
reviwer = createEmployee("Lisa", "Employee", "lisa.employee@example.com", true); reviewer = createEmployee("Lisa", "Employee", "lisa.employee@example.com", true);
ReviewerAssignmentService.ReviewerAssignment reviewerAssignment = reviewerAssignmentService.assignReviewer(parentProject, reviwer); reviewerCapacityService.assignTarget(reviewer, new ReviewerCapacityService.Target(Year.now(), TARGET, TARGET, ""));
reviewerAssignmentService.assignReviewer(parentProject, reviewer);
} }
private FileUpload dummyFile() { private FileUpload dummyFile() {