From 9fe7bfc5be44e1a66ccd9f6d8b1b53a59393b065 Mon Sep 17 00:00:00 2001
From: Emil Siverhall <emil-siv@dsv.su.se>
Date: Fri, 5 Aug 2011 10:25:17 +0200
Subject: [PATCH] Minor changes in SciProApplication.properties and code
cleanup in ControllerImpl.
---
src/main/java/se/su/dsv/scipro/SciProApplication.properties | 6 ++++--
.../data/controllers/impl/NotificationControllerImpl.java | 5 -----
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/main/java/se/su/dsv/scipro/SciProApplication.properties b/src/main/java/se/su/dsv/scipro/SciProApplication.properties
index b10c83633c..0614c8f4cb 100644
--- a/src/main/java/se/su/dsv/scipro/SciProApplication.properties
+++ b/src/main/java/se/su/dsv/scipro/SciProApplication.properties
@@ -1,4 +1,6 @@
-#Web notifications:
+# Properties used by the NotificationControllerImpl.
+
+# Web notifications:
conferencePost.webNotification = ${firstName} ${lastName} posted on conference "{0}".
pm.webNotification = ${firstName} ${lastName} wrote a private message to you.
comment.webNotification = ${firstName} ${lastName} commented on a post on conference "{0}".
@@ -12,7 +14,7 @@ reviewCompletedforRequester.webNotification = Your peer request has now been rev
reviewCompletedforRequestSupervisor.webNotification = You are getting this message because you are supervisor of "${peerRequest.project.title}". A peer review on this project has been completed and is available for you.
reviewCompletedforReviewSupervisor.webNotification = ${reviewer.user} in project: ${project.title} has performed a peer review.
reviewRated.webNotification = Your review has been rated.
-#Mail notifications
+# Mail notifications
mailSubject = Notification from SciPro
acceptPeerReviewSubject = Your request for peer review has been accepted
completedReviewSubject = A peer review has been completed
diff --git a/src/main/java/se/su/dsv/scipro/data/controllers/impl/NotificationControllerImpl.java b/src/main/java/se/su/dsv/scipro/data/controllers/impl/NotificationControllerImpl.java
index d7d9201801..9f8a3bc1ec 100644
--- a/src/main/java/se/su/dsv/scipro/data/controllers/impl/NotificationControllerImpl.java
+++ b/src/main/java/se/su/dsv/scipro/data/controllers/impl/NotificationControllerImpl.java
@@ -320,11 +320,6 @@ public class NotificationControllerImpl implements NotificationController {
supervisorReviewUrl, NotificationPriority.MEDIUM);
}
- /**
- * TODO Rewrite
- *
- * @param review
- */
public void notifyOfReviewRating(PeerReview review) {
String webNotificationMessage = new StringResourceModel("reviewRated.webNotification", null).getString();