From aabb2e9d10ff1379e78d273444c7431108a69f62 Mon Sep 17 00:00:00 2001
From: Andreas Svanberg <andreass@dsv.su.se>
Date: Mon, 25 Nov 2024 11:24:08 +0100
Subject: [PATCH] Fix saving the textboxes students fill in when submitting
ideas (#25)
Background, literature, problem, method, and interests were not being saved due to explicitly having been marked as "do not save".
Multiple OTRS tickets have been filed for this problem; [391725](https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=391725#1422495), [391732](https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=391732#1422521), [391738](https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=391738#1422537), and [391757](https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=391757#1422590).
## How to test
1. Create an open application period under "Admin" / "Match" / "Application periods" (open meaning start is before today, end is after)
2. Log in as author
3. Submit an idea in the newly created period
4. See that neither of background, literature, problem, method, or interests textboxes are saved
5. Switch to this branch
6. Submit/update the idea
7. See that everything is saved
Reviewed-on: https://gitea.dsv.su.se/DMC/scipro/pulls/25
Reviewed-by: Nico Athanassiadis <nico@dsv.su.se>
Co-authored-by: Andreas Svanberg <andreass@dsv.su.se>
Co-committed-by: Andreas Svanberg <andreass@dsv.su.se>
---
core/src/main/java/se/su/dsv/scipro/match/Idea.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/core/src/main/java/se/su/dsv/scipro/match/Idea.java b/core/src/main/java/se/su/dsv/scipro/match/Idea.java
index e2772b539b..1ab583880a 100755
--- a/core/src/main/java/se/su/dsv/scipro/match/Idea.java
+++ b/core/src/main/java/se/su/dsv/scipro/match/Idea.java
@@ -105,11 +105,11 @@ public class Idea extends DomainObject {
@Embedded
@AttributeOverrides({
- @AttributeOverride(name = "literature", column = @Column(name = "literature", insertable = false, updatable = false)),
- @AttributeOverride(name = "background", column = @Column(name = "background", insertable = false, updatable = false)),
- @AttributeOverride(name = "problem", column = @Column(name = "problem", insertable = false, updatable = false)),
- @AttributeOverride(name = "method", column = @Column(name = "method", insertable = false, updatable = false)),
- @AttributeOverride(name = "interests", column = @Column(name = "interests", insertable = false, updatable = false))
+ @AttributeOverride(name = "literature", column = @Column(name = "literature")),
+ @AttributeOverride(name = "background", column = @Column(name = "background")),
+ @AttributeOverride(name = "problem", column = @Column(name = "problem")),
+ @AttributeOverride(name = "method", column = @Column(name = "method")),
+ @AttributeOverride(name = "interests", column = @Column(name = "interests"))
})
private TholanderBox tholanderBox = new TholanderBox();