DMC/scipro
7
0
Fork 0
Code Issues43 Pull Requests9 Actions Projects1 Releases Wiki Activity

Simplify to get rid of unreachable state

Browse Source
This commit is contained in:
Andreas Svanberg 2025-02-10 12:31:15 +01:00
parent 219c312441
commit d90a373a00
1 changed files with 11 additions and 14 deletions

25
view/src/main/java/se/su/dsv/scipro/match/SupervisorMyIdeasPanel.java

@ -337,29 +337,26 @@ public class SupervisorMyIdeasPanel extends Panel {
if (idea.getMatch() == null) { if (idea.getMatch() == null) {
return "-"; return "-";
} }
switch (idea.getMatchStatus()) { return switch (idea.getMatchStatus()) {
case UNMATCHED: case UNMATCHED -> getString("status.unmatched");
return getString("status.unmatched"); case COMPLETED -> getString("status.completed");
case COMPLETED: case INACTIVE -> getString("status.inactive");
return getString("status.completed"); case MATCHED -> {
case INACTIVE:
return getString("status.inactive");
case MATCHED:
if (applicationPeriodService.courseStartHasPassed(idea.getApplicationPeriod())) { if (applicationPeriodService.courseStartHasPassed(idea.getApplicationPeriod())) {
if (idea.isExported()) { if (idea.isExported()) {
if (idea.wasExportSuccessful()) { if (idea.wasExportSuccessful()) {
return getString("status.project.created"); yield getString("status.project.created");
} else { } else {
return getString("status.export.failed"); yield getString("status.export.failed");
} }
} else { } else {
return getString("status.awaiting.project.creation"); yield getString("status.awaiting.project.creation");
} }
} else { } else {
return getString("status.awaiting.course.start", Model.of(idea.getApplicationPeriod())); yield getString("status.awaiting.course.start", Model.of(idea.getApplicationPeriod()));
} }
} }
return "-"; // can't happen };
} }
}; };
} }