DMC/scipro
7
0
Fork 0
Code Issues42 Pull Requests4 Actions Projects1 Releases Wiki Activity

3204 Remove tests for old functionality that has moved

Browse Source
This commit is contained in:
Andreas Svanberg 2024-01-12 16:47:31 +01:00
parent e57f610311
commit f2c45f9461
1 changed files with 0 additions and 68 deletions

68
view/src/test/java/se/su/dsv/scipro/datatables/project/ProjectDataPanelTest.java

@ -1,12 +1,6 @@
package se.su.dsv.scipro.datatables.project;
import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior;
import org.apache.wicket.behavior.AbstractAjaxBehavior;
import org.apache.wicket.behavior.Behavior;
import org.apache.wicket.markup.html.form.FormComponent;
import org.apache.wicket.util.tester.WicketTesterHelper;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;
import org.springframework.data.domain.Pageable;
import se.su.dsv.scipro.SciProTest;
import se.su.dsv.scipro.datatables.AjaxCheckboxWrapper;
@ -16,14 +10,11 @@ import se.su.dsv.scipro.project.ProjectStatus;
import se.su.dsv.scipro.security.auth.roles.Roles;
import se.su.dsv.scipro.system.DegreeType;
import se.su.dsv.scipro.system.ProjectType;
import se.su.dsv.scipro.system.User;
import se.su.dsv.scipro.test.ObjectMother;
import java.time.LocalDate;
import java.util.Collections;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.mockito.Mockito.*;
public class ProjectDataPanelTest extends SciProTest {
@ -42,47 +33,6 @@ public class ProjectDataPanelTest extends SciProTest {
inactivateProject();
}
@Test
public void change_reviewer() {
User reviewer = User.builder().firstName("reviewer").lastName("review").emailAddress("rev@reviewer.com").build();
reviewer.setId(74L);
reviewer.addRole(Roles.REVIEWER);
when(userSearchService.findOne(74L)).thenReturn(reviewer);
mockProject();
startPanel();
selectReviewer();
ArgumentCaptor<Project> captor = ArgumentCaptor.forClass(Project.class);
verify(projectService).save(captor.capture());
assertEquals(captor.getValue().getReviewer(), reviewer);
}
@Test
public void change_reviewer_removes_old_reviewers() {
User reviewer = User.builder().firstName("reviewer").lastName("review").emailAddress("rev@reviewer.com").build();
reviewer.addRole(Roles.REVIEWER);
reviewer.setId(74L);
when(userSearchService.findOne(74L)).thenReturn(reviewer);
User oldReviewer = mockProjectWithReviewer();
startPanel();
selectReviewer();
ArgumentCaptor<Project> captor = ArgumentCaptor.forClass(Project.class);
verify(projectService).save(captor.capture());
assertFalse(captor.getValue().getReviewers().contains(oldReviewer));
}
@Test
public void change_reviewer_fails_if_selecting_the_current_supervisor() {
when(userSearchService.findOne(74L)).thenReturn(ObjectMother.SOME_USER);
mockProject();
startPanel();
selectReviewer();
verify(projectService, never()).save(any(Project.class));
}
@Test
public void admins_should_not_be_able_to_create_projects() {
setRoles(Roles.ADMIN);
@ -90,13 +40,6 @@ public class ProjectDataPanelTest extends SciProTest {
tester.assertInvisible(path(panel, "newLink"));
}
private void selectReviewer() {
FormComponent reviewerSelection = (FormComponent) panel.get("dataTable:body:rows:1:cells:7:cell:eac");
tester.getRequest().getPostParameters().setParameterValue(reviewerSelection.getInputName(), "74");
Behavior behavior = WicketTesterHelper.findBehavior(reviewerSelection, AjaxFormComponentUpdatingBehavior.class);
tester.executeBehavior((AbstractAjaxBehavior) behavior);
}
private void inactivateProject() {
panel.visitChildren(AjaxCheckboxWrapper.class, (object, visit) -> {
tester.executeAjaxEvent(path(object.getPageRelativePath(), AjaxCheckboxWrapper.CHECKBOX), "click");
@ -112,17 +55,6 @@ public class ProjectDataPanelTest extends SciProTest {
when(projectService.count(any(ProjectService.Filter.class))).thenReturn(1L);
}
private User mockProjectWithReviewer() {
Project project = Project.builder().title("title").projectType(new ProjectType(DegreeType.BACHELOR, "bach", "b")).startDate(LocalDate.now()).projectStatus(ProjectStatus.ACTIVE).build();
project.setHeadSupervisor(ObjectMother.SOME_USER);
User oldReviewer = User.builder().firstName("old").lastName("reviewer").emailAddress("old@reviewer.com").build();
oldReviewer.setId(7676L);
project.addReviewer(oldReviewer);
when(projectService.findAll(any(ProjectService.Filter.class), any(Pageable.class))).thenReturn(Collections.singletonList(project));
when(projectService.count(any(ProjectService.Filter.class))).thenReturn(1L);
return oldReviewer;
}
private void startPanel() {
panel = tester.startComponentInPage(new ProjectDataPanel("id"));
}