6886 Commits

Author SHA1 Message Date
9a6a7ab677 Remove reliance on global state (ObjectMother) that enforced a specific test run order to pass the test suite. 2022-11-09 14:41:11 +01:00
4bfeec61e5 2863 Remind supervisors that it's time to grade when rough draft gets approved 2022-11-09 12:44:54 +01:00
6cfd52e213 Refactoring 2022-11-09 11:28:09 +01:00
3c06b1d2cd 2915 Enable students to view description of chosen supervisor ideas 2022-11-07 21:46:38 +01:00
36d8431281 2875 Include the reflection in the grading report 2022-11-07 21:26:56 +01:00
3076524cc2 2854 Allow authors to submit their reflection 2022-11-07 21:04:08 +01:00
2fe16b9b15 Show exception page during development 2022-11-07 19:18:00 +01:00
071e1c6509 Merge remote-tracking branch 'origin/develop' into develop 2022-10-31 19:18:14 +01:00
f01ca429f4 2860 TR change text 2022-10-31 19:17:59 +01:00
9c1481626a Merge branch 'develop' into 2856 2022-10-25 20:40:47 +02:00
60b5feb159 2861 Prevent supervisors from scheduling seminars if they have not gotten their submitted rough draft approved 2022-10-25 13:26:31 +02:00
3da035e950 2861 Refactoring 2022-10-25 13:26:31 +02:00
48cd7aa9c9 2861 Schedule final seminars 2022-10-25 13:26:31 +02:00
48799ed298 2861 Refactor updating final seminar details 2022-10-25 13:26:31 +02:00
2b42ad1d16 2861 Create a dedicated method for scheduling seminars that is responsible for checking all the rules 2022-10-25 13:26:31 +02:00
5acf93e7cb 2860 Added mandatory minimums for final seminar participations to report graded examinations.
Supervisors are able to ignore the requirement in case the seminars have been held outside the system or for any other reason.
2022-10-19 14:51:23 +02:00
b83b4da1af Speed up deployment 2022-10-18 12:49:49 +02:00
e02006bfd1 Upgrade to servlet specification 4.0 2022-10-18 12:14:42 +02:00
0dadabec07 Stop users getting logged during restarts 2022-10-18 10:24:51 +02:00
8fa7a17a07 Fix faulty JPA mapping 2022-10-17 20:02:19 +02:00
ccaa50ad67 Clean up 2022-10-13 12:04:25 +02:00
e15cdcd535 2883 Help text for supervisors explaining the new motivation requirements on the grading report. 2022-10-12 11:29:06 +02:00
9e89861e19 Styling improvements for the students view of the grading report. 2022-10-12 11:18:11 +02:00
de6401f97c Fix highlighting of points in students view of the grading report.
Bootstrap 5 migration issue
2022-10-12 10:58:34 +02:00
eed1883f23 Refactoring 2022-10-06 11:42:50 +02:00
1826ab5aa8 2891 Upgrade Hibernate and Jersey 2022-10-05 14:34:59 +02:00
76fd96b0ca Remove hibernate-validator since it was barely used 2022-09-28 15:15:25 +02:00
d7e8468c5a Refactoring 2022-09-23 02:28:26 +02:00
264fcb754a Remove dependency on joda-time 2022-09-22 12:53:50 +02:00
92d12bd5b2 Fix clockpicker
Did not render the proper javascript nonce so browsers refused to initialize it.
2022-09-22 10:19:42 +02:00
40411188a4 Refactoring 2022-09-22 10:19:42 +02:00
f84e5df817 Fix project title when viewing opposition feedback on the grading report. 2022-09-21 20:29:35 +02:00
20b392b964 2856 Supervisors must provide information on how the rejection comment from the examiner has been rectified.
PSAM (represented by Panos), Paul, and Jakob decided in a meeting on sep 8 2022 that supervisors must provide feedback as to how the examiners rejection comment has been rectified.
2022-09-21 11:23:25 +02:00
7e986ac17a Move oauth settings from the database to servlet context init parameters.
Since we now copy the database between servers the configuration breaks and integrations stop working. With the settings being external it will now continue to work after copying.
2022-09-21 11:19:49 +02:00
1ea3a746b2 Fix problem finalizing supervisor grading reports 2022-09-15 16:29:56 +02:00
90bf0f33e9 Refactoring 2022-09-15 15:07:30 +02:00
0549bc8ee0 2842 Show how many points pass/fail criterion give
It was confusing for supervisors when criterion showed no points with the point-to-grade conversion table.

Easier to show that they are worth 1p than trying to explain that they must all be checked for a passing grade to be given.
2022-09-14 11:52:46 +02:00
6924f87f73 2841 Clear old motivation
When lowering the assessment of a criterion such that motivation is no longer required the motivation should be cleared.
2022-09-14 10:37:39 +02:00
c3bc31f4ab Fix warning 2022-09-12 16:00:50 +02:00
9c86589140 Refactoring 2022-09-12 15:08:23 +02:00
e2d7a641ee 2842 Easier to fill out grading report
Criteria with 0 (fail) / 1 (pass) are now shown as simple checkboxes instead.
2022-09-12 15:06:25 +02:00
3427467b7a 2841 Easier to fill out the grading report
Only require motivation to be filled in if they have given more points that required to pass.
2022-09-12 14:20:52 +02:00
605b6ba1a7 2838 Simplified code 2022-09-12 12:38:06 +02:00
da61362397 2837 Simplified code 2022-09-12 10:59:01 +02:00
f3724edb2f 2839 Peer reviews are now per project type
If students abort a project and start a new one their peer reviews will be visible and milestones completed.
2022-09-08 13:50:38 +02:00
8769c21d8a 2838 2837 Activate completed milestones on new projects
Since both oppositions and active participations are showed based on the projects level the milestones should be activated to reflect that.

Had to redo project creation since the use of a serialized project entity caused lazy initialization exceptions when traversing the object graph (to determine if milestones were activated for the type).
2022-09-07 13:52:05 +02:00
0618196422 Replaced some java.util.Date with java.time 2022-09-01 11:56:38 +02:00
2da7bab524 2828 Expected end date must be after start date 2022-08-31 14:54:22 +02:00
5ece9dda93 2828 Give project start date its own attribute instead of stealing audit data 2022-08-31 14:49:58 +02:00
f84594665d 2741 2738 TR
It will be very complicated and not worth it to still have a clickable link to show the opposition feedback once the grading report is locked.
2022-08-29 11:08:50 +02:00