Commit Graph

6912 Commits

Author SHA1 Message Date
903ade76db 2984 PO 4) Save every approval by the examiners 2023-09-12 14:04:57 +02:00
2fbd644221 3181 Kan inte ta bort systemmeddelande 2023-09-12 12:16:38 +02:00
434837f0e1 3122 Stöd för manuell hantering av slutsem för handledare 2023-09-12 12:14:41 +02:00
3e408d143c 2984 PO 4) Save every rejection by an examiner 2023-09-12 11:55:15 +02:00
ab7f382163 3122 Stöd för manuell hantering av slutsem för handledare 2023-09-12 10:23:49 +02:00
db27ce8361 3181 Kan inte ta bort systemmeddelande 2023-09-11 15:09:41 +02:00
2eafad2b29 2984 PO 4) Timeline of examiner interactions (wip) 2023-09-11 15:06:58 +02:00
7a192d1b92 2984 PO 2) Text fixes 2023-09-11 09:45:30 +02:00
aa383d980c Merge branch 'develop' into 1584-abstract-keywords
# Conflicts:
#	view/src/main/java/se/su/dsv/scipro/grading/CriteriaPanel.java
#	view/src/main/java/se/su/dsv/scipro/project/panels/FinalStepsPanel.html
#	view/src/main/java/se/su/dsv/scipro/project/panels/FinalStepsPanel.java
#	view/src/test/java/se/su/dsv/scipro/SciProTest.java
#	view/src/test/java/se/su/dsv/scipro/grading/CriteriaPanelTest.java
#	view/src/test/java/se/su/dsv/scipro/grading/FillOutGradingReportPanelTest.java
2023-09-06 16:31:14 +02:00
1f70bd56e1 3104 Add required indicator and some textual improvements 2023-09-06 14:56:55 +02:00
nikos dimitrakas
92ad0ca334 3035 Fixade ytterligare en NPE. 2023-08-25 12:35:54 +02:00
nikos dimitrakas
53152e28bc 3035 Fixade NPE och test som misslyckades. Oklart om mina ändringar är korrekta. 2023-08-25 12:19:51 +02:00
Filip Kantar
9014a310ce 3035: SciPro DB changes:
Grading criteria template changes: added new columns for english titles and descriptions (grading_criterion_template and grading_criterion_point_template),
updated the criteria with new ones, in both languages, in their respective columns.
Specific changes for Master templates, 15hp version: Added 3p option (for U5, U6 and U7) and updated pointsRequiredToPass from 1 to 2 (for U5, U6, U7 and U13).
Specific changes for Magister templates, 0hp and 30hp versions: Removed 3p option (for U5, U6, U7) and 4p (for U13) and updated pointsRequiredToPass from 2 to 1 (for U5, U6, U7 and U13).

Changes for already copied criteria: added new columns for english titles and descriptions (GradingCriterion, GradingCriterionPoint and criterion).
For grading reports, older already copied criteria have been updated to the same format as the new ones, but with the old texts, in both languages.
For opposition reports, the old ones are left as they were, but with the same content copied to the new english columns. New ones will be available in both languages.

SciPro changes:
The criteria in the "Grading report" tab and the grading report PDF will be shown in the project's set language, if no language is set, swedish will be selected for bachelor and english for the rest.
The same applies to the opposition reports, but only for new ones, the old ones will still use the same language that was used when the criteria were copied.

Additions to the Grading report PDF: Added total points. Showing the full history of the reviewer's comments.
2023-07-02 21:50:43 +02:00
779c6922c9 3069 Send keywords and abstract to Daisy 2023-06-26 13:01:53 +02:00
08962b6f76 3134 Send out notification to authors when their active participation gets a failed grade. 2023-06-26 12:54:29 +02:00
5f328b4c29 3134 Send out notification to authors when their active participation is approved, but they have not yet done all the required ones. 2023-06-26 12:48:05 +02:00
c1fcf8ce4b 3134 Send out notification to authors when their opposition gets a failed grade. 2023-06-26 12:33:18 +02:00
7b6c1406d8 Remove max length of titles on supervisor start page 2023-06-20 14:07:09 +02:00
9876a896a6 Visual improvements when viewing authors submitted reflection as supervisor 2023-06-15 18:22:40 +02:00
5b294c8df4 3110 Inform authors how the final thesis and reflection will be submitted 2023-06-15 17:58:35 +02:00
a85dad2aa6 3074 Simple prototype of survey followup as a base for discussion 2023-06-09 16:37:49 +02:00
7c42ba67dc 3116 Handle projects without Daisy connection when performing the final steps as an author 2023-06-09 09:56:06 +02:00
2c921bf97f 3104 Enable students to add publication metadata
Abstract and keywords in both English and Swedish
2023-06-08 16:27:29 +02:00
aa99b600e5 Merge branch 'develop' into 1584-abstract-keywords 2023-06-08 09:42:49 +02:00
e6b5c47b8f 2984 Add points to each criterion on the grading basis 2023-06-02 09:57:40 +02:00
30b5b5e0db 2984 Fixed saving grading basis 2023-06-02 09:47:42 +02:00
567812f1ce 3068 Better text and fix scrolling issues 2023-05-26 08:29:43 +02:00
1bfdccd093 3083 Upgrade Flyway 2023-05-25 16:38:59 +02:00
4b1865f4d5 2984 Removed unused code 2023-05-24 17:29:22 +02:00
52f58ca27f 2984 Add examiner rejection feedback to the grading basis 2023-05-24 14:55:55 +02:00
cdf493c05e 2984 Handle the case when there is plagiarism in the submitted final thesis. 2023-05-24 14:23:49 +02:00
fa17169e77 3064 Show active participation requirements when sending an author for examination to enable supervisors to make sure it's been done. 2023-05-24 13:11:32 +02:00
cf8735438f 2984 Easier access to the thesis document and text matching report when doing the plagiarism analysis 2023-05-24 11:12:51 +02:00
0d21197235 2984 HTML improvements 2023-05-24 11:11:23 +02:00
113d35e216 2984 Abstracted away URKUND behind the text matching interface 2023-05-23 23:03:27 +02:00
704c87e993 2984 Refactoring 2023-05-22 14:01:14 +02:00
4b419ef643 2984 Tests for submitting plagiarism analysis 2023-05-22 14:01:05 +02:00
e6b6187490 Merge branch 'develop' into 1584-abstract-keywords
# Conflicts:
#	pom.xml
2023-05-22 12:47:16 +02:00
cbae067cc1 2984 Send to examiner button is individual 2023-05-11 16:33:03 +02:00
d18b45f7b4 2984 Add button to send to examiner once all pre-requisites steps are completed. 2023-05-11 16:10:27 +02:00
d2020302ee 2984 Instructions for the final sending to examiner step 2023-05-11 15:57:01 +02:00
6eca580297 2984 Correctly show final thesis and plagiarism status 2023-05-04 16:07:25 +02:00
ef0ce207b5 2984 Text clarifications 2023-05-04 16:07:03 +02:00
82cacd9b58 2984 Maintain scroll position when updating grading basis 2023-05-04 15:47:09 +02:00
d98e4e9608 2984 Tab for individual assessment 2023-05-04 15:44:14 +02:00
ab36939105 2984 Criteria panel is only for individual criteria since the separate grading basis covers the rest 2023-05-04 14:39:19 +02:00
b4d5bd41e9 2984 Extract the red/green label as a stand-alone component 2023-05-04 14:31:29 +02:00
3a7d4bfb23 2984 Remove unnecessary parameter 2023-05-04 12:16:46 +02:00
4a55c18460 2984 Simplified generics 2023-05-04 12:11:14 +02:00
a3c8cc9d4b 2984 HTML formatting 2023-05-04 11:59:37 +02:00
3e05f220db 2984 Remove extra padding around save button 2023-05-03 16:09:41 +02:00
e4db5090cb 2984 Disable editing of grading basis when it's submitted 2023-05-03 16:08:30 +02:00
1a09b05b8b 1584 Switch to a tabbed layout 2023-05-03 13:56:54 +02:00
nikos dimitrakas
5a3e0f7dc8 3066 TR 2023-04-18 11:54:15 +02:00
0ab37f0b81 3066 Handle trying to edit non-existing activities 2023-04-17 13:44:24 +02:00
6df949fb0b 3068 Add back sorting by deadline 2023-04-17 11:57:13 +02:00
b41d0d5b56 3068 Support different sorting parameters in custom columns 2023-04-14 12:03:29 +02:00
2a7abcf82d 3068 Display the correct requested date 2023-04-14 11:31:09 +02:00
5afdb90301 1584 Fix tests 2023-04-13 16:25:25 +02:00
3b1f0d4144 Merge remote-tracking branch 'origin/develop' into 1584-abstract-keywords
# Conflicts:
#	view/src/main/java/se/su/dsv/scipro/grading/ReviewerGradingReportPdf.java
#	view/src/test/java/se/su/dsv/scipro/grading/ReviewerFillOutGradingReportPanelTest.java
2023-04-13 14:48:49 +02:00
d7003b2dea tr 1584 Fixa korrekt hantering av abstract och keywords 2023-04-12 16:26:05 +02:00
5f0a5204d7 2996 Removed grading report snapshot from phase 2 review 2023-04-12 15:50:21 +02:00
80b359414c 2996 Simplified the rough draft approval page 2023-04-12 15:50:20 +02:00
b26296461c 2996 Remove old final seminar approval GUI 2023-04-12 15:50:14 +02:00
34dbf8a9cd 2996 Removed old grading process for reviewers with filling in the grading basis. 2023-04-12 15:50:08 +02:00
Filip Kantar
8d8c0f4340 2935: TR Adjusted approved/rejected texts. 2023-04-05 16:53:52 +02:00
Filip Kantar
f4ec2f6dae 3035: Improved the design of the grading report. Using swedish language for bachelor and english for master. Added fonts to use with the generated pdf report. 2023-04-05 15:20:35 +02:00
Filip Kantar
0948b02201 3035: Improved the design of the grading report. Using swedish language for bachelor and english for master. Added fonts to use with the generated pdf report. 2023-04-05 15:17:26 +02:00
Filip Kantar
85f29ee144 Merge remote-tracking branch 'origin/2935-post-phase-2-feedback-to-forum' into develop 2023-04-04 17:57:19 +02:00
478f16c713 3021 Fix editing keywords 2023-04-03 12:46:06 +02:00
251113c67e Better comments 2023-03-31 16:34:48 +02:00
581bfc9409 1584 Hide swedish abstract and keywords for english theses 2023-03-30 15:45:05 +02:00
318e851da0 1584 Allow students to fill in metadata if they chose to allow publication 2023-03-30 15:38:29 +02:00
a6fd7c655d 1584 Allow supervisors to fill in publication metadata 2023-03-30 12:21:41 +02:00
ed2a8803cf 1584 Add new step to the finishing up process to supply publication metadata 2023-03-30 10:00:57 +02:00
fe88f97aa2 Send grades when pressing button 2023-03-30 09:53:39 +02:00
106176262f Verbify the steps 2023-03-30 09:53:39 +02:00
582ff46fe5 Text improvements 2023-03-30 09:53:39 +02:00
c919e7db31 Show help text for final thesis upload 2023-03-30 09:53:39 +02:00
a565eedaed Save text matching analysis per project instead of per author 2023-03-30 09:53:39 +02:00
2e3fc5f5e7 Show all reviewer related events (communication, approvals, and rejections) on the supervisor grading basis page. 2023-03-30 09:53:39 +02:00
f8c6b0985a Removed pointless nesting 2023-03-30 09:53:39 +02:00
d2796ac8f8 Sonar 2023-03-30 09:53:39 +02:00
8493a0e7d2 Made the final thesis and plagiarism control look and feel like the rest 2023-03-30 09:53:39 +02:00
c91ba09913 Made grading basis form styling match the other panels and kept the active author visible 2023-03-30 09:53:39 +02:00
a1932d6a4f Only show phase two review help while submitting 2023-03-30 09:53:39 +02:00
7ba4d66556 2984 Rearranged the supervisor project menu to match the process order 2023-03-30 09:53:39 +02:00
7ad435558b 2984 Unified look of supervisor pages.
Use same type of panels for the first meeting, phase 2 review, and final seminar that is also used on the overview.
2023-03-30 09:53:39 +02:00
89264498ba 3050 Nicer labels 2023-03-23 09:40:54 +01:00
4aa512f4cf 3050 Styling improvements 2023-03-23 09:39:45 +01:00
8f675fda60 3050 Removed usages of deprecated class 2023-03-23 09:35:17 +01:00
f1d59d7d0e 3050 Test cleanup 2023-03-23 09:33:39 +01:00
c4b268a9ea 3050 Fix changing supervisors on projects with a reviewer assigned 2023-03-23 09:32:39 +01:00
c4c7f592a7 Sonar 2023-02-13 10:51:29 +01:00
239d26eb61 3019 Fix trying to upload non-PDF as seminar document
Can't throw exceptions in @Transactional methods or the EntityManager gets put in a weird state. Causes the involved entities (FinalSeminar) to be detached which leads to LazyInitializationExceptions.
2023-02-10 19:39:49 +01:00
f084d6d289 2943 Add english titles to the supervisors grading basis 2023-02-10 11:45:06 +01:00
b9245ac023 Sonar 2023-02-09 16:43:40 +01:00
dba133176a Midway point to allow upgrading Flyway to the newest version
See https://flywaydb.org/documentation/learnmore/releaseNotes#5.0.0 for why we must upgrade to 4.2.0 first
2023-02-09 16:40:06 +01:00
9ab7640d23 2934 Reviewers report PF examination when approving phase two 2023-02-09 11:57:00 +01:00
d3e6bdcf38 2934 Simplified the rough draft approval page 2023-02-09 11:57:00 +01:00
61f8dfcad8 2934 Remove old final seminar approval GUI 2023-02-09 11:57:00 +01:00
ecc8462886 2934 Removed old grading process for reviewers with filling in the grading basis. 2023-02-09 11:56:54 +01:00
7868c05664 3015 Hide seminar documents for non-related authors 2023-02-08 11:44:02 +01:00
4b880785fc Merge branch '2909-single-motivation-grading-basis' into develop 2023-02-06 15:18:33 +01:00
d9d6f41662 Simplified file handling 2023-02-06 14:50:23 +01:00
43f8158ed9 2854 Updated consent level descriptions 2023-02-04 11:37:21 +01:00
a86b46523b Merge remote-tracking branch 'origin/2854-reflection-ux-improvement' into develop
# Conflicts:
#	view/src/main/java/se/su/dsv/scipro/finalthesis/FinalThesisUploadFormPanel.html
2023-02-03 14:20:55 +01:00
e9d9dd9dff 2854 Fix showing of survey after finishing the final steps 2023-01-24 12:03:45 +01:00
4d18f9af15 2983 Text improvements when supervisors send grade suggestion to the examiner 2023-01-23 13:47:04 +01:00
b69ce4e5b8 Replace existing files when copying the database
When copying the database the newly generated primary key for a new file may point to an already existing file from before the copying. Simply overwrite this existing file if necessary.
2023-01-17 14:44:17 +01:00
dbd0d65e65 Sonar 2023-01-12 16:46:08 +01:00
63f6881e08 2935 Reviewers feedback during phase 2 review is forwarded to students. 2023-01-12 12:13:35 +01:00
b3b4a25dcd Sonar fixes 2023-01-12 10:16:07 +01:00
8a941e3164 Removed double required indicators 2023-01-12 09:50:54 +01:00
ba684d457b HTML improvements (Sonar) 2023-01-12 09:28:15 +01:00
db4db70493 Styling fixes 2023-01-11 09:31:52 +01:00
d867901f1d 2944 Make the final thesis file and metadata available for authors after the supervisor approves it. 2023-01-09 13:50:03 +01:00
86f44095b3 Fix sorting on title for sysadmins under Project management / Projects 2023-01-09 12:50:41 +01:00
9fb1e5eac5 2909 Single motivation field for the supervisors in their grading assessment.
New process for thesis grading.
2023-01-09 12:47:52 +01:00
116c219dbd 2854 Improved the UX when submitting reflection and the other final steps. 2022-12-22 17:02:19 +01:00
cce46d940c Fixed styling of the recipient selection under "Admin / Mail / Compose" 2022-12-17 14:55:16 +01:00
bd669d1c86 2911 Include the reviewers comment when approving phase 2 in the grading basis sent examiners 2022-12-16 14:32:10 +01:00
c7684922a5 2911 Update the heading of the supervisors grading basis.
To prevent confusion that this is a final protocol or some other deciding document if the authors requests the material used to give them their grade. The generated PDF is merely a tool the examiners use to set the final grade.
2022-12-16 11:48:10 +01:00
9325b5be93 2911 Remove the calculated grade from the supervisors grading basis.
To prevent confusion that this is a reported grade if the authors requests the material used to give them their grade. The generated PDF is merely a tool the examiners use to set the final grade.
2022-12-16 11:46:23 +01:00
dcad2c82b2 Sonar. 2022-12-06 16:54:10 +01:00
92303a6345 Replace <b> with <strong> (Sonar) 2022-12-06 16:22:37 +01:00
9a18d62d3e 2054 Search should work when API is offline. Turn off searching in Daisy when profile DAISY-INTEGRATION is turned off. 2022-12-06 16:22:37 +01:00
a2b2de2c17 Fix broken view. 2022-12-06 13:07:13 +01:00
d869737922 Clean up 2022-12-02 16:38:48 +01:00
8ecd3ded0d Remove authors access to the supervisors submitted basis for examiner grading.
The new process means the author will get access to a full protocol after the thesis has been approved by the examiner. It includes everything the examiner uses to set the final grade, not just what the supervisor provides.
2022-12-02 16:38:48 +01:00
068882207b 2875 TR fix text 2022-12-02 16:29:06 +01:00
41c0a653ff Merge branch '2874-publishing-consent' into develop 2022-12-02 16:14:39 +01:00
38207310cc 2875 TR fix text 2022-12-02 16:13:38 +01:00
70841ea88b 2936 Stop supervisors from posting the grading report to the forum
It is not the supervisor who sets the grade, so it is confusing for the supervisor to post a "grade report" with a grade to the students. What the supervisors fill in is a support document for the examiner to set the final grade. The students will, once the examiner approves the thesis, get access to the full grading report with the motivation for the final grade.
2022-12-01 12:15:23 +01:00
nikos dimitrakas
9cc3c33932 Sonar (isEmpty istället för att jämföra size/length med noll) 2022-12-01 10:04:21 +01:00
1bbf5ad0f8 Fix bug with gradingCriterion.requiresMotivation 2022-11-27 13:08:43 +01:00
2575b3ecb2 Sonar 2022-11-25 13:12:35 +01:00
65b09eccdd 2929 Allow sorting tables by single user columns
Uses a generated column behind the scenes which may be problematic due to the current testing infrastructure.
2022-11-25 11:33:04 +01:00
3ef98731b3 Add rel="noopener" to external links to prevent hijacking the SciPro window if the external system is compromised 2022-11-24 13:46:49 +01:00
4fc1a661f7 2874 Allow authors to give consent to publish their thesis 2022-11-22 12:08:01 +01:00
02fd8d6893 2929 Remove sortability from supervisor column 2022-11-22 12:02:57 +01:00
973addf196 2933 Make description and prerequisites on chosen supervisor ideas available during the application period 2022-11-22 10:36:30 +01:00
df0e5f051d Remove duplicate mail implementation 2022-11-14 18:04:41 +01:00
d6fae7660d Fix automated error mails
After upgrading to the new jakarta.mail namespace log4j2 was still trying to use javax.mail. Added a log4j2 module to make it use jakarta.mail instead
2022-11-14 15:34:51 +01:00
3b5bae8ba3 Simplifying 2022-11-14 10:38:46 +01:00
b0eb8a0f7f Improve performance of big lists containing users 2022-11-14 10:24:46 +01:00
12f670a846 Remove broken auto save 2022-11-09 15:18:46 +01:00
9a6a7ab677 Remove reliance on global state (ObjectMother) that enforced a specific test run order to pass the test suite. 2022-11-09 14:41:11 +01:00
4bfeec61e5 2863 Remind supervisors that it's time to grade when rough draft gets approved 2022-11-09 12:44:54 +01:00
6cfd52e213 Refactoring 2022-11-09 11:28:09 +01:00
3c06b1d2cd 2915 Enable students to view description of chosen supervisor ideas 2022-11-07 21:46:38 +01:00
36d8431281 2875 Include the reflection in the grading report 2022-11-07 21:26:56 +01:00
3076524cc2 2854 Allow authors to submit their reflection 2022-11-07 21:04:08 +01:00
2fe16b9b15 Show exception page during development 2022-11-07 19:18:00 +01:00
071e1c6509 Merge remote-tracking branch 'origin/develop' into develop 2022-10-31 19:18:14 +01:00
f01ca429f4 2860 TR change text 2022-10-31 19:17:59 +01:00
9c1481626a Merge branch 'develop' into 2856 2022-10-25 20:40:47 +02:00
60b5feb159 2861 Prevent supervisors from scheduling seminars if they have not gotten their submitted rough draft approved 2022-10-25 13:26:31 +02:00
3da035e950 2861 Refactoring 2022-10-25 13:26:31 +02:00
48cd7aa9c9 2861 Schedule final seminars 2022-10-25 13:26:31 +02:00
48799ed298 2861 Refactor updating final seminar details 2022-10-25 13:26:31 +02:00
2b42ad1d16 2861 Create a dedicated method for scheduling seminars that is responsible for checking all the rules 2022-10-25 13:26:31 +02:00
5acf93e7cb 2860 Added mandatory minimums for final seminar participations to report graded examinations.
Supervisors are able to ignore the requirement in case the seminars have been held outside the system or for any other reason.
2022-10-19 14:51:23 +02:00
b83b4da1af Speed up deployment 2022-10-18 12:49:49 +02:00
e02006bfd1 Upgrade to servlet specification 4.0 2022-10-18 12:14:42 +02:00
0dadabec07 Stop users getting logged during restarts 2022-10-18 10:24:51 +02:00
8fa7a17a07 Fix faulty JPA mapping 2022-10-17 20:02:19 +02:00
ccaa50ad67 Clean up 2022-10-13 12:04:25 +02:00
e15cdcd535 2883 Help text for supervisors explaining the new motivation requirements on the grading report. 2022-10-12 11:29:06 +02:00
9e89861e19 Styling improvements for the students view of the grading report. 2022-10-12 11:18:11 +02:00
de6401f97c Fix highlighting of points in students view of the grading report.
Bootstrap 5 migration issue
2022-10-12 10:58:34 +02:00
eed1883f23 Refactoring 2022-10-06 11:42:50 +02:00
1826ab5aa8 2891 Upgrade Hibernate and Jersey 2022-10-05 14:34:59 +02:00
76fd96b0ca Remove hibernate-validator since it was barely used 2022-09-28 15:15:25 +02:00
d7e8468c5a Refactoring 2022-09-23 02:28:26 +02:00
264fcb754a Remove dependency on joda-time 2022-09-22 12:53:50 +02:00
92d12bd5b2 Fix clockpicker
Did not render the proper javascript nonce so browsers refused to initialize it.
2022-09-22 10:19:42 +02:00
40411188a4 Refactoring 2022-09-22 10:19:42 +02:00
f84e5df817 Fix project title when viewing opposition feedback on the grading report. 2022-09-21 20:29:35 +02:00
20b392b964 2856 Supervisors must provide information on how the rejection comment from the examiner has been rectified.
PSAM (represented by Panos), Paul, and Jakob decided in a meeting on sep 8 2022 that supervisors must provide feedback as to how the examiners rejection comment has been rectified.
2022-09-21 11:23:25 +02:00
7e986ac17a Move oauth settings from the database to servlet context init parameters.
Since we now copy the database between servers the configuration breaks and integrations stop working. With the settings being external it will now continue to work after copying.
2022-09-21 11:19:49 +02:00
5ab6446817 Update log4j2 2022-09-17 17:13:53 +02:00
1ea3a746b2 Fix problem finalizing supervisor grading reports 2022-09-15 16:29:56 +02:00
90bf0f33e9 Refactoring 2022-09-15 15:07:30 +02:00
0549bc8ee0 2842 Show how many points pass/fail criterion give
It was confusing for supervisors when criterion showed no points with the point-to-grade conversion table.

Easier to show that they are worth 1p than trying to explain that they must all be checked for a passing grade to be given.
2022-09-14 11:52:46 +02:00
6924f87f73 2841 Clear old motivation
When lowering the assessment of a criterion such that motivation is no longer required the motivation should be cleared.
2022-09-14 10:37:39 +02:00
c3bc31f4ab Fix warning 2022-09-12 16:00:50 +02:00
9c86589140 Refactoring 2022-09-12 15:08:23 +02:00
e2d7a641ee 2842 Easier to fill out grading report
Criteria with 0 (fail) / 1 (pass) are now shown as simple checkboxes instead.
2022-09-12 15:06:25 +02:00
3427467b7a 2841 Easier to fill out the grading report
Only require motivation to be filled in if they have given more points that required to pass.
2022-09-12 14:20:52 +02:00
605b6ba1a7 2838 Simplified code 2022-09-12 12:38:06 +02:00
da61362397 2837 Simplified code 2022-09-12 10:59:01 +02:00
f3724edb2f 2839 Peer reviews are now per project type
If students abort a project and start a new one their peer reviews will be visible and milestones completed.
2022-09-08 13:50:38 +02:00
8769c21d8a 2838 2837 Activate completed milestones on new projects
Since both oppositions and active participations are showed based on the projects level the milestones should be activated to reflect that.

Had to redo project creation since the use of a serialized project entity caused lazy initialization exceptions when traversing the object graph (to determine if milestones were activated for the type).
2022-09-07 13:52:05 +02:00
0618196422 Replaced some java.util.Date with java.time 2022-09-01 11:56:38 +02:00
2da7bab524 2828 Expected end date must be after start date 2022-08-31 14:54:22 +02:00
5ece9dda93 2828 Give project start date its own attribute instead of stealing audit data 2022-08-31 14:49:58 +02:00
f84594665d 2741 2738 TR
It will be very complicated and not worth it to still have a clickable link to show the opposition feedback once the grading report is locked.
2022-08-29 11:08:50 +02:00
43b56df46c 2828 Allow supervisors to edit project start date 2022-08-28 20:09:47 +02:00
e1e16f6a45 2828 Allow admin to edit start and end dates 2022-08-28 20:09:47 +02:00
7d1a965119 2738 Prevent supervisors from grading the opposition criteria unless they explicitly request it 2022-08-24 16:51:21 +02:00
7617fdfb05 2741 Enable supervisors to see any available opposition feedback during grading 2022-08-24 11:06:31 +02:00
33f0b6a3e5 Upgrade SLF4J 2022-08-22 13:55:04 +02:00
c4d9cf454d 2736 Clarify that any messages came from URKUND 2022-08-10 10:19:51 +02:00
a73f273ea7 2760 Remove confusing text for authors during grading 2022-07-07 16:01:14 +02:00
7b5813926c 2553 Remove unused dependency 2022-07-07 15:58:00 +02:00
0985c59689 2740 Fix finalize button on grading reports
Authors with a ' in their name caused problems with the javascript.
2022-06-23 14:24:35 +02:00
db61f5554b 2736 Allow resubmitting documents to URKUND if processing failed. 2022-06-20 16:32:07 +02:00
220908b033 Fix problems when supervisor uploads final thesis caused by trying to present the student survey. 2022-06-09 17:03:33 +02:00
93915195b1 Fix problems reporting grades due to missing titles. 2022-06-09 16:53:00 +02:00
27b65521e1 2720 Fix problems sorting under Project / Files 2022-06-08 19:33:06 +02:00
968724a770 Limit length of Swedish/English title fields to match the database. 2022-06-01 10:08:47 +02:00
a8570eef53 Sync the error codes from grading service. 2022-06-01 10:05:24 +02:00
f44aed23f9 Merge branch 'develop' into 2553-fix-file-deletion
# Conflicts:
#	core/src/main/java/se/su/dsv/scipro/phd/StudyPlanServiceImpl.java
#	view/src/test/java/se/su/dsv/scipro/repository/panels/ProjectFilePanelTest.java
2022-05-20 18:39:35 +02:00
942070a147 2562 Update Daisy API XSD 2022-05-19 12:35:38 +02:00
ac4b40062b 2569 Show watson instead of empty tholander box for old ideas 2022-05-18 10:57:45 +02:00
e6b147fbfc 2553 Only allow file deletion for files added via files tab 2022-05-13 09:35:14 +02:00
a267d20693 2583 Removed PhD specific parts 2022-05-11 12:30:33 +02:00
ddc28cc598 2515 Sync theses' research area to Daisy 2022-05-09 13:49:25 +02:00
957f899834 2553 Migrate peer review to file references 2022-05-07 15:56:40 +02:00
7afbb75caa 2553 Migrate peer request 2022-05-05 17:33:05 +02:00
f6e84c88d1 2553 Migrate reviewer decisions 2022-05-05 16:50:44 +02:00
9ad4e2e711 2553 Migrate opposition report attachments 2022-05-04 16:27:49 +02:00
3898bb5077 2553 Migrate old seminar opposition reports 2022-05-04 14:46:22 +02:00
71acbe8e64 2553 Migrate final thesis text matching document to file reference 2022-05-04 13:44:37 +02:00
e387e83152 2553 Migrate final thesis document to file reference 2022-05-04 13:01:02 +02:00
323c3a622d 2553 Stream data to URKUND instead of buffering 2022-05-04 11:09:04 +02:00
3114f9d79f 2553 Migrate seminar and text matching to references 2022-05-02 16:57:41 +02:00
bb18c364c1 2553 Migrate activity plan to use file references 2022-04-28 16:05:29 +02:00
cd22c3fcd4 2553 Migrate forum to use file references 2022-04-28 10:58:57 +02:00
7a455b7db3 2553 Migrate project files to use file references 2022-04-27 11:39:02 +02:00
189d79da9b 2553 Rename FileDescriptionService to FileService
Better names for the file handling since it deals with files, not the implementation specific FileDescription @Entity used to store metadata.
2022-04-25 10:06:41 +02:00
b7c42aa13e 2484 TR 2022-04-13 12:36:28 +02:00
0ac85267b3 Make footer links open in a new window 2022-04-05 10:59:50 +02:00
00d44d68d2 2173 Close button for supervisors after updating research areas 2022-03-30 10:24:15 +02:00
13a7a51271 2525 Prevent research area from accidentally changing on existing ideas when supervisors research areas changed 2022-03-28 13:43:03 +02:00
cbbe39ba04 2543 Upgrade to Bootstrap 5
Replaced margins with Bootstrap utilities
Fixed spacing between the menus
Fix auto-complete not working inside dialogs
Replaced form-control with form-select on <select>
Fixed duplicate required indicators
Harmonize <textarea> sizing with other form controls
Remove duplicate required indicators
Remove gap between menu bars in admin section
Replace .sr-only with .visually-hidden
Removed .btn-block
Fix faulty CSS rules
Migrate .form-group to .mb-3
Migrate JavaScript heavy components to Bootstrap 5
Modals, dropdowns, date-/timepickers.
2022-03-28 10:27:08 +02:00
27c0bac987 Fix displaying of old ideas
2523 2519
2022-03-16 13:10:25 +01:00
3e7fc8af6b Improve UX when editing own/chosen ideas
2522 2521 2520
2022-03-16 13:10:25 +01:00
nikos dimitrakas
03edfcde89 2173 TR språkfix 2022-03-15 16:32:12 +01:00
41c872d1a9 2525 Prevent accidentally changing research area when the selected one is inactive 2022-03-10 14:25:06 +01:00
977642de30 2525 Prevent accidentally changing research area when the selected one is inactive 2022-03-10 14:14:31 +01:00
04c66529ef Refactoring 2022-03-10 14:04:36 +01:00
17ed285772 2484 Disable bookmarkable URLs 2022-03-10 14:03:20 +01:00
0c292819ca 2484 Disable bookmarkable URLs 2022-03-10 13:52:40 +01:00
529550d1ec 2173 Allow supervisors to update their research areas immediately when creating ideas 2022-03-09 15:23:25 +01:00
d5cdf45966 Fix the palette to work with CSP enabled 2022-03-09 13:47:17 +01:00
f85dd67904 HTML clean up 2022-03-09 13:31:43 +01:00
1ad4325530 2446 Make application periods and student ideas available for viewing by supervisors in the matching period (end->course start) 2022-03-03 13:37:14 +01:00
7b35cd3177 2446 Validating and matching is now done together rather than separately 2022-03-03 13:37:14 +01:00