Commit Graph

6912 Commits

Author SHA1 Message Date
61f8dfcad8 2934 Remove old final seminar approval GUI 2023-02-09 11:57:00 +01:00
ecc8462886 2934 Removed old grading process for reviewers with filling in the grading basis. 2023-02-09 11:56:54 +01:00
7868c05664 3015 Hide seminar documents for non-related authors 2023-02-08 11:44:02 +01:00
4b880785fc Merge branch '2909-single-motivation-grading-basis' into develop 2023-02-06 15:18:33 +01:00
d9d6f41662 Simplified file handling 2023-02-06 14:50:23 +01:00
43f8158ed9 2854 Updated consent level descriptions 2023-02-04 11:37:21 +01:00
a86b46523b Merge remote-tracking branch 'origin/2854-reflection-ux-improvement' into develop
# Conflicts:
#	view/src/main/java/se/su/dsv/scipro/finalthesis/FinalThesisUploadFormPanel.html
2023-02-03 14:20:55 +01:00
e9d9dd9dff 2854 Fix showing of survey after finishing the final steps 2023-01-24 12:03:45 +01:00
4d18f9af15 2983 Text improvements when supervisors send grade suggestion to the examiner 2023-01-23 13:47:04 +01:00
b69ce4e5b8 Replace existing files when copying the database
When copying the database the newly generated primary key for a new file may point to an already existing file from before the copying. Simply overwrite this existing file if necessary.
2023-01-17 14:44:17 +01:00
dbd0d65e65 Sonar 2023-01-12 16:46:08 +01:00
63f6881e08 2935 Reviewers feedback during phase 2 review is forwarded to students. 2023-01-12 12:13:35 +01:00
b3b4a25dcd Sonar fixes 2023-01-12 10:16:07 +01:00
8a941e3164 Removed double required indicators 2023-01-12 09:50:54 +01:00
ba684d457b HTML improvements (Sonar) 2023-01-12 09:28:15 +01:00
db4db70493 Styling fixes 2023-01-11 09:31:52 +01:00
d867901f1d 2944 Make the final thesis file and metadata available for authors after the supervisor approves it. 2023-01-09 13:50:03 +01:00
86f44095b3 Fix sorting on title for sysadmins under Project management / Projects 2023-01-09 12:50:41 +01:00
9fb1e5eac5 2909 Single motivation field for the supervisors in their grading assessment.
New process for thesis grading.
2023-01-09 12:47:52 +01:00
116c219dbd 2854 Improved the UX when submitting reflection and the other final steps. 2022-12-22 17:02:19 +01:00
cce46d940c Fixed styling of the recipient selection under "Admin / Mail / Compose" 2022-12-17 14:55:16 +01:00
bd669d1c86 2911 Include the reviewers comment when approving phase 2 in the grading basis sent examiners 2022-12-16 14:32:10 +01:00
c7684922a5 2911 Update the heading of the supervisors grading basis.
To prevent confusion that this is a final protocol or some other deciding document if the authors requests the material used to give them their grade. The generated PDF is merely a tool the examiners use to set the final grade.
2022-12-16 11:48:10 +01:00
9325b5be93 2911 Remove the calculated grade from the supervisors grading basis.
To prevent confusion that this is a reported grade if the authors requests the material used to give them their grade. The generated PDF is merely a tool the examiners use to set the final grade.
2022-12-16 11:46:23 +01:00
dcad2c82b2 Sonar. 2022-12-06 16:54:10 +01:00
92303a6345 Replace <b> with <strong> (Sonar) 2022-12-06 16:22:37 +01:00
9a18d62d3e 2054 Search should work when API is offline. Turn off searching in Daisy when profile DAISY-INTEGRATION is turned off. 2022-12-06 16:22:37 +01:00
a2b2de2c17 Fix broken view. 2022-12-06 13:07:13 +01:00
d869737922 Clean up 2022-12-02 16:38:48 +01:00
8ecd3ded0d Remove authors access to the supervisors submitted basis for examiner grading.
The new process means the author will get access to a full protocol after the thesis has been approved by the examiner. It includes everything the examiner uses to set the final grade, not just what the supervisor provides.
2022-12-02 16:38:48 +01:00
068882207b 2875 TR fix text 2022-12-02 16:29:06 +01:00
41c0a653ff Merge branch '2874-publishing-consent' into develop 2022-12-02 16:14:39 +01:00
38207310cc 2875 TR fix text 2022-12-02 16:13:38 +01:00
70841ea88b 2936 Stop supervisors from posting the grading report to the forum
It is not the supervisor who sets the grade, so it is confusing for the supervisor to post a "grade report" with a grade to the students. What the supervisors fill in is a support document for the examiner to set the final grade. The students will, once the examiner approves the thesis, get access to the full grading report with the motivation for the final grade.
2022-12-01 12:15:23 +01:00
nikos dimitrakas
9cc3c33932 Sonar (isEmpty istället för att jämföra size/length med noll) 2022-12-01 10:04:21 +01:00
1bbf5ad0f8 Fix bug with gradingCriterion.requiresMotivation 2022-11-27 13:08:43 +01:00
2575b3ecb2 Sonar 2022-11-25 13:12:35 +01:00
65b09eccdd 2929 Allow sorting tables by single user columns
Uses a generated column behind the scenes which may be problematic due to the current testing infrastructure.
2022-11-25 11:33:04 +01:00
3ef98731b3 Add rel="noopener" to external links to prevent hijacking the SciPro window if the external system is compromised 2022-11-24 13:46:49 +01:00
4fc1a661f7 2874 Allow authors to give consent to publish their thesis 2022-11-22 12:08:01 +01:00
02fd8d6893 2929 Remove sortability from supervisor column 2022-11-22 12:02:57 +01:00
973addf196 2933 Make description and prerequisites on chosen supervisor ideas available during the application period 2022-11-22 10:36:30 +01:00
df0e5f051d Remove duplicate mail implementation 2022-11-14 18:04:41 +01:00
d6fae7660d Fix automated error mails
After upgrading to the new jakarta.mail namespace log4j2 was still trying to use javax.mail. Added a log4j2 module to make it use jakarta.mail instead
2022-11-14 15:34:51 +01:00
3b5bae8ba3 Simplifying 2022-11-14 10:38:46 +01:00
b0eb8a0f7f Improve performance of big lists containing users 2022-11-14 10:24:46 +01:00
12f670a846 Remove broken auto save 2022-11-09 15:18:46 +01:00
9a6a7ab677 Remove reliance on global state (ObjectMother) that enforced a specific test run order to pass the test suite. 2022-11-09 14:41:11 +01:00
4bfeec61e5 2863 Remind supervisors that it's time to grade when rough draft gets approved 2022-11-09 12:44:54 +01:00
6cfd52e213 Refactoring 2022-11-09 11:28:09 +01:00
3c06b1d2cd 2915 Enable students to view description of chosen supervisor ideas 2022-11-07 21:46:38 +01:00
36d8431281 2875 Include the reflection in the grading report 2022-11-07 21:26:56 +01:00
3076524cc2 2854 Allow authors to submit their reflection 2022-11-07 21:04:08 +01:00
2fe16b9b15 Show exception page during development 2022-11-07 19:18:00 +01:00
071e1c6509 Merge remote-tracking branch 'origin/develop' into develop 2022-10-31 19:18:14 +01:00
f01ca429f4 2860 TR change text 2022-10-31 19:17:59 +01:00
9c1481626a Merge branch 'develop' into 2856 2022-10-25 20:40:47 +02:00
60b5feb159 2861 Prevent supervisors from scheduling seminars if they have not gotten their submitted rough draft approved 2022-10-25 13:26:31 +02:00
3da035e950 2861 Refactoring 2022-10-25 13:26:31 +02:00
48cd7aa9c9 2861 Schedule final seminars 2022-10-25 13:26:31 +02:00
48799ed298 2861 Refactor updating final seminar details 2022-10-25 13:26:31 +02:00
2b42ad1d16 2861 Create a dedicated method for scheduling seminars that is responsible for checking all the rules 2022-10-25 13:26:31 +02:00
5acf93e7cb 2860 Added mandatory minimums for final seminar participations to report graded examinations.
Supervisors are able to ignore the requirement in case the seminars have been held outside the system or for any other reason.
2022-10-19 14:51:23 +02:00
b83b4da1af Speed up deployment 2022-10-18 12:49:49 +02:00
e02006bfd1 Upgrade to servlet specification 4.0 2022-10-18 12:14:42 +02:00
0dadabec07 Stop users getting logged during restarts 2022-10-18 10:24:51 +02:00
8fa7a17a07 Fix faulty JPA mapping 2022-10-17 20:02:19 +02:00
ccaa50ad67 Clean up 2022-10-13 12:04:25 +02:00
e15cdcd535 2883 Help text for supervisors explaining the new motivation requirements on the grading report. 2022-10-12 11:29:06 +02:00
9e89861e19 Styling improvements for the students view of the grading report. 2022-10-12 11:18:11 +02:00
de6401f97c Fix highlighting of points in students view of the grading report.
Bootstrap 5 migration issue
2022-10-12 10:58:34 +02:00
eed1883f23 Refactoring 2022-10-06 11:42:50 +02:00
1826ab5aa8 2891 Upgrade Hibernate and Jersey 2022-10-05 14:34:59 +02:00
76fd96b0ca Remove hibernate-validator since it was barely used 2022-09-28 15:15:25 +02:00
d7e8468c5a Refactoring 2022-09-23 02:28:26 +02:00
264fcb754a Remove dependency on joda-time 2022-09-22 12:53:50 +02:00
92d12bd5b2 Fix clockpicker
Did not render the proper javascript nonce so browsers refused to initialize it.
2022-09-22 10:19:42 +02:00
40411188a4 Refactoring 2022-09-22 10:19:42 +02:00
f84e5df817 Fix project title when viewing opposition feedback on the grading report. 2022-09-21 20:29:35 +02:00
20b392b964 2856 Supervisors must provide information on how the rejection comment from the examiner has been rectified.
PSAM (represented by Panos), Paul, and Jakob decided in a meeting on sep 8 2022 that supervisors must provide feedback as to how the examiners rejection comment has been rectified.
2022-09-21 11:23:25 +02:00
7e986ac17a Move oauth settings from the database to servlet context init parameters.
Since we now copy the database between servers the configuration breaks and integrations stop working. With the settings being external it will now continue to work after copying.
2022-09-21 11:19:49 +02:00
5ab6446817 Update log4j2 2022-09-17 17:13:53 +02:00
1ea3a746b2 Fix problem finalizing supervisor grading reports 2022-09-15 16:29:56 +02:00
90bf0f33e9 Refactoring 2022-09-15 15:07:30 +02:00
0549bc8ee0 2842 Show how many points pass/fail criterion give
It was confusing for supervisors when criterion showed no points with the point-to-grade conversion table.

Easier to show that they are worth 1p than trying to explain that they must all be checked for a passing grade to be given.
2022-09-14 11:52:46 +02:00
6924f87f73 2841 Clear old motivation
When lowering the assessment of a criterion such that motivation is no longer required the motivation should be cleared.
2022-09-14 10:37:39 +02:00
c3bc31f4ab Fix warning 2022-09-12 16:00:50 +02:00
9c86589140 Refactoring 2022-09-12 15:08:23 +02:00
e2d7a641ee 2842 Easier to fill out grading report
Criteria with 0 (fail) / 1 (pass) are now shown as simple checkboxes instead.
2022-09-12 15:06:25 +02:00
3427467b7a 2841 Easier to fill out the grading report
Only require motivation to be filled in if they have given more points that required to pass.
2022-09-12 14:20:52 +02:00
605b6ba1a7 2838 Simplified code 2022-09-12 12:38:06 +02:00
da61362397 2837 Simplified code 2022-09-12 10:59:01 +02:00
f3724edb2f 2839 Peer reviews are now per project type
If students abort a project and start a new one their peer reviews will be visible and milestones completed.
2022-09-08 13:50:38 +02:00
8769c21d8a 2838 2837 Activate completed milestones on new projects
Since both oppositions and active participations are showed based on the projects level the milestones should be activated to reflect that.

Had to redo project creation since the use of a serialized project entity caused lazy initialization exceptions when traversing the object graph (to determine if milestones were activated for the type).
2022-09-07 13:52:05 +02:00
0618196422 Replaced some java.util.Date with java.time 2022-09-01 11:56:38 +02:00
2da7bab524 2828 Expected end date must be after start date 2022-08-31 14:54:22 +02:00
5ece9dda93 2828 Give project start date its own attribute instead of stealing audit data 2022-08-31 14:49:58 +02:00
f84594665d 2741 2738 TR
It will be very complicated and not worth it to still have a clickable link to show the opposition feedback once the grading report is locked.
2022-08-29 11:08:50 +02:00
43b56df46c 2828 Allow supervisors to edit project start date 2022-08-28 20:09:47 +02:00
e1e16f6a45 2828 Allow admin to edit start and end dates 2022-08-28 20:09:47 +02:00
7d1a965119 2738 Prevent supervisors from grading the opposition criteria unless they explicitly request it 2022-08-24 16:51:21 +02:00
7617fdfb05 2741 Enable supervisors to see any available opposition feedback during grading 2022-08-24 11:06:31 +02:00
33f0b6a3e5 Upgrade SLF4J 2022-08-22 13:55:04 +02:00
c4d9cf454d 2736 Clarify that any messages came from URKUND 2022-08-10 10:19:51 +02:00
a73f273ea7 2760 Remove confusing text for authors during grading 2022-07-07 16:01:14 +02:00
7b5813926c 2553 Remove unused dependency 2022-07-07 15:58:00 +02:00
0985c59689 2740 Fix finalize button on grading reports
Authors with a ' in their name caused problems with the javascript.
2022-06-23 14:24:35 +02:00
db61f5554b 2736 Allow resubmitting documents to URKUND if processing failed. 2022-06-20 16:32:07 +02:00
220908b033 Fix problems when supervisor uploads final thesis caused by trying to present the student survey. 2022-06-09 17:03:33 +02:00
93915195b1 Fix problems reporting grades due to missing titles. 2022-06-09 16:53:00 +02:00
27b65521e1 2720 Fix problems sorting under Project / Files 2022-06-08 19:33:06 +02:00
968724a770 Limit length of Swedish/English title fields to match the database. 2022-06-01 10:08:47 +02:00
a8570eef53 Sync the error codes from grading service. 2022-06-01 10:05:24 +02:00
f44aed23f9 Merge branch 'develop' into 2553-fix-file-deletion
# Conflicts:
#	core/src/main/java/se/su/dsv/scipro/phd/StudyPlanServiceImpl.java
#	view/src/test/java/se/su/dsv/scipro/repository/panels/ProjectFilePanelTest.java
2022-05-20 18:39:35 +02:00
942070a147 2562 Update Daisy API XSD 2022-05-19 12:35:38 +02:00
ac4b40062b 2569 Show watson instead of empty tholander box for old ideas 2022-05-18 10:57:45 +02:00
e6b147fbfc 2553 Only allow file deletion for files added via files tab 2022-05-13 09:35:14 +02:00
a267d20693 2583 Removed PhD specific parts 2022-05-11 12:30:33 +02:00
ddc28cc598 2515 Sync theses' research area to Daisy 2022-05-09 13:49:25 +02:00
957f899834 2553 Migrate peer review to file references 2022-05-07 15:56:40 +02:00
7afbb75caa 2553 Migrate peer request 2022-05-05 17:33:05 +02:00
f6e84c88d1 2553 Migrate reviewer decisions 2022-05-05 16:50:44 +02:00
9ad4e2e711 2553 Migrate opposition report attachments 2022-05-04 16:27:49 +02:00
3898bb5077 2553 Migrate old seminar opposition reports 2022-05-04 14:46:22 +02:00
71acbe8e64 2553 Migrate final thesis text matching document to file reference 2022-05-04 13:44:37 +02:00
e387e83152 2553 Migrate final thesis document to file reference 2022-05-04 13:01:02 +02:00
323c3a622d 2553 Stream data to URKUND instead of buffering 2022-05-04 11:09:04 +02:00
3114f9d79f 2553 Migrate seminar and text matching to references 2022-05-02 16:57:41 +02:00
bb18c364c1 2553 Migrate activity plan to use file references 2022-04-28 16:05:29 +02:00
cd22c3fcd4 2553 Migrate forum to use file references 2022-04-28 10:58:57 +02:00
7a455b7db3 2553 Migrate project files to use file references 2022-04-27 11:39:02 +02:00
189d79da9b 2553 Rename FileDescriptionService to FileService
Better names for the file handling since it deals with files, not the implementation specific FileDescription @Entity used to store metadata.
2022-04-25 10:06:41 +02:00
b7c42aa13e 2484 TR 2022-04-13 12:36:28 +02:00
0ac85267b3 Make footer links open in a new window 2022-04-05 10:59:50 +02:00
00d44d68d2 2173 Close button for supervisors after updating research areas 2022-03-30 10:24:15 +02:00
13a7a51271 2525 Prevent research area from accidentally changing on existing ideas when supervisors research areas changed 2022-03-28 13:43:03 +02:00
cbbe39ba04 2543 Upgrade to Bootstrap 5
Replaced margins with Bootstrap utilities
Fixed spacing between the menus
Fix auto-complete not working inside dialogs
Replaced form-control with form-select on <select>
Fixed duplicate required indicators
Harmonize <textarea> sizing with other form controls
Remove duplicate required indicators
Remove gap between menu bars in admin section
Replace .sr-only with .visually-hidden
Removed .btn-block
Fix faulty CSS rules
Migrate .form-group to .mb-3
Migrate JavaScript heavy components to Bootstrap 5
Modals, dropdowns, date-/timepickers.
2022-03-28 10:27:08 +02:00
27c0bac987 Fix displaying of old ideas
2523 2519
2022-03-16 13:10:25 +01:00
3e7fc8af6b Improve UX when editing own/chosen ideas
2522 2521 2520
2022-03-16 13:10:25 +01:00
nikos dimitrakas
03edfcde89 2173 TR språkfix 2022-03-15 16:32:12 +01:00
41c872d1a9 2525 Prevent accidentally changing research area when the selected one is inactive 2022-03-10 14:25:06 +01:00
977642de30 2525 Prevent accidentally changing research area when the selected one is inactive 2022-03-10 14:14:31 +01:00
04c66529ef Refactoring 2022-03-10 14:04:36 +01:00
17ed285772 2484 Disable bookmarkable URLs 2022-03-10 14:03:20 +01:00
0c292819ca 2484 Disable bookmarkable URLs 2022-03-10 13:52:40 +01:00
529550d1ec 2173 Allow supervisors to update their research areas immediately when creating ideas 2022-03-09 15:23:25 +01:00
d5cdf45966 Fix the palette to work with CSP enabled 2022-03-09 13:47:17 +01:00
f85dd67904 HTML clean up 2022-03-09 13:31:43 +01:00
1ad4325530 2446 Make application periods and student ideas available for viewing by supervisors in the matching period (end->course start) 2022-03-03 13:37:14 +01:00
7b35cd3177 2446 Validating and matching is now done together rather than separately 2022-03-03 13:37:14 +01:00
a5422158cc 2446 Prevent supervisors from taking ideas during the matching period 2022-03-03 13:37:14 +01:00
94115c1632 2484 TR 2022-03-02 12:19:06 +01:00
5f1ffaece9 2485 Upgraded from old Excel format to new Office Open XML format 2022-02-28 14:18:50 +01:00
5290eba32e 2484 Turn off exception logging on invalid URLs 2022-02-24 11:44:08 +01:00
3f29783b63 2173 Make it easier to continue to idea creation after importing research areas 2022-02-24 11:17:35 +01:00
nikos dimitrakas
a52c854ba2 2173 TR Kolla att man har minst ett aktivt forskningsområde. 2022-02-17 10:02:38 +01:00
nikos dimitrakas
1b2fd571eb Tog bort konstigt tecken 2022-02-17 09:12:40 +01:00
nikos dimitrakas
9388fde4ac Språkanpassningar vid användning av etc. 2022-02-16 14:28:28 +01:00
nikos dimitrakas
ccd80cd8d3 2502 TR Anpassade case till hur det visas i Daisy och på webben. 2022-02-16 14:13:37 +01:00
53e85865ce 2502 Research area selection improvements
* Allow supervisors to pick inactive research areas when editing projects.
* Clearly mark inactive research areas as such
2022-02-16 09:17:49 +01:00
750fac828f 2402 Allow students to remove their own partner ad 2022-02-11 12:14:57 +01:00
26e8993503 Refactoring 2022-02-11 12:05:53 +01:00
ed16f95917 Fix bug showing status for worker that did not run 2022-02-11 11:56:22 +01:00
d076ca43d9 Fix bug changing the days partner ads are visible 2022-02-11 11:54:37 +01:00
db854ef3f6 2404 Student can change partners on accepted supervisor idea 2022-02-09 20:23:27 +01:00
0a4156d884 2494 Admins can edit project research area 2022-02-08 19:22:31 +01:00
03db13f073 2474 TR 2022-01-28 11:00:51 +01:00
nikos dimitrakas
d26c6abd0c Stavfel 2022-01-27 11:34:37 +01:00
ee407a39c0 Replace with built-in Wicket functionality 2022-01-27 11:08:35 +01:00
7819e7b80c 2449 2474 Research area changes
* Research area follows from idea to project phase
* Research area can be edited by supervisors
* Research area must be confirmed by supervisor when they request reviewer
2022-01-27 10:52:28 +01:00
61773eb56c 2480 Inform supervisors they do not have to take action when project creation fails 2022-01-18 15:00:42 +01:00
211a9da259 2173 Prevent supervisors from creating ideas if they have no research areas.
Provide a way for them to easily sync over their research areas from Daisy.
2022-01-16 21:22:06 +01:00
d360ed720f Fix for CVE-2017-9096 by replacing iText with the open source fork OpenPDF 2021-12-23 13:44:34 +01:00
577faac7c0 2441 Show projects research area in Admin / Projects instead of supervisors 2021-12-20 21:10:27 +01:00
4b9fffb9e6 2444 Research area must now be specified when requesting review approval 2021-12-19 17:36:52 +01:00
788ceec345 2433 Set research area when sending publication to Daisy 2021-12-19 17:33:13 +01:00
48f596d4af Fix (some) dependencies with known security holes 2021-12-13 15:57:32 +01:00
ce4135af49 Fix column label 2021-12-06 20:41:16 +01:00
abca57fae3 Move dependency versions to parent pom 2021-11-29 21:27:39 +01:00
4dff775a97 Upgrade Mockito and JUnit 2021-11-29 15:33:57 +01:00
a47509e1e5 Removed unused dependency.
62/62
2021-11-28 23:19:30 +01:00
adc7eb47fc Version upgrades
Preparation for new Java and Wicket versions.
2021-11-27 12:34:54 +01:00
4ae7a8bc0d Prevent students from submitting/selecting ideas outside the period by directly accessing the URL 2021-11-23 12:25:52 +01:00
52b68b3377 2407 Fixed tiny user auto completes in modal dialogs
Select2s built-in width calculations failed on AJAX created modal windows. Force them to always be 100% width and size them using a container if required.
2021-11-16 11:39:59 +01:00
ef4434e64c 2408 Improved text for the "no program" choice when creating/selecting ideas. 2021-11-16 11:37:09 +01:00
5f1ab1c481 Change SciPro CSS reference to using Wickets built in versioning. Fixes caching problems when changing CSS rules. 2021-11-16 01:04:09 +01:00
94f0cbd7a7 2403 Remove wrapping from project type name 2021-11-15 21:40:41 +01:00
9acf74c5ba 2403 Better layout when editing supervisor targets 2021-11-15 20:36:05 +01:00
2f0da6e432 Changed to a more specific type on FilteredService 2021-11-15 19:37:17 +01:00
bcb2a10895 2406 Project type exemption should be taken into account when selecing supervisor ideas 2021-11-12 17:41:12 +01:00
6171b97990 2398 Keep the admin menus when viewing final seminar details 2021-11-09 15:57:39 +01:00
d7c4035d68 2396 Better information for students when their project creation is delayed. 2021-11-09 15:48:06 +01:00
99a002a628 2395 Rejection comments from reviewer is posted by the system instead of the supervisor
43/62
2021-11-08 00:58:06 +01:00
86c18de12e Fix editing ideas outside the periods open date if the student has an exemption 2021-10-28 16:37:46 +02:00
c6e8c8b297 2085 TR 2021-10-13 16:57:13 +02:00
89d3d93cf8 Upgrade to Mockito 4
41/62
2021-10-13 16:17:16 +02:00
nikos dimitrakas
2331fc28ce 2085 TR stavfel och tydligare etikett. 2021-10-07 13:31:43 +02:00
5ffb505443 2085 Naming and label fixes 2021-10-04 15:49:57 +02:00
27173737ba 2085 Fixa undantagshantering på application periods 2021-10-01 17:05:55 +02:00
3f3607cd68 2085 Fixa undantagshantering på application periods 2021-10-01 15:20:44 +02:00
bd7f138d43 2085 Fixa undantagshantering på application periods 2021-10-01 13:38:20 +02:00
58d73d3247 Merge remote-tracking branch 'origin/2085-rule-based-application-period-exemptions' into develop 2021-10-01 11:29:28 +02:00
0a0e9fc5fd 2085 Improvements to the end date input.
Defaults to end date of the application period.
Only visible after selecting a rule that requires it.
Show the application period's end date to help pick the proper end date.
2021-09-30 16:53:26 +02:00
69b8245c4b 2085 Move end date required to the rule definition. 2021-09-30 15:46:01 +02:00
fabe3b2e6d 2085 Simplified date handling
Remove start date completely. Made until date only mandatory for the date based rules.
2021-09-30 15:30:22 +02:00
c6cb66cac1 Removed some usages of joda time 2021-09-27 16:00:17 +02:00
22d5f19698 2348 Upgrade jQuery
A bug in Select2 (https://github.com/select2/select2/issues/5993) due to focus changes in jQuery 3.6.0 (https://blog.jquery.com/2021/03/02/jquery-3-6-0-released/) needs a workaround to properly focus the textfield when opening an autocomplete component.
2021-09-23 11:06:29 +02:00
6c7db4d863 Fixed faulty escaping 2021-09-23 10:33:38 +02:00
888b58202a 2353 Replace var with explicit type 2021-09-22 20:03:39 +02:00
a8ea0e7736 2085 Change application period exemption to specific rules 2021-09-22 19:54:15 +02:00
156cf96036 2082 TR 2021-09-16 14:27:14 +02:00
879d9b4159 2082: TR Bättre namn på klasser, enums, variabler, kolumnnamn, etc. Uppgraderade xsd:n för API:et. 2021-09-15 16:34:56 +02:00
9afe1e3e4b 2082 Ignore programs that do not have a type 2021-09-09 10:46:47 +02:00
c904fad8dc 2082 Sync over students degree level instead of education level 2021-09-07 15:48:47 +02:00
cd15862c67 Fixed error spam when using ContextRelativeResourceReference in tests 2021-09-07 12:38:13 +02:00
4771d1d076 Sped up compilation
38/62
2021-09-04 23:44:10 +02:00
df29bd86ca 2282 Enable CSP 2021-09-01 01:37:50 +02:00
828516acf6 2282 Fixed final inline Javascript 2021-09-01 01:37:37 +02:00
a5ff9cce9b 2282 Fixed inline Javascript 2021-09-01 01:18:54 +02:00
81e4db19d6 2282 Fixed custom file input 2021-08-31 15:44:09 +02:00
541a8fa4df 2282 Fixed scroll sneak 2021-08-31 15:30:25 +02:00
4898a41441 2282 Removed migration aid 2021-08-31 15:21:34 +02:00
142c35c5a6 2282 Fixed last Javascript confirmations 2021-08-31 15:18:49 +02:00
8bf397afa4 2282 Fixed confirmation popup 2021-08-31 14:54:14 +02:00
8f7174ad2f 2282 Fixed final inline event handler in HTML 2021-08-31 14:38:53 +02:00
6ec6c3e152 2282 Removed inline style 2021-08-31 13:30:27 +02:00
80b9c57549 2282 Fixed most confirmation popups 2021-08-31 13:27:49 +02:00
d023328bed 2282 Migrated simple event handlers 2021-08-31 00:38:34 +02:00
31c42151a2 2282 Removed inline <style> tag 2021-08-27 12:04:42 +02:00
1532411211 2282 Removed final style attributes 2021-08-27 12:00:30 +02:00
d1085c9c8a 2282 Remove style attribute 2021-08-27 11:23:34 +02:00
cdcccf7c1d 2282 Fixed all style="display: none" 2021-08-27 11:22:07 +02:00
bae334528c 2282 CSP compliance on notification page 2021-08-27 11:22:07 +02:00
05a1211298 2282 Fix image position on user profile dialog 2021-08-27 11:22:07 +02:00
78727ff2da Clean up old code 2021-08-27 11:22:07 +02:00
afb19167c8 2282 CSP compliance for supervisor idea start page 2021-08-27 11:22:07 +02:00
323ea30a92 Refactoring
37/62
2021-08-27 11:22:07 +02:00
75d62315e2 2282 CSP compliance for editing checklist templates 2021-08-27 11:22:07 +02:00
882369379e 2282 CSP compliance for editing footer page 2021-08-27 11:22:07 +02:00
edd45108d7 2282 Whitelist the custom file input 2021-08-27 11:22:07 +02:00
92d6b17efa 2282 Fixed jQuery dependency for date picker 2021-08-27 11:22:07 +02:00
e76740d989 2282 Removed inline style attributes 2021-08-27 11:22:07 +02:00
c86727d11a 2282 Removed inline style attributes 2021-08-27 11:22:07 +02:00
7b4847d1b0 2282 Externalized inline javascript 2021-08-27 11:22:07 +02:00
c89f3c68c6 2282 Fix local javascripts in production not having minified versions 2021-08-27 11:22:07 +02:00
6cb1a189cb 2279 2277 Upgrade Guice and Guava 2021-08-24 11:38:58 +02:00
f403ccc1f1 2300 Prevent students from unselecting ideas after the period closed 2021-08-06 20:06:27 +02:00
f03475e819 Remove dangling CSS file 2021-07-20 10:45:55 +02:00
e01baa3aed Made the clockpicker CSP compliant (2282)
34/62
2021-07-20 10:45:55 +02:00
534466a8c8 Made all external javascript CSP compliant (2282) 2021-07-20 10:45:55 +02:00
80aa13acbf Made the datepicker CSP compliant (2282) 2021-07-20 10:45:55 +02:00
6f8d458cb8 Removed shims for IE8 and earlier 2021-07-20 10:45:55 +02:00
c5f678362c Removed inline style attribute from AJAX indicator.
Preparation for CPS compliance (2282)
2021-07-20 10:45:55 +02:00
88764978eb Removed more unnecessary CSS classes 2021-07-20 10:45:55 +02:00
24627452b3 Removed unused CSS classes 2021-07-20 10:45:55 +02:00
0cd05f8297 Removed a bunch of useless markup 2021-07-20 10:45:55 +02:00
223ad957f1 Removed style attribute from user profile picture.
Preparation for CPS compliance (2282)
2021-07-20 10:45:55 +02:00
29dcac9cf7 Remove old dangling javascript file 2021-07-20 10:45:55 +02:00
865e57abb0 2271 Fix NPE when trying to download the peer request file after the peer review has expired.
When the peer review expires but the user is still on the page clicking on the file download link will try to load up the in progress peer review of which there is none. Thus getPeerRequest() will be null and so also getFileDescription() which eventually NPE's when the IModel is unpacked and used in DownloadResource.
2021-06-15 22:39:14 +02:00
02d674f242 2281 Fix problems with authors viewing projects without a grading report template 2021-06-12 10:54:31 +02:00
7322f5f255 Removed unused/unnecessary dependencies. 2021-06-11 01:31:29 +02:00
4ffcaa6be9 2276 Better feedback when trying to replace the final seminar document with a non-PDF (or other error) 2021-06-10 15:07:04 +02:00
329eb6889d 1470 Help authors complete their project by allowing them to subscribe to notifications about new seminars to finish an opposition and active participation. 2021-06-10 14:19:50 +02:00
47005b4c0a 2269 Filter out supervisors who are no longer affiliated with DSV from the target management page 2021-06-06 19:52:47 +02:00
cacd7f199f 2266 Fix deprecated attribute 2021-05-25 11:44:23 +02:00
1f42f8024d 2225 Removed unused code 2021-05-25 00:39:45 +02:00
eb04f81879 2225 Replaced ChoiceRenderer with a lambda based implementation 2021-05-24 18:38:30 +02:00
cce8061276 2225 Replaced PropertyListView 2021-05-24 17:01:46 +02:00
247c9c3338 2225 Replaced CompoundPropertyModel with LambdaModel 2021-05-24 14:51:18 +02:00
cd885746df 2225 Removed warning suppression of unused code 2021-05-20 15:45:32 +02:00
d0514ad5b8 2225 Replaced PropertyColumn with LambdaColumn 2021-05-20 15:30:12 +02:00
28d77928bd 2225 Replaced PropertyModel with LambdaModel
33/62
2021-05-20 12:33:58 +02:00
da70367f1f Visual improvements for application period administration. 2021-05-20 11:07:48 +02:00
89fdc4b5bc Converted non work day periods to Java Time. 2021-05-19 14:56:48 +02:00
1d96343f90 2206 Upgrade to Wicket 9 2021-05-19 00:14:02 +02:00
1b70720054 1703 Inform supervisors that it takes time to get a reviewer assigned 2021-05-18 22:13:33 +02:00
25ed8d7c88 2248 Supervisor can specify extra info on seminar 2021-05-12 12:51:12 +02:00
d6dd7cf4fe Turn off autocomplete on date/time picker since the suggestions hide the pickers 2021-05-12 11:31:01 +02:00
f420966cb4 31/62 2021-05-12 11:23:22 +02:00
2e42981d53 2248 Max length on room when scheduling seminar 2021-05-12 10:23:12 +02:00
427139ed22 2206 Textual breakdown of the different answers 2021-05-11 17:39:11 +02:00
eb73f5fd6f 2206 Removed the graphical charts 2021-05-11 17:18:22 +02:00
08807f30e4 2232 Only reverse the events graphically so the indexes stay stable for Wicket 2021-05-05 16:53:15 +02:00
dc715890d1 Fixed styling of reviewer breadcrumbs 2021-05-05 16:40:02 +02:00
51de92b972 30/62 2021-05-04 22:56:03 +02:00
371e437f48 2235 Fix autolinking in forum 2021-04-27 19:19:25 +02:00
adf7ec1674 2197 Removed Lombok 2021-04-20 23:26:39 +02:00
f96c138a8a Generate GDPR zip files in /scipro-files
Users with large amounts of files related to them caused /tmp to be filled up. Manual deleting is required.
2021-04-20 14:50:33 +02:00
a1d3b3f014 2216 Peer reviews expiring during answering 2021-04-12 11:09:13 +02:00
f5b08975bc 2212 Larger dialog when viewing idea details
Prevents long supervisor names from overflowing outside the dialog
2021-04-07 11:05:39 +02:00
88e78cc15b 2213 Show better final thesis status 2021-04-06 16:45:41 +02:00
nikos dimitrakas
21ad4b6e57 2210: Lade till favicon. 2021-03-31 11:15:52 +02:00
ea3eedca57 2200 IndexOutOfBoundsException in forum
Wicket ListView is index based which means when the user tries to download a file it is the first attachment of the second post for example. Due to the forum being in newest first order, if another user posts in the forum while the first user is looking at it the second post in now the third post. The download link, however, still points to the second post which has no attachments causing the error. The change keeps the list in the oldest first order so the second post will always be the second post since new posts gets added last. Then CSS is applied to reverse the rendering order to maintain the current newest first look.
2021-03-26 15:45:29 +01:00
7a6749d4fc 26/62 2021-03-26 00:25:43 +01:00
6c55fb45d8 2203 Do not allow admins to create/edit projects 2021-03-23 20:27:03 +01:00
b17bfa0a72 2203 Do not allow admins to create/edit projects 2021-03-23 20:18:11 +01:00
cd27de1559 Fix deprecated warning 2021-03-16 16:30:05 +01:00
a24c098368 24/62 2021-03-16 16:17:24 +01:00
501d296aa5 Attempt to fix broken log file format.
Switches to logging via java.util.logging instead of writing to System.out
2021-03-14 20:59:56 +01:00
41b9a59297 Speed up Daisy batch jobs
Make use of the session cookie from Daisy API so slow reauthentication isn't required on every single request
2021-03-01 23:25:43 +01:00
a37ed701f9 2171 TR 2021-02-25 12:20:17 +01:00
656409822b 2180 Fix warning in log 2021-02-24 22:54:35 +01:00
b69cc295f7 2182 Fix log warning 2021-02-24 22:49:45 +01:00
84593a5a8c 21/62 2021-02-24 22:47:38 +01:00
0f8a8780bd 2171 Send titles to Daisy when reporting grade 2021-02-24 21:12:15 +01:00
4252ab9688 Make system notice easier to read 2021-02-23 22:00:47 +01:00
dc4cb86aec Refactor to improve performance
Before the examinations were looked up twice
2021-02-23 21:29:25 +01:00
04e07c51ea 2171 Handle title missing when reporting grade 2021-02-23 20:01:28 +01:00
225caa0dd6 2116 Confirmation when deleting idea 2021-02-17 17:14:49 +01:00
20207aabb3 1707 Separate the questions on the survey better 2021-02-17 17:12:33 +01:00
1be478d044 2116 Fix notification link for the removed partner 2021-02-17 16:52:21 +01:00
c809a2ff42 2118 E-mail address configurable 2021-02-16 15:25:28 +01:00
4af3dfdd38 Fix double date picker icons 2021-02-16 14:41:32 +01:00
2a8846323f 2055 mail all exceptions to scipro-admin@dsv.su.se 2021-02-16 14:35:18 +01:00
df7a8cdc83 Revert "2055 No longer mail exceptions to JIRA"
This reverts commit 97575581
2021-02-16 14:33:15 +01:00
7ab9d7d65f Merge remote-tracking branch 'origin/develop' into develop 2021-02-16 12:33:58 +01:00
cbe1e6db7f 2125 TR Small improvement 2021-02-16 12:31:29 +01:00
8fa9c61604 1976 Supervisors can change expected end date 2021-02-16 12:21:36 +01:00
d0b2e04224 1976 show expected end date 2021-02-16 12:12:03 +01:00
c4b00b3eb9 Fix annoying IntelliJ error 2021-02-16 11:38:14 +01:00
2e2195849c 1976 GUI to set end date on application periods 2021-02-16 10:32:51 +01:00
6f3e4c0872 2132 TR test fixes 2021-02-16 10:12:49 +01:00
36d0a5e04f 2143 TR 2021-02-16 10:01:06 +01:00
eb0e31d015 2132 TR Hide replacement link after seminar has happened and only show it for authors 2021-02-16 09:59:23 +01:00
cb38d10cf8 18/62 2021-02-15 15:03:25 +01:00
bf2a3ad22e Fix icon for time picker 2021-02-15 12:49:30 +01:00
2750abe694 Test fixes 2021-02-10 20:20:59 +01:00
1901d22e92 2143 Grading report available to students
When supervisors have submitted the grading report students can view it
2021-02-10 20:08:45 +01:00
473b467696 Shutdown MySQL driver to prevent memory leaks 2021-02-10 12:32:51 +01:00
975755816d 2055 No longer mail exceptions to JIRA
Switching logging implementation to java.util.Logging instead of log4j
2021-02-10 12:18:56 +01:00
5b50250c09 Fix annoying IntelliJ problem 2021-02-10 11:53:40 +01:00
951318ad5c 2132 Allow students to replace seminar document 2021-02-10 11:38:23 +01:00
26fed0ee23 2133 Remove self as opponent/participant on seminar 2021-02-09 13:43:43 +01:00
9e9cef678c 2118 Block accepting/sending idea when author has active project 2021-02-08 23:25:32 +01:00
1131eaac1b 2019 Replaced PropertyModel with LambdaModel 2021-02-04 20:54:26 +01:00
14921684d8 14/62 2021-02-04 19:20:15 +01:00
f5e71637ea 2019 Deprecation fixes 2021-02-02 23:45:50 +01:00
8c12667fdb 2125 Notify authors when supervisor schedules first meeting 2021-02-02 21:47:33 +01:00
8f702559b1 13/62 2021-02-02 20:26:50 +01:00
884a741647 2121 Peer review deadline is based on work days 2021-02-02 15:05:33 +01:00
aa8df2a4e4 2116 Allow students to unselect supervisor ideas 2021-01-29 19:58:58 +01:00
c02a14a8be 2116 Notify removed partner from idea 2021-01-29 12:07:25 +01:00
c07d535496 2134 Fix menu styling 2021-01-28 21:48:53 +01:00
d693b64c35 2116 Disable editing ideas when the application period is not open 2021-01-19 20:52:05 +01:00
dc6be38beb 2116 Delete student idea 2021-01-19 17:20:41 +01:00
af723242cc 2116 Populate program with current selection 2021-01-19 17:16:06 +01:00
4ea2ac0b0d 2116 Edit existing student ideas 2021-01-19 16:42:42 +01:00
8b8d690350 Remove dependencies on external libraries 2021-01-14 19:06:37 +01:00
b6ca9c5ff7 3/62 2021-01-14 16:32:50 +01:00
daf7afaaf3 2116 Populate program with current selection 2021-01-14 16:02:32 +01:00