17843 Commits

Author SHA1 Message Date
ee8ecfc74b Update transitive dependency protobuf-java to fix CVE-2022-3171 2022-10-13 12:13:16 +02:00
ccaa50ad67 Clean up 2022-10-13 12:04:25 +02:00
fa7f9ff1f7 2880 Copy over opposition assessment to the grading report if the assessment from the seminar is an improvement.
If a student had a failed opposition they would have 0 points on the grading report. When they later passed a seminar that improved assessment would not be copied over because the criterion was already assessed.
2022-10-12 11:39:11 +02:00
e15cdcd535 2883 Help text for supervisors explaining the new motivation requirements on the grading report. 2022-10-12 11:29:06 +02:00
9e89861e19 Styling improvements for the students view of the grading report. 2022-10-12 11:18:11 +02:00
96e3801caa Code clean up 2022-10-12 11:09:23 +02:00
bf1bdb183f Added missing @Transactional 2022-10-12 11:07:35 +02:00
de6401f97c Fix highlighting of points in students view of the grading report.
Bootstrap 5 migration issue
2022-10-12 10:58:34 +02:00
eed1883f23 Refactoring 2022-10-06 11:42:50 +02:00
1826ab5aa8 2891 Upgrade Hibernate and Jersey 2022-10-05 14:34:59 +02:00
820365bf14 Upgrade Jakarta Mail (and use the API) 2022-09-29 11:27:24 +02:00
76fd96b0ca Remove hibernate-validator since it was barely used 2022-09-28 15:15:25 +02:00
fc76a7ec98 Remove manual tracing instrumentation.
Use the Java Agent instead.
2022-09-28 14:58:53 +02:00
09dbaff940 Version upgrades 2022-09-28 12:12:01 +02:00
e811fd04e2 Switch to the new Jakarta dependencies for API specification. 2022-09-28 11:11:47 +02:00
6765da6480 Remove MOXy for XML/JSON (de)serialization
We now use JAXB for XML and Jackson for JSON. MOXy complects the two and make it harder to control the specific input/output expected.
2022-09-28 11:08:53 +02:00
d7e8468c5a Refactoring 2022-09-23 02:28:26 +02:00
264fcb754a Remove dependency on joda-time 2022-09-22 12:53:50 +02:00
92d12bd5b2 Fix clockpicker
Did not render the proper javascript nonce so browsers refused to initialize it.
2022-09-22 10:19:42 +02:00
40411188a4 Refactoring 2022-09-22 10:19:42 +02:00
Jenkins
21f727d5ec Merge commit 'f84e5df81738904ce8806b82c637014eb3dc9651' into HEAD release-255 2022-09-21 22:52:13 +02:00
f84e5df817 Fix project title when viewing opposition feedback on the grading report. 2022-09-21 20:29:35 +02:00
20b392b964 2856 Supervisors must provide information on how the rejection comment from the examiner has been rectified.
PSAM (represented by Panos), Paul, and Jakob decided in a meeting on sep 8 2022 that supervisors must provide feedback as to how the examiners rejection comment has been rectified.
2022-09-21 11:23:25 +02:00
7e986ac17a Move oauth settings from the database to servlet context init parameters.
Since we now copy the database between servers the configuration breaks and integrations stop working. With the settings being external it will now continue to work after copying.
2022-09-21 11:19:49 +02:00
5ab6446817 Update log4j2 2022-09-17 17:13:53 +02:00
Jenkins
672f2d6ec6 Merge commit '1ea3a746b2df3d7018207959968cd6af5ae19e6a' into HEAD release-254 2022-09-15 22:52:16 +02:00
1ea3a746b2 Fix problem finalizing supervisor grading reports 2022-09-15 16:29:56 +02:00
90bf0f33e9 Refactoring 2022-09-15 15:07:30 +02:00
0549bc8ee0 2842 Show how many points pass/fail criterion give
It was confusing for supervisors when criterion showed no points with the point-to-grade conversion table.

Easier to show that they are worth 1p than trying to explain that they must all be checked for a passing grade to be given.
2022-09-14 11:52:46 +02:00
6924f87f73 2841 Clear old motivation
When lowering the assessment of a criterion such that motivation is no longer required the motivation should be cleared.
2022-09-14 10:37:39 +02:00
Jenkins
39f78cf636 Merge commit '9c3e1d3b483db013d5ac01dd84c33367540fe638' into HEAD release-253 2022-09-12 21:58:09 +02:00
9c3e1d3b48 Remove unnecessary dependency 2022-09-12 16:24:28 +02:00
c3bc31f4ab Fix warning 2022-09-12 16:00:50 +02:00
9c86589140 Refactoring 2022-09-12 15:08:23 +02:00
e2d7a641ee 2842 Easier to fill out grading report
Criteria with 0 (fail) / 1 (pass) are now shown as simple checkboxes instead.
2022-09-12 15:06:25 +02:00
3427467b7a 2841 Easier to fill out the grading report
Only require motivation to be filled in if they have given more points that required to pass.
2022-09-12 14:20:52 +02:00
8d2b1fa974 2839 Fixed bug 2022-09-12 12:56:22 +02:00
605b6ba1a7 2838 Simplified code 2022-09-12 12:38:06 +02:00
da61362397 2837 Simplified code 2022-09-12 10:59:01 +02:00
f3724edb2f 2839 Peer reviews are now per project type
If students abort a project and start a new one their peer reviews will be visible and milestones completed.
2022-09-08 13:50:38 +02:00
8769c21d8a 2838 2837 Activate completed milestones on new projects
Since both oppositions and active participations are showed based on the projects level the milestones should be activated to reflect that.

Had to redo project creation since the use of a serialized project entity caused lazy initialization exceptions when traversing the object graph (to determine if milestones were activated for the type).
2022-09-07 13:52:05 +02:00
0618196422 Replaced some java.util.Date with java.time 2022-09-01 11:56:38 +02:00
5dc79a668b Upgrade Hibernate 2022-08-31 16:29:45 +02:00
2da7bab524 2828 Expected end date must be after start date 2022-08-31 14:54:22 +02:00
5ece9dda93 2828 Give project start date its own attribute instead of stealing audit data 2022-08-31 14:49:58 +02:00
f84594665d 2741 2738 TR
It will be very complicated and not worth it to still have a clickable link to show the opposition feedback once the grading report is locked.
2022-08-29 11:08:50 +02:00
43b56df46c 2828 Allow supervisors to edit project start date 2022-08-28 20:09:47 +02:00
e1e16f6a45 2828 Allow admin to edit start and end dates 2022-08-28 20:09:47 +02:00
7d1a965119 2738 Prevent supervisors from grading the opposition criteria unless they explicitly request it 2022-08-24 16:51:21 +02:00
7617fdfb05 2741 Enable supervisors to see any available opposition feedback during grading 2022-08-24 11:06:31 +02:00