Update supervisor's idea table immediately upon scheduling a first meeting #105

Merged
ansv7779 merged 4 commits from first-meeting-feedback into develop 2025-02-13 09:59:34 +01:00
Owner

Before, after scheduling a first meeting, they had to refresh the entire page to show the information in the table.

Fixes #82

How to test

  1. Log in as eve@example.com
  2. Go to the "Ideas" tab
  3. Schedule a first meeting
  4. See that the table is updated immediately on save
Before, after scheduling a first meeting, they had to refresh the entire page to show the information in the table. Fixes #82 ## How to test 1. Log in as `eve@example.com` 2. Go to the "Ideas" tab 3. Schedule a first meeting 4. See that the table is updated immediately on save
ansv7779 added 3 commits 2025-02-10 13:34:57 +01:00
Fix idea table being updated with first meeting information after scheduling
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m54s
Build and test / build-and-test (push) Successful in 22m49s
12badef08b
What happened was the idea was loaded (the model got attached) without a first meeting, then the first meeting was created separately in a different model. After creating the first meeting the second model had its object updated in place so no call to IModel#setObject was made. Even if it had been called since there was this separation the idea model would not have been updated either way. Implementing #setObject in the FirstMeetingModel (in FirstMeetingPanel) that would update the idea model would not have solved since its #setObject was never called.

To get around this we either have to update the idea models object in place (the chosen solution) or detaching it, forcing a reload from the database that would see the newly created first meeting.
ansv7779 added the
po
needed
label 2025-02-10 13:36:24 +01:00
First-time contributor
Deployed to https://scipro-first-meeting-feedback.branch.dsv.su.se
niat8586 requested review from niat8586 2025-02-11 08:37:57 +01:00
niat8586 reviewed 2025-02-11 08:45:57 +01:00
@ -173,0 +172,4 @@
FirstMeeting saved = firstMeetingRepository.save(getModelObject());
// After saving the first meeting we have to populate it on the already loaded idea to
// make sure that other places that want to render the first meeting get the correct data.
// An alternative would be to detach the idea model to force a database refresh.
Owner

Can the first meeting be edited from other users or from other places?

If it can maybe we should enforce a database refresh as per your comment of an alternative method.

If not then this is good in that we don't need to do a database refresh on the view we are in.

Can the first meeting be edited from other users or from other places? If it can maybe we should enforce a database refresh as per your comment of an alternative method. If not then this is good in that we don't need to do a database refresh on the view we are in.
Author
Owner

Yes it can be edited from other places (but always by the supervisor). However, I do not see how that is relevant? The issue is the table not updating when using the modal dialog to schedule a meeting.

Do you want the page with the table to update itself based on what happens on a different page if it happened to be open simultaneously?

Yes it can be edited from other places (but always by the supervisor). However, I do not see how that is relevant? The issue is the table not updating when using the modal dialog to schedule a meeting. Do you want the page with the table to update itself based on what happens on a different page if it happened to be open simultaneously?
Owner

We discussed yesterday (2025-02-11) in person, and I am happy with the resolution we got to. So we keep it as is.

We discussed yesterday (2025-02-11) in person, and I am happy with the resolution we got to. So we keep it as is.
niat8586 marked this conversation as resolved
ansv7779 added 1 commit 2025-02-12 15:13:22 +01:00
Merge branch 'develop' into first-meeting-feedback
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m41s
Build and test / build-and-test (push) Successful in 15m49s
Remove branch deployment from branch.dsv.su.se / cleanup (pull_request) Successful in 11s
973a41a563
# Conflicts:
#	core/src/main/java/se/su/dsv/scipro/DataInitializer.java
niat8586 approved these changes 2025-02-12 15:17:49 +01:00
niat8586 left a comment
Owner

👍

👍
ansv7779 added this to the SciPro project 2025-02-12 17:08:38 +01:00
ansv7779 moved this to PO Review in SciPro on 2025-02-12 17:08:43 +01:00
ansv7779 moved this to PO Review in SciPro on 2025-02-12 17:09:09 +01:00
ansv7779 removed this from the SciPro project 2025-02-12 17:09:13 +01:00
Owner

PO review OK

PO review OK
andan added
po
approved
and removed
po
needed
labels 2025-02-13 09:06:39 +01:00
ansv7779 merged commit b9f7dd5a49 into develop 2025-02-13 09:59:34 +01:00
ansv7779 deleted branch first-meeting-feedback 2025-02-13 09:59:35 +01:00
Sign in to join this conversation.
No description provided.