DMC/scipro
7
0
Fork 0
Code Issues 32 Pull Requests 6 Actions Projects 1 Wiki Activity

Deadline visible in "Rough draft approval" page #106

Merged
ansv7779 merged 7 commits from rough-draft-approval-deadline into develop 2025-02-12 11:07:55 +01:00
Conversation 3 Commits 7 Files Changed 6 +99 -6
niat8586 commented 2025-02-11 11:32:13 +01:00
Owner
Copy Link

Previously deadline was only visible at the Reviewer start page, tab 'Rough draft approvals'.

Now the deadline is also shown when you go to the detail page of a rough draft.

Fixes issue #99

How to test:

  1. Log in as eric@example.com
  2. Switch to Reviewer role
  3. Note the deadline date, then click on the title 'Preserving quality in thesis work'
  4. Under the Rough draft approval section (under status) verify that the 'Deadline' is the same date as in step 3.
Previously deadline was only visible at the Reviewer start page, tab 'Rough draft approvals'. Now the deadline is also shown when you go to the detail page of a rough draft. Fixes issue #99 ## How to test: 1) Log in as eric@example.com 2) Switch to Reviewer role 3) Note the deadline date, then click on the title 'Preserving quality in thesis work' 4) Under the Rough draft approval section (under status) verify that the 'Deadline' is the same date as in step 3.
niat8586 added 1 commit 2025-02-11 11:32:13 +01:00
Deadline visible in "Rough draft approval" page
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m52s
Details
Build and test / build-and-test (push) Successful in 17m32s
Details
6ca6c63743 
Previously deadline was only visible at the Reviewer start page, tab 'Rough draft approvals'.

Now the deadline is also shown when you go to the detail page of a rough draft.

Fixes issue #99
gitea-actions commented 2025-02-11 11:36:06 +01:00
First-time contributor
Copy Link

Deployed to https://scipro-rough-draft-approval-deadline.branch.dsv.su.se

Deployed to https://scipro-rough-draft-approval-deadline.branch.dsv.su.se
niat8586 changed title from Deadline visible in "Rough draft approval" page to WIP: Deadline visible in "Rough draft approval" page 2025-02-11 12:51:40 +01:00
niat8586 added 1 commit 2025-02-11 13:08:00 +01:00
Added test data for the deadline in rough draft approval
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m41s
Details
Build and test / build-and-test (push) Has been cancelled
Details
1139797735 
1) Log in as eric@example.com
2) Switch to Reviewer role
3) Note the deadline date, then click on the title 'Preserving quality in thesis work'
4) Under the Rough draft approval section (under status) verify that the 'Deadline' is the same date as in step 3.
niat8586 added 1 commit 2025-02-11 13:20:55 +01:00
Make reviewer pages testable on test servers.
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m40s
Details
Build and test / build-and-test (push) Has been cancelled
Details
e05fbb54c9
niat8586 added 1 commit 2025-02-11 13:27:05 +01:00
Make reviewer pages testable on test servers.
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m53s
Details
Build and test / build-and-test (push) Has been cancelled
Details
5490750d83 
Added another oauth container
niat8586 added 1 commit 2025-02-11 13:35:46 +01:00
Make reviewer pages testable on test servers.
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m54s
Details
Build and test / build-and-test (push) Successful in 17m39s
Details
1dd4471f68 
Added another oauth container

3rd time is the charm
niat8586 added 1 commit 2025-02-11 14:15:50 +01:00
Make reviewer pages testable on test servers.
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 5m22s
Details
Build and test / build-and-test (push) Successful in 18m30s
Details
54bd0eea9e 
Added scopes and "correct" client redirect uri.
niat8586 added 1 commit 2025-02-11 14:34:57 +01:00
Make reviewer pages testable on test servers.
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m56s
Details
Build and test / build-and-test (push) Successful in 16m33s
Details
Remove branch deployment from branch.dsv.su.se / cleanup (pull_request) Successful in 8s
Details
02b60c2bd3 
Added scopes and "correct" client redirect uri.
niat8586 changed title from WIP: Deadline visible in "Rough draft approval" page to Deadline visible in "Rough draft approval" page 2025-02-11 14:41:44 +01:00
niat8586 added the
po
needed
 label 2025-02-11 14:41:57 +01:00
ansv7779 approved these changes 2025-02-11 14:56:40 +01:00
ansv7779 left a comment
Owner
Copy Link

Simple and good change for the reviewers with automated tests as well 🥇

Making the reviewer views work on the test servers is very good change. Still lots of work to be done on that front but this is a step in the right direction.

Simple and good change for the reviewers with automated tests as well 🥇 Making the reviewer views work on the test servers is very good change. Still lots of work to be done on that front but this is a step in the right direction.
👍 1
niat8586 commented 2025-02-12 08:49:37 +01:00
Author
Owner
Copy Link

Simple and good change for the reviewers with automated tests as well 🥇

Making the reviewer views work on the test servers is very good change. Still lots of work to be done on that front but this is a step in the right direction.

Credit where credit is due @ansv7779 was a major contributor to making the reviewer views work on the test servers.

> Simple and good change for the reviewers with automated tests as well 🥇 > > Making the reviewer views work on the test servers is very good change. Still lots of work to be done on that front but this is a step in the right direction. Credit where credit is due @ansv7779 was a major contributor to making the reviewer views work on the test servers.
ansv7779 merged commit 304d0431c1 into develop 2025-02-12 11:07:54 +01:00
ansv7779 deleted branch rough-draft-approval-deadline 2025-02-12 11:07:55 +01:00
ansv7779 added
po
approved
 and removed
po
needed
 labels 2025-02-12 11:08:07 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
ansv7779
Labels
Clear labels
bug
Something is not working
discussion
duplicate
This issue or pull request already exists
enhancement
New feature
frozen
The issue is not solved, but it will be investigated in the future it the issue arises again
help wanted
Need some help
invalid
Something is wrong
new
To be discussed at the next meeting
po
approved
po
changes
PO has requested changes
po
needed
question
More information is needed
size
1
size
2
size
3
wontfix
This won't be fixed
No Label
po
approved
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#106
No description provided.
Delete Branch "rough-draft-approval-deadline"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?