DMC/scipro
12
0
Fork 0
Code Issues 3 Pull Requests 3 Actions Wiki Activity

Allow longer final thesis titles #17

Merged
niat8586 merged 1 commits from longer-final-thesis-titles into develop 2024-11-11 11:17:15 +01:00
Conversation 0 Commits 1 Files Changed 1 +3
ansv7779 commented 2024-11-08 11:30:04 +01:00
Owner
Copy Link

The titles entered are most often the same as the project title. The project title however has no length limit. When such a project tries to upload their final thesis the system will crash because the accepted long project title is rejected as the final thesis title.

This change removes the length limit on final thesis titles to bring them to parity with the project title.

See OTRS ticket 202411011026

This change has already been done manually in the production system to resolve the above ticket.

How to test

Submit a final thesis using a title longer than 255 characters and see that is accepted.

The titles entered are most often the same as the project title. The project title however has no length limit. When such a project tries to upload their final thesis the system will crash because the accepted long project title is rejected as the final thesis title. This change removes the length limit on final thesis titles to bring them to parity with the project title. See OTRS ticket [202411011026](https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=389771#1413199) This change has already been done manually in the production system to resolve the above ticket. ## How to test Submit a final thesis using a title longer than 255 characters and see that is accepted.
ansv7779 added 1 commit 2024-11-08 11:30:05 +01:00
Allow longer final thesis titles
All checks were successful
Build and test / build-and-test (push) Successful in 6m36s
Details
897f5a8329 
The titles entered are most often the same as the project title. The project title however has no length limit. When such a project tries to upload their final thesis the system will crash because the accepted long project title is rejected as the final thesis title.

This change removes the length limit on final thesis titles to bring them to parity with the project title.

See OTRS ticket 202411011026
niat8586 approved these changes 2024-11-11 11:17:01 +01:00
niat8586 left a comment
Owner
Copy Link

👍
I'm guessing we will never have titles that exceed the default maximum packet size.
Depending on the version the defaults could be 4MB or 16MB (That would make for some really long titles)

👍 I'm guessing we will never have titles that exceed the default maximum packet size. Depending on the version the defaults could be 4MB or 16MB (That would make for some really long titles)
niat8586 merged commit 8e5c9f5687 into develop 2024-11-11 11:17:15 +01:00
niat8586 deleted branch longer-final-thesis-titles 2024-11-11 11:17:16 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
niat8586
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DMC/scipro#17
No description provided.
Delete Branch "longer-final-thesis-titles"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?