DMC/scipro
12
0
Fork 0
Code Issues 4 Pull Requests 4 Actions Wiki Activity

Fix intermittent sorting of criterion to actual order #18

Merged
tozh4728 merged 2 commits from 3495-grading-report-template-random-order into develop 2024-11-14 12:39:42 +01:00
Conversation 0 Commits 2 Files Changed 1 +3 -2
niat8586 commented 2024-11-13 12:03:44 +01:00
Owner
Copy Link

When you tried to edit a grading template in "Project management" -> "Grading Templates" the criterion could be shown in an order not reflecting the sortOrder of the criterion.
The reason was that we only got the arbitrary order depending on the insertion order in the database.

Changed the Collection to a List, it is now an ArrayList. Also added @OrderBy("sortOrder ASC") to actually sort by the order of the criterion thus ensuring visual order is intact.

When you tried to edit a grading template in "Project management" -> "Grading Templates" the criterion could be shown in an order not reflecting the sortOrder of the criterion. The reason was that we only got the arbitrary order depending on the insertion order in the database. Changed the Collection to a List, it is now an ArrayList. Also added @OrderBy("sortOrder ASC") to actually sort by the order of the criterion thus ensuring visual order is intact.
niat8586 added 1 commit 2024-11-13 12:03:45 +01:00
Fix intermittent sorting of criterion to actual order
All checks were successful
Build and test / build-and-test (push) Successful in 7m23s
Details
0af4e538a1 
When you tried to edit a grading template in  "Project management" -> "Grading Templates" the criterion could be shown in an order not reflecting the sortOrder of the criterion.
The reason was that we only got the arbitrary order depending on the insertion order in the database.

Changed the Collection to a List, it is now an ArrayList. Also added @OrderBy("sortOrder ASC") to actually sort by the order of the criterion thus ensuring visual order is intact.
tozh4728 requested review from tozh4728 2024-11-14 10:30:27 +01:00
tozh4728 approved these changes 2024-11-14 10:30:33 +01:00
Dismissed
tozh4728 added 1 commit 2024-11-14 12:39:27 +01:00
Merge branch 'develop' into 3495-grading-report-template-random-order
All checks were successful
Build and test / build-and-test (push) Successful in 12m50s
Details
9c185e46d8
tozh4728 approved these changes 2024-11-14 12:39:34 +01:00
tozh4728 merged commit d89417ceea into develop 2024-11-14 12:39:42 +01:00
tozh4728 deleted branch 3495-grading-report-template-random-order 2024-11-14 12:39:42 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tozh4728
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DMC/scipro#18
No description provided.
Delete Branch "3495-grading-report-template-random-order"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?