DMC/scipro
7
0
Fork 0
Code Issues 20 Pull Requests 1 Actions Projects 1 Wiki Activity

Fix grade calculator being serialized #59

Merged
niat8586 merged 1 commits from grade-calculator-serialization into develop 2024-12-16 11:24:34 +01:00
Conversation 1 Commits 1 Files Changed 4 +10 -20
ansv7779 commented 2024-12-10 12:29:32 +01:00
Owner
Copy Link

The new calculator that's based on templates has a reference to the @Entity for the template which should not be serialized.

Fixes #40

How to test/replicate

  1. Log in as a supervisor
  2. Open a project that's new enough to use a grading report template with grade limits
  3. Go to the "Finishing up" tab
  4. Go to the sub-tab for an individual author
The new calculator that's based on templates has a reference to the @Entity for the template which should not be serialized. Fixes #40 ## How to test/replicate 1. Log in as a supervisor 1. Open a project that's new enough to use a grading report template with grade limits 1. Go to the "Finishing up" tab 1. Go to the sub-tab for an individual author
ansv7779 added 1 commit 2024-12-10 12:29:33 +01:00
Fix grade calculator being serialized
All checks were successful
Build and test / build-and-test (push) Successful in 7m12s
Details
34c8684e55 
The new calculator that's based on templates has a reference to the @Entity for the template which should not be serialized.
niat8586 approved these changes 2024-12-16 11:24:26 +01:00
niat8586 left a comment
Owner
Copy Link

👍

👍
niat8586 merged commit c6bd17d9ad into develop 2024-12-16 11:24:34 +01:00
niat8586 deleted branch grade-calculator-serialization 2024-12-16 11:24:34 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
niat8586
Labels
Clear labels
bug
Something is not working
discussion
duplicate
This issue or pull request already exists
enhancement
New feature
frozen
The issue is not solved, but it will be investigated in the future it the issue arises again
help wanted
Need some help
invalid
Something is wrong
new
To be discussed at the next meeting
po
approved
po
needed
question
More information is needed
size
1
size
2
size
3
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#59
No description provided.
Delete Branch "grade-calculator-serialization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?