Require authors to fill in background, literature, problem, method, and interests when submitting ideas #72
niat8586
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "student-idea-form-required-fields"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Require authors to fill in background, literature, method, problem, and interests when submitting an idea.
Fixes #37
How to test
stig@example.comDeployed to https://scipro-student-idea-form-required-fields.branch.dsv.su.se
I started the PO review a little bit in advance, I hope that it is OK :)
If I omit one of the compulsory fields "background, literature, problem, method, language and interests", the error message works fine.
For example if the problem is missing, the following message appears (marked in red): "You need to fill in the 'Problem' field in the "Student idea form". And so on for the all the other fields.
However if I omit only the project type, then no feedback is presented. The page only slides to the top, showing the yellow marked message about "Students should primarily choose from ideas provided by supervisors. Do NOT create an idea unless you've read through etc...". Please see the attached screen shot.
Can we provide an error message similar to the above mentioned one?
BTW I could only choose one project type from the test case...
I have a suggestion, although it is not part of the commit.
In the ProjectIdeaSubmissionPanel.properties file the message
submissionFailed is: 'Idea could not be submitted. '
We could expand that message to 'Idea could not be submitted, correct the highlighted fields and try again'
What do you think ?
There is feedback presented, it is a "balloon tool-tip" that says "Please select one of these options" unfortunately it disappears as soon as you click or do something on the page. It would be better if it would follow the same handling as the other fields in example languages. See the provided screenshot.
In short I agree that the error message for the type should follow same look and feel as the other fields in the form.
The application period is only for bachelor ideas which is why there is only one choice.
The type selection has been changed to be validated in the same way as the other fields and the topmost error message has been improved so they are instructed to scan the form for more detailed error messages.
👍
I cannot edit/remove the idea here anymore, probably because the application period is over?
https://scipro-student-idea-form-required-fields.branch.dsv.su.se/
The application period should be open now.
Now I don't receive any error message, no matter what I omit. The page just slides to the top (to the title field). Please see attached screen shot
There was still some client-side validation left for the length of the title field (as well as very high max for the background, literature, et. al. fields) that was blocking the submission. You tried with just four characters in the title which the browser would block since it has a minimum of five.
Now all client-side validation should be gone and you'll get an error message saying the title is too short instead.
348afe1723to164271a6e5I don't know if you changed something from my last check, but now it works fine
It provides general feedback on top of the page and then correctly highlights the fields that have been omitted! 👍
I attach a new screenshot.
I really liked this, and agree like you demonstrated at yesterdays (2025-01-16) meeting we should have server side validation and use turn off the client side validation. And we should look into making it so on the other forms we have.