Multiple thesis rejection notifications #75

New Issue

ansv7779 · 2025-01-09T16:06:00+01:00

ansv7779 commented

2025-01-09 16:06:00 +01:00

SciPro seems to have gotten stuck and kept sending notifications about the same rejected thesis over and over again.

See https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=395044

The job stopped recording when it was last run at 2024-12-23 05:20:52 but all other jobs seems to have had their timestamp updated.

There's an exception in the log at 2024-12-23 05:26:02 that seems to have put it in this perpetual state of being unable to update its timestamp of when it successful ran.

SciPro seems to have gotten stuck and kept sending notifications about the same rejected thesis over and over again. See https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=395044 The job stopped recording when it was last run at `2024-12-23 05:20:52` but all other jobs seems to have had their timestamp updated. There's an exception in the log at `2024-12-23 05:26:02` that seems to have put it in this perpetual state of being unable to update its timestamp of when it successful ran.

ansv7779 added the

bug

new

labels 2025-01-09 16:06:00 +01:00

ansv7779 commented

2025-01-09 16:13:03 +01:00

Probable cause is when we switched from Guice to Spring all the worker objects went from prototype (new instance created on every job execution) to singletone (same instance for every execution) which means the default value for the field successfulWorker in AbstractWorker never gets reset between executions.

This means a single failure will set the flag to false and it will stay that way forever.

Probable cause is when we switched from Guice to Spring all the worker objects went from prototype (new instance created on every job execution) to singletone (same instance for every execution) which means the default value for the field [`successfulWorker`](https://gitea.dsv.su.se/DMC/scipro/src/commit/6bdd5c63ea0818122889d74841d8299a30fd4b40/core/src/main/java/se/su/dsv/scipro/workerthreads/AbstractWorker.java#L23) in [`AbstractWorker`](https://gitea.dsv.su.se/DMC/scipro/src/commit/6bdd5c63ea0818122889d74841d8299a30fd4b40/core/src/main/java/se/su/dsv/scipro/workerthreads/AbstractWorker.java) never gets reset between executions. This means a single failure will set the flag to `false` and it will stay that way forever.

ansv7779 referenced a pull request that will close this issue

2025-01-10 13:14:34 +01:00

Reset the failure flag in workers on successful runs. #76

ansv7779 added this to the SciPro project 2025-01-10 13:15:14 +01:00

ansv7779 self-assigned this 2025-01-10 13:15:16 +01:00

ansv7779 moved this to Review in SciPro on 2025-01-10 13:15:22 +01:00

tozh4728 moved this to Review In Progress in SciPro on 2025-01-13 11:00:15 +01:00

tozh4728 self-assigned this 2025-01-13 11:02:35 +01:00

tozh4728 closed this issue

2025-01-14 14:50:33 +01:00

tozh4728 moved this to PO Review in SciPro on 2025-01-14 14:51:07 +01:00

tozh4728 moved this to Ready for production in SciPro on 2025-01-14 14:51:15 +01:00