DMC/scipro
7
0
Fork 0
Code Issues41 Pull Requests6 Actions Projects1 Releases Wiki Activity

Assign supervisor to student ideas no matter if target (goal) is reached #96

Merged
ansv7779 merged 12 commits from 67-supervisor-target-non-blocking into develop 2025-02-18 09:59:24 +01:00
Conversation 5 Commits 12 Files Changed 4 +92 -18
tozh4728 commented 2025-01-27 14:55:51 +01:00
Owner

Fixes

How to test

  1. log in with principal 'dev@localhost' (default)
  2. Click "Match", there is one student idea available: 'Fundamental Math Concepts of AI', which is unmatched.
  3. Click "Application periods", and then "Edit targets", Supervisor "Eric Employee" has target set to 10, and "Eve Employee", has targets set to 0.
  4. Click "Ideas" again, select supervisor "Eve Employee", this assignment will go through, but feedback text will be shown as warning, since there is not target assigned to "Eve Employee".
  5. Change supervisor "Eric Employee", the assignment will go through, and the feedback text will be shown as green. "Eric Employee" has target set to 10.
Fixes #67 ## How to test 1. log in with principal 'dev@localhost' (default) 2. Click "Match", there is one student idea available: 'Fundamental Math Concepts of AI', which is unmatched. 3. Click "Application periods", and then "Edit targets", Supervisor "Eric Employee" has target set to 10, and "Eve Employee", has targets set to 0. 4. Click "Ideas" again, select supervisor "Eve Employee", this assignment will go through, but feedback text will be shown as warning, since there is not target assigned to "Eve Employee". 5. Change supervisor "Eric Employee", the assignment will go through, and the feedback text will be shown as green. "Eric Employee" has target set to 10.
tozh4728 added 1 commit 2025-01-27 14:55:52 +01:00
gitea-actions commented 2025-01-27 14:58:00 +01:00
First-time contributor

Deployed to https://scipro-67-supervisor-target-non-blocking.branch.dsv.su.se

Deployed to https://scipro-67-supervisor-target-non-blocking.branch.dsv.su.se
tozh4728 added 1 commit 2025-01-27 15:06:33 +01:00
tozh4728 added 1 commit 2025-01-27 15:22:47 +01:00
tozh4728 added 1 commit 2025-01-30 09:21:28 +01:00
tozh4728 added 1 commit 2025-01-30 15:19:27 +01:00
tozh4728 added 1 commit 2025-02-10 12:30:13 +01:00
tozh4728 added 1 commit 2025-02-10 13:34:51 +01:00
tozh4728 added 1 commit 2025-02-10 14:50:44 +01:00
tozh4728 added 1 commit 2025-02-12 10:06:53 +01:00
tozh4728 added 1 commit 2025-02-12 13:35:29 +01:00
tozh4728 changed title from WIP: Assign supervisor to student ideas no matter if target (goal) is reached to Assign supervisor to student ideas no matter if target (goal) is reached 2025-02-12 14:05:58 +01:00
tozh4728 added the
po
needed
 label 2025-02-12 14:08:44 +01:00
ansv7779 requested changes 2025-02-12 15:22:50 +01:00
Dismissed
ansv7779 left a comment
Owner

Code looks good to me. Minor nitpick on the null check on the return value from a count method.

Code looks good to me. Minor nitpick on the null check on the return value from a count method.
view/src/main/java/se/su/dsv/scipro/match/AbstractAdminIdeaPanel.java
@ -217,0 +219,4 @@
);
int targetCounter = (currentTarget == null) ? 0 : currentTarget.getTarget();
long matchedCounter = (countMatched == null) ? 0L : countMatched;
ansv7779 commented 2025-02-12 15:20:37 +01:00
Owner

This seems weird, a count method should return 0 not null.

This seems weird, a count method should return 0 not `null`.
tozh4728 commented 2025-02-13 09:30:58 +01:00
Author
Owner

Fine point, the unnecessary null check has been removed.

The rationale for null check is that ideaService.countMatched returning Long. It would be better that a @NotNull annotation is applied to such method which is guaranteed to return non null object.

Fine point, the unnecessary null check has been removed. The rationale for null check is that ideaService.countMatched returning Long. It would be better that a @NotNull annotation is applied to such method which is guaranteed to return non null object.
ansv7779 marked this conversation as resolved
tozh4728 added 1 commit 2025-02-13 09:26:26 +01:00
ansv7779 approved these changes 2025-02-13 10:01:07 +01:00
ansv7779 left a comment
Owner

Looks good

Looks good
tozh4728 added 1 commit 2025-02-13 15:28:21 +01:00
andan commented 2025-02-14 08:39:23 +01:00
Owner

Jag tycker att det ser bra ut. Jag har skickat länken till Gruorna för test, så vi avvaktar deras feedback.
Avvaktar deras feedback innan vi ändrar status från "PO needed".

Jag tycker att det ser bra ut. Jag har skickat länken till Gruorna för test, så vi avvaktar deras feedback. Avvaktar deras feedback innan vi ändrar status från "PO needed".
andan added
po
approved
 and removed
po
needed
 labels 2025-02-18 08:54:31 +01:00
andan commented 2025-02-18 08:54:58 +01:00
Owner

Ok för Gruorna att sätta denna feature i drift redan den här veckan

Ok för Gruorna att sätta denna feature i drift redan den här veckan
ansv7779 merged commit 399d8f5275 into develop 2025-02-18 09:59:24 +01:00
ansv7779 deleted branch 67-supervisor-target-non-blocking 2025-02-18 09:59:24 +01:00
Sign in to join this conversation.
No Reviewers
ansv7779
No Label
po
approved
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#96
No description provided.
Delete Branch "67-supervisor-target-non-blocking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?