DMC/scipro
7
0
Fork 0
Code Issues 27 Pull Requests 4 Actions Projects 1 Wiki Activity

Grading Boundaries Wrong in Supervisor View #98

Merged
ansv7779 merged 23 commits from 97-grading-boundaries-wrong-in-suervisor-view into develop 2025-02-21 14:06:29 +01:00
Conversation 5 Commits 23 Files Changed 8 +408 -201
tozh4728 commented 2025-01-30 09:27:55 +01:00
Owner
Copy Link

Fixes #97

  1. Log in as 'eric@example.com'
  2. Pick up the project 'Putting the it in supervising (Bachelor)
  3. Click on tab 'Finishing up'.
  4. Log in again as 'eric@example.com'
  5. Click tab 'Sture Student'
  6. Move down to section 'Conversion from points to grades is done according to the following schema:'

The conversion table is consistent with 'Thesis Instructions'.

(Does not work on test servers due to issue with service.grading.url. :-( )

Fixes #97 1. Log in as 'eric@example.com' 2. Pick up the project 'Putting the it in supervising (Bachelor) 3. Click on tab 'Finishing up'. 4. Log in again as 'eric@example.com' 5. Click tab 'Sture Student' 6. Move down to section 'Conversion from points to grades is done according to the following schema:' The conversion table is consistent with 'Thesis Instructions'. (Does not work on test servers due to issue with service.grading.url. :-( )
tozh4728 added 1 commit 2025-01-30 09:27:56 +01:00
97: Short circuit authorization check so far to test
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m5s
Details
Build and test / build-and-test (push) Successful in 19m26s
Details
3346862694
tozh4728 changed title from 97: Grading Boundaries Wrong in Supervisor View to WIP: 97: Grading Boundaries Wrong in Supervisor View 2025-01-30 09:28:02 +01:00
gitea-actions commented 2025-01-30 09:44:07 +01:00
First-time contributor
Copy Link

Deployed to https://scipro-97-grading-boundaries-wrong-in-suervisor-view.branch.dsv.su.se

Deployed to https://scipro-97-grading-boundaries-wrong-in-suervisor-view.branch.dsv.su.se
tozh4728 added 3 commits 2025-01-30 10:26:29 +01:00
97: Update test code for TempaltePanel
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 2m7s
Details
Build and test / build-and-test (push) Successful in 16m6s
Details
b990b65b20
tozh4728 added 1 commit 2025-01-30 14:27:34 +01:00
97: Remove old info from previous grading creterion
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 2m5s
Details
Build and test / build-and-test (push) Has been cancelled
Details
0355c829a1
tozh4728 added 1 commit 2025-01-30 14:38:53 +01:00
97: Reactivate authorization
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 2m9s
Details
Build and test / build-and-test (push) Successful in 16m11s
Details
1b6fd8a17b
tozh4728 changed title from WIP: 97: Grading Boundaries Wrong in Supervisor View to Grading Boundaries Wrong in Supervisor View 2025-01-30 14:39:22 +01:00
ansv7779 requested changes 2025-02-04 10:32:38 +01:00
ansv7779 left a comment
Owner
Copy Link

Now that we have the grade limits in the database connected to the template (#14) the "from november 2024" panel should display its information based on that data rather than a hardcoded copy so that it keeps working in the future as the template changes.

GradingReportService has a method to fetch the template based on the project that can be used to display the dynamic data.

Now that we have the grade limits in the database connected to the template (#14) the "from november 2024" panel should display its information based on that data rather than a hardcoded copy so that it keeps working in the future as the template changes. `GradingReportService` has a method to fetch the template based on the project that can be used to display the dynamic data.
tozh4728 commented 2025-02-13 09:49:24 +01:00
Author
Owner
Copy Link

GradingReportService.getTemplate returns GradingReortTemplate, which contains a Collection of GradeLimit. However, the current data model of GradeLimit has no upper limit of a grade. makes it harder to get grade A's upper limit.

`GradingReportService.getTemplate` returns `GradingReortTemplate`, which contains a Collection of `GradeLimit`. However, the current data model of `GradeLimit` has no upper limit of a grade. makes it harder to get grade A's upper limit.
ansv7779 commented 2025-02-13 10:05:36 +01:00
Owner
Copy Link

GradingReportService.getTemplate returns GradingReortTemplate, which contains a Collection of GradeLimit. However, the current data model of GradeLimit has no upper limit of a grade. makes it harder to get grade A's upper limit.

The GradingReportTemplate also contain a collection of GradingCriterionTemplate each of which has a getMaximumPoints. Summing all those together gives you the upper point limit of the entire report.

> `GradingReportService.getTemplate` returns `GradingReortTemplate`, which contains a Collection of `GradeLimit`. However, the current data model of `GradeLimit` has no upper limit of a grade. makes it harder to get grade A's upper limit. The `GradingReportTemplate` also contain a collection of `GradingCriterionTemplate` each of which has a `getMaximumPoints`. Summing all those together gives you the upper point limit of the entire report.
tozh4728 changed title from Grading Boundaries Wrong in Supervisor View to WIP: Grading Boundaries Wrong in Supervisor View 2025-02-17 10:03:57 +01:00
tozh4728 added 1 commit 2025-02-17 10:04:24 +01:00
Merge branch 'develop' into 97-grading-boundaries-wrong-in-suervisor-view
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m39s
Details
Build and test / build-and-test (push) Successful in 16m19s
Details
a6de7a9ab0
tozh4728 added 2 commits 2025-02-19 12:26:30 +01:00
Merge branch '97-grading-boundaries-wrong-in-suervisor-view' of gitea.dsv.su.se:DMC/scipro into 97-grading-boundaries-wrong-in-suervisor-view
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 2m43s
Details
Build and test / build-and-test (push) Failing after 15m38s
Details
3b201f6de2
tozh4728 added 1 commit 2025-02-19 13:38:17 +01:00
97: Fix UI-test
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m16s
Details
Build and test / build-and-test (push) Successful in 15m54s
Details
b1d8ad7a2e
tozh4728 added 1 commit 2025-02-19 14:08:31 +01:00
Merge branch 'develop' into 97-grading-boundaries-wrong-in-suervisor-view
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m11s
Details
Build and test / build-and-test (push) Successful in 16m1s
Details
411908fb72
ansv7779 added 2 commits 2025-02-20 10:50:14 +01:00
Use detachable IModels to prevent stale data
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m48s
Details
Build and test / build-and-test (push) Successful in 16m10s
Details
cee39cbf78
tozh4728 added 6 commits 2025-02-20 16:05:55 +01:00
97: Add test data to test points-to-grade conversion panel
Some checks failed
Build and test / build-and-test (push) Has been cancelled
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m29s
Details
989a3d9bdc
tozh4728 changed title from WIP: Grading Boundaries Wrong in Supervisor View to Grading Boundaries Wrong in Supervisor View 2025-02-20 16:06:56 +01:00
tozh4728 added 1 commit 2025-02-20 16:14:25 +01:00
97: Replace with single import
Some checks failed
Build and test / build-and-test (push) Failing after 53s
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 4m21s
Details
2d5ae2129b
tozh4728 added 1 commit 2025-02-20 16:22:04 +01:00
97: reformat code
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 4m9s
Details
Build and test / build-and-test (push) Successful in 15m56s
Details
a1c3895767
ansv7779 added 1 commit 2025-02-21 11:42:12 +01:00
The item itself is added by the ListView
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m28s
Details
Build and test / build-and-test (push) Successful in 18m2s
Details
eb567401c6
ansv7779 approved these changes 2025-02-21 11:51:34 +01:00
ansv7779 left a comment
Owner
Copy Link

There could have been a little better automated tests for checking the upper and lower limit based on a small GradingReportTemplate rather than passing in an empty one.

There could have been a little better automated tests for checking the upper and lower limit based on a small `GradingReportTemplate` rather than passing in an empty one.
core/src/main/java/se/su/dsv/scipro/DataInitializer.java
@ -363,0 +385,4 @@
gradeLimit = new GradeLimit();
gradeLimit.setGrade("C");
gradeLimit.setLowerLimit(22);
gradeLimits.add(gradeLimit);
ansv7779 commented 2025-02-21 11:48:18 +01:00
Owner
Copy Link

Extracting a method creating the GradeLimit here may have been justified.

Extracting a method creating the `GradeLimit` here may have been justified.
ansv7779 added 1 commit 2025-02-21 13:39:08 +01:00
Merge branch 'develop' into 97-grading-boundaries-wrong-in-suervisor-view
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m26s
Details
Build and test / build-and-test (push) Successful in 18m1s
Details
Remove branch deployment from branch.dsv.su.se / cleanup (pull_request) Successful in 5s
Details
fabcbe0aa4
ansv7779 merged commit e71aa8120c into develop 2025-02-21 14:06:29 +01:00
ansv7779 deleted branch 97-grading-boundaries-wrong-in-suervisor-view 2025-02-21 14:06:30 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
ansv7779
Labels
Clear labels
bug
Something is not working
discussion
duplicate
This issue or pull request already exists
enhancement
New feature
frozen
The issue is not solved, but it will be investigated in the future it the issue arises again
help wanted
Need some help
invalid
Something is wrong
new
To be discussed at the next meeting
po
approved
po
changes
PO has requested changes
po
needed
question
More information is needed
size
1
size
2
size
3
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#98
No description provided.
Delete Branch "97-grading-boundaries-wrong-in-suervisor-view"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?