DMC/scipro
7
0
Fork 0
Code Issues41 Pull Requests6 Actions Projects1 Releases Wiki Activity

Grading Boundaries Wrong in Supervisor View #98

Merged
ansv7779 merged 23 commits from 97-grading-boundaries-wrong-in-suervisor-view into develop 2025-02-21 14:06:29 +01:00
Conversation 5 Commits 23 Files Changed 8 +408 -201
tozh4728 commented 2025-01-30 09:27:55 +01:00
Owner

Fixes

  1. Log in as 'eric@example.com'
  2. Pick up the project 'Putting the it in supervising (Bachelor)
  3. Click on tab 'Finishing up'.
  4. Log in again as 'eric@example.com'
  5. Click tab 'Sture Student'
  6. Move down to section 'Conversion from points to grades is done according to the following schema:'

The conversion table is consistent with 'Thesis Instructions'.

(Does not work on test servers due to issue with service.grading.url. :-( )

Fixes #97 1. Log in as 'eric@example.com' 2. Pick up the project 'Putting the it in supervising (Bachelor) 3. Click on tab 'Finishing up'. 4. Log in again as 'eric@example.com' 5. Click tab 'Sture Student' 6. Move down to section 'Conversion from points to grades is done according to the following schema:' The conversion table is consistent with 'Thesis Instructions'. (Does not work on test servers due to issue with service.grading.url. :-( )
tozh4728 added 1 commit 2025-01-30 09:27:56 +01:00
tozh4728 changed title from 97: Grading Boundaries Wrong in Supervisor View to WIP: 97: Grading Boundaries Wrong in Supervisor View 2025-01-30 09:28:02 +01:00
gitea-actions commented 2025-01-30 09:44:07 +01:00
First-time contributor

Deployed to https://scipro-97-grading-boundaries-wrong-in-suervisor-view.branch.dsv.su.se

Deployed to https://scipro-97-grading-boundaries-wrong-in-suervisor-view.branch.dsv.su.se
tozh4728 added 3 commits 2025-01-30 10:26:29 +01:00
tozh4728 added 1 commit 2025-01-30 14:27:34 +01:00
tozh4728 added 1 commit 2025-01-30 14:38:53 +01:00
tozh4728 changed title from WIP: 97: Grading Boundaries Wrong in Supervisor View to Grading Boundaries Wrong in Supervisor View 2025-01-30 14:39:22 +01:00
ansv7779 requested changes 2025-02-04 10:32:38 +01:00
ansv7779 left a comment
Owner

Now that we have the grade limits in the database connected to the template () the "from november 2024" panel should display its information based on that data rather than a hardcoded copy so that it keeps working in the future as the template changes.

GradingReportService has a method to fetch the template based on the project that can be used to display the dynamic data.

Now that we have the grade limits in the database connected to the template (#14) the "from november 2024" panel should display its information based on that data rather than a hardcoded copy so that it keeps working in the future as the template changes. `GradingReportService` has a method to fetch the template based on the project that can be used to display the dynamic data.
tozh4728 commented 2025-02-13 09:49:24 +01:00
Author
Owner

GradingReportService.getTemplate returns GradingReortTemplate, which contains a Collection of GradeLimit. However, the current data model of GradeLimit has no upper limit of a grade. makes it harder to get grade A's upper limit.

`GradingReportService.getTemplate` returns `GradingReortTemplate`, which contains a Collection of `GradeLimit`. However, the current data model of `GradeLimit` has no upper limit of a grade. makes it harder to get grade A's upper limit.
ansv7779 commented 2025-02-13 10:05:36 +01:00
Owner

GradingReportService.getTemplate returns GradingReortTemplate, which contains a Collection of GradeLimit. However, the current data model of GradeLimit has no upper limit of a grade. makes it harder to get grade A's upper limit.

The GradingReportTemplate also contain a collection of GradingCriterionTemplate each of which has a getMaximumPoints. Summing all those together gives you the upper point limit of the entire report.

> `GradingReportService.getTemplate` returns `GradingReortTemplate`, which contains a Collection of `GradeLimit`. However, the current data model of `GradeLimit` has no upper limit of a grade. makes it harder to get grade A's upper limit. The `GradingReportTemplate` also contain a collection of `GradingCriterionTemplate` each of which has a `getMaximumPoints`. Summing all those together gives you the upper point limit of the entire report.
tozh4728 changed title from Grading Boundaries Wrong in Supervisor View to WIP: Grading Boundaries Wrong in Supervisor View 2025-02-17 10:03:57 +01:00
tozh4728 added 1 commit 2025-02-17 10:04:24 +01:00
tozh4728 added 2 commits 2025-02-19 12:26:30 +01:00
tozh4728 added 1 commit 2025-02-19 13:38:17 +01:00
tozh4728 added 1 commit 2025-02-19 14:08:31 +01:00
ansv7779 added 2 commits 2025-02-20 10:50:14 +01:00
tozh4728 added 6 commits 2025-02-20 16:05:55 +01:00
tozh4728 changed title from WIP: Grading Boundaries Wrong in Supervisor View to Grading Boundaries Wrong in Supervisor View 2025-02-20 16:06:56 +01:00
tozh4728 added 1 commit 2025-02-20 16:14:25 +01:00
tozh4728 added 1 commit 2025-02-20 16:22:04 +01:00
ansv7779 added 1 commit 2025-02-21 11:42:12 +01:00
ansv7779 approved these changes 2025-02-21 11:51:34 +01:00
ansv7779 left a comment
Owner

There could have been a little better automated tests for checking the upper and lower limit based on a small GradingReportTemplate rather than passing in an empty one.

There could have been a little better automated tests for checking the upper and lower limit based on a small `GradingReportTemplate` rather than passing in an empty one.
core/src/main/java/se/su/dsv/scipro/DataInitializer.java
@ -363,0 +385,4 @@
gradeLimit = new GradeLimit();
gradeLimit.setGrade("C");
gradeLimit.setLowerLimit(22);
gradeLimits.add(gradeLimit);
ansv7779 commented 2025-02-21 11:48:18 +01:00
Owner

Extracting a method creating the GradeLimit here may have been justified.

Extracting a method creating the `GradeLimit` here may have been justified.
ansv7779 added 1 commit 2025-02-21 13:39:08 +01:00
ansv7779 merged commit e71aa8120c into develop 2025-02-21 14:06:29 +01:00
ansv7779 deleted branch 97-grading-boundaries-wrong-in-suervisor-view 2025-02-21 14:06:30 +01:00
Sign in to join this conversation.
No Reviewers
ansv7779
No Label
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#98
No description provided.
Delete Branch "97-grading-boundaries-wrong-in-suervisor-view"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?