DMC/scipro
7
0
Fork 0
Code Issues 27 Pull Requests 4 Actions Projects 1 Wiki Activity

Update supervisor's idea table immediately upon scheduling a first meeting #105

Merged
ansv7779 merged 4 commits from first-meeting-feedback into develop 2025-02-13 09:59:34 +01:00
Conversation 4 Commits 4 Files Changed 3 +5 -1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 12badef08b - Show all commits

6
view/src/main/java/se/su/dsv/scipro/firstmeeting/FirstMeetingPanel.java
View File

@ -169,7 +169,11 @@ public class FirstMeetingPanel extends GenericPanel<Idea> {
}
private void saveAndNotify() {
firstMeetingRepository.save(getModelObject());
FirstMeeting saved = firstMeetingRepository.save(getModelObject());
// After saving the first meeting we have to populate it on the already loaded idea to
// make sure that other places that want to render the first meeting get the correct data.
// An alternative would be to detach the idea model to force a database refresh.
niat8586 marked this conversation as resolved
niat8586 commented 2025-02-11 08:45:57 +01:00
Review
Copy Link

Can the first meeting be edited from other users or from other places?

If it can maybe we should enforce a database refresh as per your comment of an alternative method.

If not then this is good in that we don't need to do a database refresh on the view we are in.

Can the first meeting be edited from other users or from other places? If it can maybe we should enforce a database refresh as per your comment of an alternative method. If not then this is good in that we don't need to do a database refresh on the view we are in.
ansv7779 commented 2025-02-11 08:57:40 +01:00
Review
Copy Link

Yes it can be edited from other places (but always by the supervisor). However, I do not see how that is relevant? The issue is the table not updating when using the modal dialog to schedule a meeting.

Do you want the page with the table to update itself based on what happens on a different page if it happened to be open simultaneously?

Yes it can be edited from other places (but always by the supervisor). However, I do not see how that is relevant? The issue is the table not updating when using the modal dialog to schedule a meeting. Do you want the page with the table to update itself based on what happens on a different page if it happened to be open simultaneously?
niat8586 commented 2025-02-12 15:17:25 +01:00
Review
Copy Link

We discussed yesterday (2025-02-11) in person, and I am happy with the resolution we got to. So we keep it as is.

We discussed yesterday (2025-02-11) in person, and I am happy with the resolution we got to. So we keep it as is.
FirstMeetingPanel.this.getModelObject().setFirstMeeting(saved);
NotificationSource source = new NotificationSource();
String date = dateService.format(getModelObject().getFirstMeetingDate(), DateStyle.DATETIME);
String room = getModelObject().getRoom();