DMC/scipro
7
0
Fork 0
Code Issues 32 Pull Requests 3 Actions Projects 1 Wiki Activity

task/3382: Harmonisera tabellnamn #6

Merged
ansv7779 merged 104 commits from task/3382 into develop 2024-11-12 13:33:44 +01:00
Conversation 6 Commits 104 Files Changed 129 +6 -6
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9a8604d76a - Show all commits

6
core/src/main/java/se/su/dsv/scipro/activityplan/ActivityPlanTemplate.java
View File

@ -39,7 +39,7 @@ public class ActivityPlanTemplate extends DomainObject {
private boolean isSysAdminTemplate = false; private boolean isSysAdminTemplate = false;
@Basic @Basic
@Column(nullable=false) @Column(name = "title", nullable = false)
private String title; private String title;
@Basic @Basic
@ -49,8 +49,8 @@ public class ActivityPlanTemplate extends DomainObject {
//</editor-fold> //</editor-fold>
//<editor-fold desc="JPA-mappings of foreign keys in this table (activity_plan_template) referencing other tables."> //<editor-fold desc="JPA-mappings of foreign keys in this table (activity_plan_template) referencing other tables.">
@ManyToOne(optional=false) @ManyToOne(optional = false)
@JoinColumn(name = "user_id") @JoinColumn(name = "creator_user_id", referencedColumnName = "id")
tozh4728 marked this conversation as resolved Outdated
ansv7779 commented 2024-11-11 14:12:21 +01:00
Outdated
Review
Copy Link

Again less self describing column name. creator_id tells you it is the user who created the template rather than just a generic user_id. The referenced table/type is visible from the foreign key/class.

Again less self describing column name. `creator_id` tells you it is the user who created the template rather than just a generic `user_id`. The referenced table/type is visible from the foreign key/class.
private User creator; private User creator;
//</editor-fold> //</editor-fold>

6
core/src/main/resources/db/migration/V390__harmonize_table_attribute_name.sql
View File

@ -1043,11 +1043,11 @@ alter table `ActivityPlanTemplate` drop key `FKACCF6522E44F4DBE`;
rename table `ActivityPlanTemplate` to `activity_plan_template`; rename table `ActivityPlanTemplate` to `activity_plan_template`;
alter table `activity_plan_template` rename column `isSysAdminTemplate` to `is_sys_admin_template`; alter table `activity_plan_template` rename column `isSysAdminTemplate` to `is_sys_admin_template`;
alter table `activity_plan_template` rename column `creator_id` to `user_id`; alter table `activity_plan_template` rename column `creator_id` to `creator_user_id`;
alter table `activity_plan_template` alter table `activity_plan_template`
add constraint fk_activity_plan_template_user_id add constraint fk_activity_plan_template_creator_user_id
foreign key (user_id) references user (id) foreign key (creator_user_id) references user (id)
on delete cascade on update cascade; on delete cascade on update cascade;
-- Add back all foreign key references to activity_plan_template -- Add back all foreign key references to activity_plan_template