DMC/scipro
7
0
Fork 0
Code Issues 31 Pull Requests 3 Actions Projects 1 Wiki Activity

task/3382: Harmonisera tabellnamn #6

Merged
ansv7779 merged 104 commits from task/3382 into develop 2024-11-12 13:33:44 +01:00
Conversation 6 Commits 104 Files Changed 129 +15 -10
2 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit df29afdacc - Show all commits

15
core/src/main/java/se/su/dsv/scipro/system/Username.java
View File

@ -1,17 +1,26 @@
package se.su.dsv.scipro.system; package se.su.dsv.scipro.system;
import jakarta.persistence.*; import jakarta.persistence.Cacheable;
import jakarta.persistence.Column;
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.GenerationType;
import jakarta.persistence.Id;
tozh4728 marked this conversation as resolved Outdated
ansv7779 commented 2024-11-11 14:56:10 +01:00
Outdated
Review
Copy Link

Username is one word, not two. User name is a user's name (John Doe) while username is their unique identifier john@doe.example.

Username is one word, not two. User name is a user's name (John Doe) while username is their unique identifier `john@doe.example`.
import jakarta.persistence.ManyToOne;
import jakarta.persistence.Table;
import jakarta.persistence.UniqueConstraint;
import java.util.Objects; import java.util.Objects;
tozh4728 marked this conversation as resolved Outdated
ansv7779 commented 2024-11-11 14:56:15 +01:00
Outdated
Review
Copy Link

Username is one word, not two. User name is a user's name (John Doe) while username is their unique identifier john@doe.example.

Username is one word, not two. User name is a user's name (John Doe) while username is their unique identifier `john@doe.example`.
@Entity @Entity
@Table(name="username", uniqueConstraints={@UniqueConstraint(name = "uk_username", columnNames={"username"})})
@Cacheable(true) @Cacheable(true)
@Table(name="user_name", uniqueConstraints={@UniqueConstraint(name = "uk_user_name", columnNames={"user_name"})})
public class Username extends DomainObject { public class Username extends DomainObject {
@Id @Id
@GeneratedValue(strategy = GenerationType.IDENTITY) @GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id; private Long id;
@Column(name = "user_name", nullable = false) @Column(name = "username", nullable = false)
private String username; private String username;
@ManyToOne(optional=false) @ManyToOne(optional=false)

10
core/src/main/resources/db/migration/V390__harmonize_table_attribute_name.sql
View File

@ -587,14 +587,10 @@ alter table `username` drop foreign key `FK_17moq4bksxe30ihucce3jovdc`;
alter table `username` drop key `FK_17moq4bksxe30ihucce3jovdc`; alter table `username` drop key `FK_17moq4bksxe30ihucce3jovdc`;
alter table `username` drop key `username_must_be_unique`; alter table `username` drop key `username_must_be_unique`;
rename table `username` to `user_name`; alter table `username` add constraint uk_username unique(username);
alter table `user_name` rename column `username` to `user_name`; alter table `username`
add constraint fk_username_user_id
alter table `user_name` add constraint uk_user_name unique(user_name);
alter table `user_name`
add constraint fk_user_name_user_id
foreign key (user_id) references user (id) foreign key (user_id) references user (id)
on delete cascade on update cascade; on delete cascade on update cascade;