DMC/scipro
7
0
Fork 0
Code Issues 32 Pull Requests 3 Actions Projects 1 Wiki Activity

Require authors to fill in background, literature, problem, method, and interests when submitting ideas #72

Merged
niat8586 merged 7 commits from student-idea-form-required-fields into develop 2025-01-17 09:45:28 +01:00
Conversation 14 Commits 7 Files Changed 5 +1 -12
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2bf6abb720 - Show all commits

13
view/src/main/java/se/su/dsv/scipro/match/ProjectIdeaSubmissionPanel.java
View File

@ -18,7 +18,6 @@ import org.apache.wicket.model.*;
import org.apache.wicket.model.util.ListModel; import org.apache.wicket.model.util.ListModel;
import org.apache.wicket.model.util.SetModel; import org.apache.wicket.model.util.SetModel;
import org.apache.wicket.request.mapper.parameter.PageParameters; import org.apache.wicket.request.mapper.parameter.PageParameters;
import org.apache.wicket.util.value.IValueMap;
import org.apache.wicket.validation.validator.StringValidator; import org.apache.wicket.validation.validator.StringValidator;
import se.su.dsv.scipro.components.*; import se.su.dsv.scipro.components.*;
import se.su.dsv.scipro.generalsystemsettings.GeneralSystemSettings; import se.su.dsv.scipro.generalsystemsettings.GeneralSystemSettings;
@ -188,17 +187,7 @@ public class ProjectIdeaSubmissionPanel extends GenericPanel<Idea> {
LambdaModel.of(getModel(), Idea::getProjectType, Idea::setProjectType), LambdaModel.of(getModel(), Idea::getProjectType, Idea::setProjectType),
projectTypes, projectTypes,
new LambdaChoiceRenderer<>(ProjectType::getName, ProjectType::getId) new LambdaChoiceRenderer<>(ProjectType::getName, ProjectType::getId)
) { );
@Override
protected IValueMap getAdditionalAttributes(int index, ProjectType choice) {
IValueMap valueMap = super.getAdditionalAttributes(index, choice);
// Have to remove the client side validation for required
// to have this field behave like all the others on the form.
// Can't remove the call to #setRequired(true) as it is needed for server side validation.
valueMap.remove("required");
return valueMap;
}
};
projectTypeChoice.add( projectTypeChoice.add(
new AjaxFormChoiceComponentUpdatingBehavior() { new AjaxFormChoiceComponentUpdatingBehavior() {
@Override @Override