From 1853ecfcc31f77e1451cad66ad664a05d9c5d2aa Mon Sep 17 00:00:00 2001
From: Nico Athanassiadis <nico@dsv.su.se>
Date: Mon, 31 Mar 2025 12:31:04 +0200
Subject: [PATCH 1/2] Remove email constratint
eamil field had a unique constraint on it which had side effects.
---
src/main/java/se/su/dsv/seshat/entities/AppUser.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/se/su/dsv/seshat/entities/AppUser.java b/src/main/java/se/su/dsv/seshat/entities/AppUser.java
index 4b02f6b..74bc593 100644
--- a/src/main/java/se/su/dsv/seshat/entities/AppUser.java
+++ b/src/main/java/se/su/dsv/seshat/entities/AppUser.java
@@ -25,7 +25,7 @@ public class AppUser {
@Column(nullable = false, unique = true)
private String username;
- @Column(nullable = false, unique = true)
+ @Column(nullable = false)
private String email;
@Column(nullable = false)
From 316ca7c04262de5248824f4f8714f82392549fe5 Mon Sep 17 00:00:00 2001
From: Nico Athanassiadis <nico@dsv.su.se>
Date: Mon, 31 Mar 2025 13:33:35 +0200
Subject: [PATCH 2/2] Removed manual check of email
New users would never be able to login because of the manual checking of email.
This has happened since the requirements and code has changed over time and we
missed the manual constraint.
This is related to the fix where we removed the database constraint.
---
src/main/java/se/su/dsv/seshat/services/UserService.java | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/main/java/se/su/dsv/seshat/services/UserService.java b/src/main/java/se/su/dsv/seshat/services/UserService.java
index e54895c..515d01f 100644
--- a/src/main/java/se/su/dsv/seshat/services/UserService.java
+++ b/src/main/java/se/su/dsv/seshat/services/UserService.java
@@ -17,9 +17,6 @@ public class UserService {
if (appUserRepository.existsByUsername(username)) {
throw new IllegalArgumentException("Username already exists");
}
- if (appUserRepository.existsByEmail(email)) {
- throw new IllegalArgumentException("Email already exists");
- }
AppUser newUser = new AppUser(username, email, "USER");
appUserRepository.save(newUser);