From cced346d3b179a6eba14acab84110da92a352b61 Mon Sep 17 00:00:00 2001 From: Nico Athanassiadis Date: Tue, 4 Feb 2025 06:39:07 +0100 Subject: [PATCH] Ensured clean up of uploaded file if job fails. Previously if a job failed and it's status was set to `JobStatus.FAILED` the uploaded file was never removed. Which was the intended design. This was an omission. Now if the job is set to FAILED, the uploaded file will be removed correctly. This is to ensure that uploaded files do not persist in perpetuity on the file system. FileMetadata will still be available in the DB (B.N. not the actual file). --- src/main/java/se/su/dsv/seshat/services/JobProcessorService.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/se/su/dsv/seshat/services/JobProcessorService.java b/src/main/java/se/su/dsv/seshat/services/JobProcessorService.java index 9408433..35a68be 100644 --- a/src/main/java/se/su/dsv/seshat/services/JobProcessorService.java +++ b/src/main/java/se/su/dsv/seshat/services/JobProcessorService.java @@ -95,6 +95,7 @@ public class JobProcessorService { logger.info("Transcription failed for file: {}", managedJob.getFileName()); managedJob.setJobStatus(JobStatus.FAILED); fileMetadataRepository.saveAndFlush(managedJob); + cleanupFile(managedJob); break; } } catch (ObjectOptimisticLockingFailureException e) { -- 2.39.5