DMC/studentportalen
1
1
Fork 0
Code Issues 50 Pull Requests 1 Actions 2 Projects 1 Wiki Activity

Start time grid #62

Merged
stne3960 merged 30 commits from start_time_grid into main 2026-01-16 14:17:09 +01:00
Conversation 7 Commits 30 Files Changed 32 +11
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8bff166cfb - Show all commits

11
frontend/src/components/InlineModal/InlineModal.tsx
View File

@ -27,6 +27,17 @@ const arrowPositionClasses: Record<ArrowPosition, string> = {
right: "right-[38px]", right: "right-[38px]",
}; };
/**
stne3960 marked this conversation as resolved Outdated
ansv7779 commented 2026-01-12 11:48:27 +01:00
Outdated
Review
Copy Link

This needs some documentation what it is. Inline and modal are to me opposing concepts. What actually is it? When would I use it compared to a modal dialog and how is it different from just a <div>?

This needs some documentation what it is. Inline and modal are to me opposing concepts. What actually is it? When would I use it compared to a modal dialog and how is it different from just a `<div>`?
* A panel with an arrow pointing to a related element above.
*
* Despite the name, this is not a modal, it doesn't block interaction or overlay
* the page. It is used to show contextual content (like a form) tied to a specific
* trigger element while keeping surrounding context visible.
*
* - vs Modal dialog: This keeps surrounding context visible, use a modal when you
* want to block interaction.
* - vs plain div: This adds the arrow indicator and callout styling.
*/
export default function InlineModal({ export default function InlineModal({
stne3960 marked this conversation as resolved
ansv7779 commented 2026-01-12 11:49:10 +01:00
Review
Copy Link

Everything else is a SVG icon, why not this too? Using a CSS border trick feels like a relic from the past.

Everything else is a SVG icon, why not this too? Using a CSS border trick feels like a relic from the past.
arrowPosition = "left", arrowPosition = "left",
arrowOffset, arrowOffset,