DMC/scipro
7
0
Fork 0
Code Issues30 Pull Requests3 Actions Projects1 Releases Wiki Activity

Make exemptions for project type apply to partner as well #128

Merged
niat8586 merged 5 commits from type-exemption-for-partner into develop 2025-03-10 07:17:29 +01:00
Conversation 4 Commits 5 Files Changed 5 +119 -4
ansv7779 commented 2025-03-05 14:31:06 +01:00
Owner

Read for context first

When authors select supervisor ideas during an open application period they are only allowed to select ideas corresponding to their degree type classification. This limitation can be lifted by giving the author an exemption for "Project type limitation" on the corresponding application period. However, this limitation is still enforced for any potential partner even if the have been given the same exemption. This change makes it so the exemption applies to any selected partner as well and not just the author selecting the supervisor idea.

How to test

  1. Log in as oskar@example.com
  2. Go to "Ideas / My ideas" page
  3. Click "Select from available ideas" on the application period "Supervisor ideas"
  4. Open the one available idea
  5. Try to select it with "Johan Student" as a partner
  6. Log in as admin
  7. Go to "Match / Application periods"
  8. Click "Edit exemptions" on the "Supervisor ideas" period
  9. Give "Johan Student" an exemption to "Project type limitation"
  10. Repeat steps 1-5
Read #119 for context first When authors select supervisor ideas during an open application period they are only allowed to select ideas corresponding to their degree type classification. This limitation can be lifted by giving the author an exemption for "Project type limitation" on the corresponding application period. However, this limitation is still enforced for any potential partner *even if* the have been given the same exemption. This change makes it so the exemption applies to any selected partner as well and not just the author selecting the supervisor idea. ## How to test 1. Log in as `oskar@example.com` 2. Go to "Ideas / My ideas" page 3. Click "Select from available ideas" on the application period "Supervisor ideas" 4. Open the one available idea 5. Try to select it with "Johan Student" as a partner 6. Log in as admin 7. Go to "Match / Application periods" 8. Click "Edit exemptions" on the "Supervisor ideas" period 9. Give "Johan Student" an exemption to "Project type limitation" 10. Repeat steps 1-5
ansv7779 added 2 commits 2025-03-05 14:31:07 +01:00
ansv7779 added 1 commit 2025-03-05 14:33:33 +01:00
gitea-actions commented 2025-03-05 14:34:26 +01:00
First-time contributor

Deployed to https://scipro-type-exemption-for-partner.branch.dsv.su.se

Deployed to https://scipro-type-exemption-for-partner.branch.dsv.su.se
niat8586 requested changes 2025-03-06 10:58:40 +01:00
Dismissed
niat8586 left a comment
Owner

Please provide test data and how to test.

Please provide test data and how to test.
ansv7779 added 1 commit 2025-03-06 12:52:35 +01:00
niat8586 reviewed 2025-03-07 09:03:45 +01:00
test-data/src/main/java/se/su/dsv/scipro/testdata/populators/PartnerTypeException.java Outdated
@ -0,0 +17,4 @@
import se.su.dsv.scipro.testdata.TestDataPopulator;
@Service
public class PartnerTypeException implements TestDataPopulator {
niat8586 commented 2025-03-07 09:03:45 +01:00
Owner

Although one can infer by the package and that it does not extend Exception that this is part of the test data,
The name PartnerTypeException is a bit unfortunate and at a quick glance it could be mistaken, would it be possible to change the name to PartnerTypeExemption or similar?

What do you think?

Although one can infer by the package and that it does not extend Exception that this is part of the test data, The name PartnerTypeException is a bit unfortunate and at a quick glance it could be mistaken, would it be possible to change the name to PartnerTypeExemption or similar? What do you think?
ansv7779 commented 2025-03-07 18:48:54 +01:00
Author
Owner

It should indeed be renamed.

It should indeed be renamed.
ansv7779 marked this conversation as resolved
ansv7779 added 1 commit 2025-03-07 18:48:24 +01:00
niat8586 approved these changes 2025-03-10 07:17:17 +01:00
niat8586 left a comment
Owner

👍

👍
niat8586 merged commit de18f200a7 into develop 2025-03-10 07:17:29 +01:00
niat8586 deleted branch type-exemption-for-partner 2025-03-10 07:17:29 +01:00
Sign in to join this conversation.
No Reviewers
niat8586
No Label
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#128
No description provided.
Delete Branch "type-exemption-for-partner"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?