DMC/scipro
7
0
Fork 0
Code Issues31 Pull Requests4 Actions Projects1 Releases Wiki Activity

Fix localizer warning on the finishing up tab for each author #101

Merged
niat8586 merged 2 commits from reflection_not_submitted into develop 2025-02-07 07:50:03 +01:00
Conversation 2 Commits 2 Files Changed 1 +7 -1
ansv7779 commented 2025-02-05 13:32:02 +01:00
Owner

Fixes

The getReflectionText method was calling getString when no reflection has been submitted. This is not a relevant case for the editing form since it can not be accessed when there is no reflection. Inlined the method call and removed the non-submitted case, the default will be an empty string.

How to test

  1. Log in as a supervisor
  2. Open a project that has a Daisy connection (identifieris non-null on the Project)
  3. Go to the "Finishing up" tab
  4. Go to the tab for the author with no reflection submitted
  5. See that no warning is logged
Fixes #48 The `getReflectionText` method was calling `getString` when no reflection has been submitted. This is not a relevant case for the editing form since it can not be accessed when there is no reflection. Inlined the method call and removed the non-submitted case, the default will be an empty string. ## How to test 1. Log in as a supervisor 2. Open a project that has a Daisy connection (`identifier`is non-null on the `Project`) 3. Go to the "Finishing up" tab 4. Go to the tab for the author with no reflection submitted 5. See that no warning is logged
ansv7779 added 1 commit 2025-02-05 13:32:02 +01:00
gitea-actions commented 2025-02-05 13:34:16 +01:00
First-time contributor

Deployed to https://scipro-reflectionnotsubmitted.branch.dsv.su.se

Deployed to https://scipro-reflectionnotsubmitted.branch.dsv.su.se
niat8586 approved these changes 2025-02-07 07:26:16 +01:00
niat8586 left a comment
Owner

👍

Tested.

👍 Tested.
niat8586 added 1 commit 2025-02-07 07:26:29 +01:00
niat8586 merged commit 219c312441 into develop 2025-02-07 07:50:03 +01:00
niat8586 deleted branch reflection_not_submitted 2025-02-07 07:50:04 +01:00
Sign in to join this conversation.
No Reviewers
niat8586
No Label
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#101
No description provided.
Delete Branch "reflection_not_submitted"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?