Allow deletion of forum replies #111

Open

ansv7779 wants to merge 5 commits from remove-forum-post into develop

pull from: remove-forum-post

merge into: DMC:develop

Conversation 2 Commits 5 Files Changed 13 +243 -27

ansv7779 commented 2025-02-17 13:59:26 +01:00

Owner

Copy Link

Only forum replies are allowed to be deleted. Entire threads (and the initial post) can not be deleted.

Fixes #90

How to test

1. Log in as eric@example.com (supervisor) or as sture@example.com (author)
2. Open the forum in project "Putting the it in supervising"
3. Create a new thread
4. Post some replies as the different users
5. Delete the replies

Only forum replies are allowed to be deleted. Entire threads (and the initial post) can not be deleted. Fixes #90 ## How to test 1. Log in as `eric@example.com` (supervisor) or as `sture@example.com` (author) 2. Open the forum in project "Putting the it in supervising" 3. Create a new thread 4. Post some replies as the different users 5. Delete the replies

ansv7779 added 2 commits 2025-02-17 13:59:26 +01:00

Refactor so everyone goes through BasicForumService to get forum related data cb4de36f2c

Allow deletion of forum posts ... 3933cfa2be

Only your own posts can be deleted and never the initial post in a thread.

ansv7779 added 1 commit 2025-02-17 14:02:18 +01:00

Fix mock test a9871eb470

ansv7779 changed title from Allow deletion of forum replies to WIP: Allow deletion of forum replies 2025-02-17 14:03:18 +01:00

gitea-actions commented 2025-02-17 14:03:20 +01:00

First-time contributor

Copy Link

Deployed to https://scipro-remove-forum-post.branch.dsv.su.se

Deployed to https://scipro-remove-forum-post.branch.dsv.su.se

ansv7779 added 1 commit 2025-02-17 14:17:45 +01:00

Added tests for deletion logic fd8c7a620a

ansv7779 changed title from WIP: Allow deletion of forum replies to Allow deletion of forum replies 2025-02-17 14:39:27 +01:00

ansv7779 added 1 commit 2025-02-17 14:39:35 +01:00

Merge branch 'develop' into remove-forum-post e3c5cea2a2

ansv7779 added the

po

needed

label 2025-02-17 16:03:26 +01:00

niat8586 approved these changes 2025-02-20 14:22:30 +01:00

niat8586 left a comment

Owner

Copy Link

👍
Code looks good.
Really like that you moved some of the logic happening in panels to BasicForumService

👍 Code looks good. Really like that you moved some of the logic happening in panels to BasicForumService

All checks were successful

Hide all checks

Build and test / build-and-test (push) Successful in 16m21s

Details

Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m25s

Details

This pull request is blocked because it's outdated.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin remove-forum-post:remove-forum-post

git checkout remove-forum-post

Sign in to join this conversation.

Reviewers

No Reviewers

niat8586

Labels

Clear labels

bug

Something is not working

discussion

duplicate

This issue or pull request already exists

enhancement

New feature

frozen

The issue is not solved, but it will be investigated in the future it the issue arises again

help wanted

Need some help

invalid

Something is wrong

new

To be discussed at the next meeting

po

approved

po

changes

PO has requested changes

po

needed

question

More information is needed

size

1

size

2

size

3

wontfix

This won't be fixed

No Label

po

needed

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DMC/scipro#111

No description provided.