DMC/scipro
7
0
Fork 0
Code Issues 27 Pull Requests 5 Actions 3 Projects 1 Wiki Activity

Fix crash when editing an application period #117

Open
ansv7779 wants to merge 4 commits from edit-application-period into develop
pull from: edit-application-period
merge into: DMC:develop
Conversation 1 Commits 4 Files Changed 4 +8 -27
ansv7779 commented 2025-02-20 16:18:34 +01:00
Owner
Copy Link

Fixes #68

How to test

  1. Log in as admin
  2. Go to "Match / Application periods"
  3. Click the edit icon (6th column)
  4. Click "Save"
Fixes #68 ## How to test 1. Log in as admin 2. Go to "Match / Application periods" 3. Click the edit icon (6th column) 4. Click "Save"
ansv7779 added 3 commits 2025-02-20 16:18:35 +01:00 
Confuses developers into thinking an application period's project types are modified in more places than they actually are.
Fix editing application periods
All checks were successful
Build and test / build-and-test (push) Successful in 19m0s
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 2m36s
Details
1e109e2de8 
Instead of clearing an attached entity's persistent set, remove the things we want to remove and add the things that are missing.
gitea-actions commented 2025-02-21 00:32:20 +01:00
First-time contributor
Copy Link

Deployed to https://scipro-edit-application-period.branch.dsv.su.se

Deployed to https://scipro-edit-application-period.branch.dsv.su.se
niat8586 requested review from niat8586 2025-03-03 07:35:54 +01:00
niat8586 approved these changes 2025-03-03 07:38:35 +01:00
niat8586 left a comment
Owner
Copy Link

👍

👍
niat8586 added 1 commit 2025-03-03 07:38:46 +01:00
Merge branch 'develop' into edit-application-period
Some checks are pending
Build and test / build-and-test (push) Waiting to run
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Waiting to run
Details
e75263c209
Some checks are pending
Build and test / build-and-test (push) Waiting to run
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Waiting to run
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin edit-application-period:edit-application-period
git checkout edit-application-period
Sign in to join this conversation.
Reviewers
No Reviewers
niat8586
Labels
Clear labels
bug
Something is not working
discussion
duplicate
This issue or pull request already exists
enhancement
New feature
frozen
The issue is not solved, but it will be investigated in the future it the issue arises again
help wanted
Need some help
invalid
Something is wrong
new
To be discussed at the next meeting
po
approved
po
changes
PO has requested changes
po
needed
question
More information is needed
size
1
size
2
size
3
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#117
No description provided.
Delete Branch "edit-application-period"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?