DMC/scipro
12
0
Fork 0
Code Issues 3 Pull Requests 2 Actions Wiki Activity

Allow authors to re-submit their reflection on supervisor's request #12

Closed
ansv7779 wants to merge 8 commits from 3213-reflection-resubmission into develop
pull from: 3213-reflection-resubmission
merge into: DMC:develop
Conversation 1 Commits 8 Files Changed 21 +420 -17
ansv7779 commented 2024-09-25 14:01:43 +02:00
Owner
Copy Link

There are minimum requirements for the reflection document submitted by authors at the end of the thesis process. Before now there was no way to handle the case when the reflection did not meet these minimum requirements.

This change gives the supervisors the ability to request improvements to the reflection with a comment about what has to change.

How to test

  1. Set up/find a project that has had a final seminar.
  2. Switch to an author
  3. Submit a reflection (and final thesis if required)
  4. Switch to the supervisor
  5. Go to the "Finishing up" page and switch to the author's tab
  6. Scroll down to the reflection criteria (Ö6) and view the reflection
  7. Request a new one
  8. Go back to step 2
There are minimum requirements for the reflection document submitted by authors at the end of the thesis process. Before now there was no way to handle the case when the reflection did not meet these minimum requirements. This change gives the supervisors the ability to request improvements to the reflection with a comment about what has to change. ### How to test 1. Set up/find a project that has had a final seminar. 2. Switch to an author 3. Submit a reflection (and final thesis if required) 4. Switch to the supervisor 5. Go to the "Finishing up" page and switch to the author's tab 6. Scroll down to the reflection criteria (Ö6) and view the reflection 7. Request a new one 8. Go back to step 2
ansv7779 added 8 commits 2024-09-25 14:01:43 +02:00 
Use the same language as the GUI to make it easier when talking about the states.
Can not send the notification from the Notifications class since that class is registered in the test-context and for some reason HSQLDB fails with some unknown check constraint violation with absolutely no information about why.

For some reason it is not possible to debug HSQLDB with breakpoints to step through and see exactly why it fails, so registering a new single purpose class in the cross-cutting module (that's not available in test) is used as a work-around.
tozh4728 requested review from tozh4728 2024-10-03 13:47:54 +02:00
tozh4728 approved these changes 2024-10-03 13:48:20 +02:00
tozh4728 left a comment
Owner
Copy Link

I am happy.

I am happy.
ansv7779 commented 2024-10-03 14:01:10 +02:00
Author
Owner
Copy Link

Superseded by #13

Superseded by #13
ansv7779 closed this pull request 2024-10-03 14:01:10 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
tozh4728
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DMC/scipro#12
No description provided.
Delete Branch "3213-reflection-resubmission"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?