DMC/scipro
12
0
Fork 0
Code Issues 3 Pull Requests 3 Actions Wiki Activity

Allows admins to manage grading report templates #14

Merged
niat8586 merged 41 commits from 3482-new-grading-criteria into develop 2024-10-30 10:05:23 +01:00
Conversation 0 Commits 41 Files Changed 69 +2208 -111
ansv7779 commented 2024-10-24 16:21:17 +02:00
Owner
Copy Link

Manage grading report templates

Every once in a while the criteria used to asses theses and individual performance changes. When this happens the criteria in SciPro needs to be updated.

Up until now there has not been a GUI to do this and it has instead been done manually, sometimes using database migrations. It was also time-sensitive since there was only ever one template (per project type) in SciPro such that the change had to happen at the correct time when the new template was to take effect.

There was also the question of how to calculate the grade the author should receive based on the point sum from the supervisors assessment of all the criteria and these limits were hard-coded in the system.

These changes address all of the above;

  • There can be multiple templates per type.
  • Each template has a period during which it is are current.
  • Each template has defined the conversion of point sums to grades.

The periods can not overlap and a template remains current from its start date until another template's start date is reached. There can not be two templates (within a project type) that become valid on the same date.

How to test

  1. Log in as administrator
  2. Go to "Project management"
  3. Go to "Grading templates"
  4. Create/edit new templates
  5. View current template

Card 3482

# Manage grading report templates Every once in a while the criteria used to asses theses and individual performance changes. When this happens the criteria in SciPro needs to be updated. Up until now there has not been a GUI to do this and it has instead been done manually, sometimes using database migrations. It was also time-sensitive since there was only ever one template (per project type) in SciPro such that the change had to happen at the correct time when the new template was to take effect. There was also the question of how to calculate the grade the author should receive based on the point sum from the supervisors assessment of all the criteria and these limits were hard-coded in the system. These changes address all of the above; * There can be multiple templates per type. * Each template has a period during which it is are current. * Each template has defined the conversion of point sums to grades. The periods can not overlap and a template remains current from its start date until another template's start date is reached. There can not be two templates (within a project type) that become valid on the same date. ## How to test 1. Log in as administrator 2. Go to "Project management" 3. Go to "Grading templates" 4. Create/edit new templates 5. View current template Card 3482
ansv7779 added 38 commits 2024-10-24 16:21:18 +02:00 
To allow changing the template for future projects without affecting currently ongoing ones.

Removed the credits separation and only determines based on project type since the one-year and two-year master have been separate types for many years at this point.
Before when adding/removing points any text changes were lost.
It used to match the title against "Ö1 " to determine if it was the opposition criterion for special treatment.
It used to match the title against "Ö6 " to determine if it was the reflection criterion for special treatment.
Grade can be any string rather than a limited set
ansv7779 reviewed 2024-10-28 13:46:06 +01:00
core/src/main/java/se/su/dsv/scipro/report/DuplicateDateException.java Outdated
@ -0,0 +4,4 @@
import java.time.LocalDate;
public class DuplicateDateException extends Throwable {
ansv7779 commented 2024-10-28 13:46:06 +01:00
Author
Owner
Copy Link

Should extend Exception instead of Throwable

Should extend Exception instead of Throwable
ansv7779 marked this conversation as resolved
ansv7779 added 2 commits 2024-10-28 14:38:50 +01:00 
# Conflicts:
#	core/src/main/java/se/su/dsv/scipro/report/GradingReportTemplateRepo.java
niat8586 reviewed 2024-10-29 07:46:10 +01:00
core/src/main/java/se/su/dsv/scipro/grading/GradingReportTemplateService.java
@ -0,0 +10,4 @@
import java.time.LocalDate;
import java.util.List;
public interface GradingReportTemplateService {
niat8586 commented 2024-10-29 07:46:10 +01:00
Owner
Copy Link

Shouldn't we be able to delete faulty or unwanted templates? Maybe we should introduce that in the future?

Shouldn't we be able to delete faulty or unwanted templates? Maybe we should introduce that in the future?
niat8586 reviewed 2024-10-29 09:27:00 +01:00
core/src/main/java/se/su/dsv/scipro/report/AbstractGradingCriterion.java Outdated
@ -8,1 +11,4 @@
public enum Flag {
/**
* Criterion marked with this flag will extra functionality related
niat8586 commented 2024-10-29 09:27:00 +01:00
Owner
Copy Link

"Criterion marked with this flag will extra functionality related ..." should it say "Criterion marked with this flag will add extra functionality related

Same with the other comments i'm guessing.

"Criterion marked with this flag will extra functionality related ..." should it say "Criterion marked with this flag will **add** extra functionality related Same with the other comments i'm guessing.
niat8586 marked this conversation as resolved
niat8586 added 1 commit 2024-10-29 09:29:54 +01:00 
Added missing 'add' in the java doc for the flags.
niat8586 approved these changes 2024-10-29 09:46:06 +01:00
niat8586 merged commit e18af72336 into develop 2024-10-30 10:05:23 +01:00
niat8586 deleted branch 3482-new-grading-criteria 2024-10-30 10:05:23 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
niat8586
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DMC/scipro#14
No description provided.
Delete Branch "3482-new-grading-criteria"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?