DMC/scipro
7
0
Fork 0
Code Issues41 Pull Requests6 Actions Projects1 Releases Wiki Activity

Project level and credits active participations and opposition #151

Open
niat8586 wants to merge 4 commits from project-level-credits-participants-view into develop
Conversation 5 Commits 4 Files Changed 3 +71 -2
niat8586 commented 2025-04-14 10:11:37 +02:00
Owner

Fixes

Previously accessing the final seminar view for active participations students could only see the project title on the top of the page,
the project level (bachelor, master ...) and credits for the level where missing.

In other places of the application we are showing the title, project level and credits.

Now the title, project level and credits are shown in the view following the same pattern as in other places of the application

How to test:

  • Log in as beata@example.com
  • Select 'All Final Seminars' tab
  • Select radio button 'Past final seminars'
  • Select project 'A bachelor thesis'
  • Verify that title, project type and credits are shown.
Fixes #145 Previously accessing the final seminar view for active participations students could only see the project title on the top of the page, the project level (bachelor, master ...) and credits for the level where missing. In other places of the application we are showing the title, project level and credits. Now the title, project level and credits are shown in the view following the same pattern as in other places of the application How to test: - Log in as beata@example.com - Select 'All Final Seminars' tab - Select radio button 'Past final seminars' - Select project 'A bachelor thesis' - Verify that title, project type and credits are shown.
niat8586 added 1 commit 2025-04-14 10:11:38 +02:00 
Previously accessing the final seminar view for active participations students could only see the project title on the top of the page,
the project level (bachelor, master ...) and credits for the level where missing.

In other places of the application we are showing the title, project level and credits.

Now the title, project level and credits are shown in the view following the same pattern as in other places of the application
niat8586 changed title from Project level and credits active participations and opposition to WIP: Project level and credits active participations and opposition 2025-04-14 10:11:44 +02:00
niat8586 commented 2025-04-14 10:12:00 +02:00
Author
Owner

Will need some help with creating test data

Will need some help with creating test data
gitea-actions commented 2025-04-14 10:15:17 +02:00
First-time contributor

Deployed to https://scipro-project-level-credits-participants-view.branch.dsv.su.se

Deployed to https://scipro-project-level-credits-participants-view.branch.dsv.su.se
niat8586 added 1 commit 2025-04-14 11:06:30 +02:00 
Added test data for project level credits

Log in as beata@example.com
Select 'All Final Seminars' tab
Select radio button 'Past final seminars'
Select project 'A bachelor thesis'
Verify that title, project type and credits are shown.
niat8586 added 1 commit 2025-04-14 11:07:11 +02:00
niat8586 changed title from WIP: Project level and credits active participations and opposition to Project level and credits active participations and opposition 2025-04-14 11:09:12 +02:00
niat8586 added 1 commit 2025-04-14 11:34:24 +02:00
niat8586 commented 2025-04-15 08:06:02 +02:00
Author
Owner

After review add the 'po needed' label

After review add the 'po needed' label
niat8586 added the
po
needed
 label 2025-04-15 11:31:11 +02:00
ansv7779 approved these changes 2025-04-15 12:56:06 +02:00
andan commented 2025-04-22 15:47:47 +02:00
Owner

It seems to work fine for the example thesis "a bachelor thesis". However not for the other example thesis ("putting the it in supervising") under all final seminars. Please see the attached screenshot image.png. Mabye it is because the student is not active participant or opponent for "putting the it in supervising"?

It seems to work fine for the example thesis "a bachelor thesis". However not for the other example thesis ("putting the it in supervising") under all final seminars. Please see the attached screenshot ![image.png](/attachments/01a96055-f186-4b88-8307-ba00f904b69a). Mabye it is because the student is not active participant or opponent for "putting the it in supervising"?
image.png
86 KiB
andan added
po
changes
 and removed
po
needed
 labels 2025-04-22 16:59:44 +02:00
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m31s
Details
Build and test / build-and-test (push) Successful in 17m0s
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin project-level-credits-participants-view:project-level-credits-participants-view
git checkout project-level-credits-participants-view
Sign in to join this conversation.
No Reviewers
ansv7779
No Label
po
changes
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#151
No description provided.
Delete Branch "project-level-credits-participants-view"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?