DMC/scipro
7
0
Fork 0
Code Issues41 Pull Requests6 Actions Projects1 Releases Wiki Activity

Fix some remaining issues from the Spring migration #20

Merged
niat8586 merged 14 commits from release-firefighting into develop 2024-11-20 12:56:22 +01:00
Conversation 1 Commits 14 Files Changed 14 +37 -2
ansv7779 commented 2024-11-19 11:06:07 +01:00
Owner

A few missing @Bean definitions were discovered.

Spring also has a much stricter requirement about requiring @Transactional for every database change.

How to test @Bean GroupFacadeImpl

  1. Log in as a supervisor
  2. Go to "My groups" and create a group
  3. Go back to "My groups" and try to open the group

How to test @Bean IdeaFacadae

  1. Create an application period that is open ("Admin" / "Match" / "Application periods")
  2. Log in as an author
  3. Go to "Ideas" / "My ideas"
  4. Click "Select from available ideas" in the period created in step 1

How to test missing @Transactional

  1. Log in as a user with notifications (or generate some by for example writing in the forum)
  2. Go to "Notifications" in the top right
  3. Click on any notification subject to navigate to it

How to test crash while trying to schedule final seminar

  1. Log in as a supervisor
  2. Open a project and attempt to schedule a final seminar

How to test crash while trying to upload final thesis as supervisor

  1. Log in as supervisor
  2. Note down the supervisors username
  3. Open a project that has had a final seminar
  4. Go to the "Finishing up" tab
  5. Submit the supervisors username as the custom principal
  6. Try to upload a final thesis

How to test removal of approved final thesis

  1. Log in as supervisor
  2. Note down the supervisors username
  3. Open a project that has had a final seminar
  4. Go to the "Finishing up" tab
  5. Submit the supervisors username as the custom principal
  6. Upload a final thesis
  7. Approve the final thesis
  8. Remove the approval

How to test crash while trying to schedule first meeting

  1. Log in as supervisor
  2. Open a project
  3. Go to the "First meeting tab"
  4. Try to submit

How to test crash while trying to unselect an idea as an author

  1. Create an application period that is open ("Admin" / "Match" / "Application periods")
  2. Log in as an author
  3. Go to "Ideas" / "My ideas"
  4. Click "Select from available ideas" in the period created in step 1
  5. Select any available supervisor idea
  6. Go back to "Ideas" / "My ideas"
  7. Open the selected idea
  8. Hit unselect at the bottom

How to test crash while trying to toggle milestone

  1. Log in as supervisor
  2. Open any project
  3. Go to "Milestones" tab
  4. Attempt to toggle both individual and project milestones

How to test crash while trying to get user's note

  1. Find a user without a row in the note table
  2. Log in as that user
  3. Click "My notes" in the top right
A few missing `@Bean` definitions were discovered. Spring also has a much stricter requirement about requiring `@Transactional` for every database change. ## How to test `@Bean GroupFacadeImpl` 1. Log in as a supervisor 2. Go to "My groups" and create a group 3. Go back to "My groups" and try to open the group ## How to test `@Bean IdeaFacadae` 1. Create an application period that is open ("Admin" / "Match" / "Application periods") 2. Log in as an author 3. Go to "Ideas" / "My ideas" 4. Click "Select from available ideas" in the period created in step 1 ## How to test missing `@Transactional` 1. Log in as a user with notifications (or generate some by for example writing in the forum) 2. Go to "Notifications" in the top right 3. Click on any notification subject to navigate to it ## How to test crash while trying to schedule final seminar 1. Log in as a supervisor 2. Open a project and attempt to schedule a final seminar ## How to test crash while trying to upload final thesis as supervisor 1. Log in as supervisor 2. Note down the supervisors username 3. Open a project that has had a final seminar 4. Go to the "Finishing up" tab 5. Submit the supervisors username as the custom principal 6. Try to upload a final thesis ## How to test removal of approved final thesis 1. Log in as supervisor 2. Note down the supervisors username 3. Open a project that has had a final seminar 4. Go to the "Finishing up" tab 5. Submit the supervisors username as the custom principal 6. Upload a final thesis 7. Approve the final thesis 8. Remove the approval ## How to test crash while trying to schedule first meeting 1. Log in as supervisor 2. Open a project 3. Go to the "First meeting tab" 4. Try to submit ## How to test crash while trying to unselect an idea as an author 1. Create an application period that is open ("Admin" / "Match" / "Application periods") 2. Log in as an author 3. Go to "Ideas" / "My ideas" 4. Click "Select from available ideas" in the period created in step 1 5. Select any available supervisor idea 6. Go back to "Ideas" / "My ideas" 7. Open the selected idea 8. Hit unselect at the bottom ## How to test crash while trying to toggle milestone 1. Log in as supervisor 2. Open any project 3. Go to "Milestones" tab 4. Attempt to toggle both individual and project milestones ## How to test crash while trying to get user's note 1. Find a user without a row in the `note` table 2. Log in as that user 3. Click "My notes" in the top right
ansv7779 added 2 commits 2024-11-19 11:06:07 +01:00
ansv7779 added 1 commit 2024-11-19 13:50:34 +01:00 
Caused by a missing @Transactional annotation.
ansv7779 added 2 commits 2024-11-19 14:11:25 +01:00 
Caused by a missing @Transactional
Caused by missing @Transactional
ansv7779 added 1 commit 2024-11-19 14:19:33 +01:00 
Caused by missing @Transactional
ansv7779 changed title from Fix some remaining issues from the Spring migration to WIP: Fix some remaining issues from the Spring migration 2024-11-19 14:27:07 +01:00
ansv7779 added 1 commit 2024-11-19 14:28:06 +01:00 
Caused by missing @Transactional
ansv7779 added 1 commit 2024-11-19 14:32:25 +01:00
ansv7779 added 2 commits 2024-11-19 14:58:35 +01:00 
Caused by missing @Transactional
ansv7779 added 3 commits 2024-11-19 15:20:08 +01:00 
Caused by missing @Transactional
Caused by missing @Transactional
ansv7779 changed title from WIP: Fix some remaining issues from the Spring migration to Fix some remaining issues from the Spring migration 2024-11-19 15:52:02 +01:00
ansv7779 requested review from niat8586 2024-11-19 15:52:16 +01:00
ansv7779 requested review from tozh4728 2024-11-19 15:52:16 +01:00
ansv7779 added 1 commit 2024-11-20 10:24:35 +01:00
niat8586 approved these changes 2024-11-20 12:56:08 +01:00
niat8586 left a comment
Owner

👍

👍
niat8586 merged commit 73307096c3 into develop 2024-11-20 12:56:22 +01:00
niat8586 deleted branch release-firefighting 2024-11-20 12:56:22 +01:00
Sign in to join this conversation.
No Reviewers
tozh4728
niat8586
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#20
No description provided.
Delete Branch "release-firefighting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?