DMC/scipro
7
0
Fork 0
Code Issues 20 Pull Requests 8 Actions Projects 1 Wiki Activity

Fix saving the textboxes students fill in when submitting ideas #25

Merged
niat8586 merged 1 commits from fix-submitting-ideas into develop 2024-11-25 11:24:09 +01:00
Conversation 0 Commits 1 Files Changed 1 +5 -5
ansv7779 commented 2024-11-25 10:16:49 +01:00
Owner
Copy Link

Background, literature, problem, method, and interests were not being saved due to explicitly having been marked as "do not save".

Multiple OTRS tickets have been filed for this problem; 391725, 391732, 391738, and 391757.

How to test

  1. Create an open application period under "Admin" / "Match" / "Application periods" (open meaning start is before today, end is after)
  2. Log in as author
  3. Submit an idea in the newly created period
  4. See that neither of background, literature, problem, method, or interests textboxes are saved
  5. Switch to this branch
  6. Submit/update the idea
  7. See that everything is saved
Background, literature, problem, method, and interests were not being saved due to explicitly having been marked as "do not save". Multiple OTRS tickets have been filed for this problem; [391725](https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=391725#1422495), [391732](https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=391732#1422521), [391738](https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=391738#1422537), and [391757](https://otrs.dsv.su.se/otrs/index.pl?Action=AgentTicketZoom;TicketID=391757#1422590). ## How to test 1. Create an open application period under "Admin" / "Match" / "Application periods" (open meaning start is before today, end is after) 2. Log in as author 3. Submit an idea in the newly created period 4. See that neither of background, literature, problem, method, or interests textboxes are saved 5. Switch to this branch 6. Submit/update the idea 7. See that everything is saved
ansv7779 added 1 commit 2024-11-25 10:16:49 +01:00
Fix saving the textboxes students fill in when submitting ideas
All checks were successful
Build and test / build-and-test (push) Successful in 6m50s
Details
65f78da033 
Background, literature, problem, method, and interests were not being saved due to explicitly having been marked as "do not save".
niat8586 approved these changes 2024-11-25 11:23:56 +01:00
niat8586 left a comment
Owner
Copy Link

👍

👍
niat8586 merged commit aabb2e9d10 into develop 2024-11-25 11:24:09 +01:00
niat8586 deleted branch fix-submitting-ideas 2024-11-25 11:24:09 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
niat8586
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
new

To be discussed at the next meeting

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
new
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DMC/scipro#25
No description provided.
Delete Branch "fix-submitting-ideas"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?