Do not add duplicate supervisors in Daisy #26

ansv7779 · 2024-11-25T16:39:16+01:00

ansv7779 commented

2024-11-25 16:39:16 +01:00

Daisy's API does not support the function "change supervisor" and only what comes down to SQL INSERT and DELETE on a specific table. If the removal of the previous supervisor(s) failed the new one was still added. This change makes it so that if the removal of any (there is no limit in the API) current supervisor fails it will not attempt to add the new supervisor.

Fixes #39

How to test

Configure the Daisy integration in SciPro
Enable it (Maven profile)
The only currently known way to make removing a supervisor fail is to use a project where they've sent the thesis to the examiner
Find one such project in the test server for Daisy (or send one for examination from SciPro)
Change the supervisor of the project in SciPro
Run the job "Export projects to daisy" (System / Maintenance)
See that it logs the failure and that no duplicate supervisors were added to Daisy

Daisy's API does not support the function "change supervisor" and only what comes down to SQL INSERT and DELETE on a specific table. If the removal of the previous supervisor(s) failed the new one was still added. This change makes it so that if the removal of any (there is no limit in the API) current supervisor fails it will not attempt to add the new supervisor. Fixes #39 ## How to test 1. Configure the Daisy integration in SciPro 2. Enable it (Maven profile) 3. The only currently known way to make removing a supervisor fail is to use a project where they've sent the thesis to the examiner 4. Find one such project in the test server for Daisy (or send one for examination from SciPro) 5. Change the supervisor of the project in SciPro 6. Run the job "Export projects to daisy" (System / Maintenance) 7. See that it logs the failure and that no duplicate supervisors were added to Daisy

ansv7779 added 1 commit 2024-11-25 16:39:17 +01:00

Do not add duplicate supervisors in Daisy

Build and test / build-and-test (push) Successful in 6m49s

Details

f3c4f7aeb8

Daisy's API does not support the function "change supervisor" and only what comes down to SQL INSERT and DELETE on a specific table. If the removal of the previous supervisor(s) failed the new one was still added. This change makes it so that if the removal of any (there is no limit in the API) current supervisor fails it will not attempt to add the new supervisor.

ansv7779 force-pushed handle-supervisor-change-failure from f3c4f7aeb8 to 09cf81d4f3

2024-11-28 18:14:45 +01:00

Compare

tozh4728 reviewed 2024-12-02 08:54:06 +01:00

daisy-integration/src/main/java/se/su/dsv/scipro/integration/daisy/workers/ProjectExporter.java Outdated

						
				@ -247,7 +248,20 @@ public class ProjectExporter extends AbstractWorker {

				                if (contributor.getPerson().getId().equals(project.getHeadSupervisor().getIdentifier())) {

				                    add = false;