DMC/scipro
7
0
Fork 0
Code Issues 20 Pull Requests 1 Actions Projects 1 Wiki Activity

Fix certain milestones not getting activated #54

Merged
niat8586 merged 2 commits from milestones-not-activating into develop 2024-12-16 14:20:42 +01:00
Conversation 1 Commits 2 Files Changed 2 +36
ansv7779 commented 2024-12-04 10:57:43 +01:00
Owner
Copy Link

There was a missing bean definition that was responsible for marking certain milestones based on system events.

Fixes #53

How to test

  1. Log in as an author
  2. Go to "Peer" tab within a project
  3. Request a peer review
  4. [If needed] Switch to another author and request another review
  5. Perform a peer review
  6. See that the peer reviewer completed milestone (first or second depending) is marked as completed
There was a missing bean definition that was responsible for marking certain milestones based on system events. Fixes #53 ## How to test 1. Log in as an author 2. Go to "Peer" tab within a project 3. Request a peer review 4. [If needed] Switch to another author and request another review 5. Perform a peer review 6. See that the peer reviewer completed milestone (first or second depending) is marked as completed
ansv7779 added 1 commit 2024-12-04 10:57:44 +01:00
Fix certain milestones not getting activated
All checks were successful
Build and test / build-and-test (push) Successful in 7m9s
Details
6d2c18e721 
There was a missing bean definition that was responsible for marking certain milestones based on system events.
ansv7779 requested review from niat8586 2024-12-16 09:58:46 +01:00
ansv7779 requested review from tozh4728 2024-12-16 09:58:46 +01:00
ansv7779 added 1 commit 2024-12-16 13:56:05 +01:00
Merge branch 'develop' into milestones-not-activating
All checks were successful
Build and test / build-and-test (push) Successful in 22m1s
Details
9a98ac3db4
niat8586 approved these changes 2024-12-16 14:20:24 +01:00
niat8586 left a comment
Owner
Copy Link

beans are good

beans are good
niat8586 merged commit a1d3d0be8d into develop 2024-12-16 14:20:42 +01:00
niat8586 deleted branch milestones-not-activating 2024-12-16 14:20:42 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
tozh4728
niat8586
Labels
Clear labels
bug
Something is not working
discussion
duplicate
This issue or pull request already exists
enhancement
New feature
frozen
The issue is not solved, but it will be investigated in the future it the issue arises again
help wanted
Need some help
invalid
Something is wrong
new
To be discussed at the next meeting
po
approved
po
needed
question
More information is needed
size
1
size
2
size
3
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#54
No description provided.
Delete Branch "milestones-not-activating"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?