DMC/scipro
7
0
Fork 0
Code Issues 27 Pull Requests 4 Actions Projects 1 Wiki Activity

Allow a single author to start multiple ideas of different types #70

Merged
tozh4728 merged 3 commits from same-author-multiple-projects-different-levels into develop 2025-01-13 12:17:53 +01:00
Conversation 3 Commits 3 Files Changed 2 +21 -12
ansv7779 commented 2024-12-20 12:18:12 +01:00
Owner
Copy Link

Fixes #42

With Daisy integration turned on it is asked whether a project is allowed to start based on an idea. The primary way it does its permission check is by making sure the author is registered for the right course, and that only one thesis is written at a time. Previously the only way to specify which course to check for was based on the notion of "educational level". The problem that then arises is that one-year master and master are both on the advanced level and thus indistinguishable. When Daisy can not differentiate which course it will always reject the second project since they're both on advanced level.

Daisy's API has now been updated to, in additional to educational level, allow specifying how many credits the course should give which enables differentiating between one-year master (15 credits) and master (30 credits).

How to test

  1. Find a student that has never written a thesis
  2. In Daisy: register the student for the following courses: IB015F, ML015F, and ML030F under "Administration / Students / Management"
  3. Make sure the Daisy integration is properly configured in SciPro
  4. Start SciPro with the Maven profile DAISY-INTEGRATION
  5. If necessary; import the student using "Admin / Users / Import"
  6. If necessary; create project types for each degree level under "Admin / System / Type settings"
  7. If necessary; Make sure the "Match" module is turned on for those types under "Admin / System / Project module settings"
  8. Create an application period whose course start is today or earlier and includes project types that cover the three degree levels
  9. Go to "Admin / Match / Manual matching"
  10. Create one idea per type for the student, any supervisor will do (that exists as an employee in Daisy)
  11. Run the job "Export eligible ideas" under "Admin / System / Maintenance"
  12. Go to "Admin / Project Management / Projects"
  13. Search up the student
  14. See that all three projects were created
Fixes #42 With Daisy integration turned on it is asked whether a project is allowed to start based on an idea. The primary way it does its permission check is by making sure the author is registered for the right course, and that only one thesis is written at a time. Previously the only way to specify which course to check for was based on the notion of "educational level". The problem that then arises is that one-year master and master are both on the advanced level and thus indistinguishable. When Daisy can not differentiate which course it will always reject the second project since they're both on advanced level. Daisy's API has now been updated to, in additional to educational level, allow specifying how many credits the course should give which enables differentiating between one-year master (15 credits) and master (30 credits). ## How to test 1. Find a student that has never written a thesis 2. In Daisy: register the student for the following courses: IB015F, ML015F, and ML030F under "Administration / Students / Management" 3. Make sure the Daisy integration is properly configured in SciPro 4. Start SciPro with the Maven profile `DAISY-INTEGRATION` 5. If necessary; import the student using "Admin / Users / Import" 6. If necessary; create project types for each degree level under "Admin / System / Type settings" 7. If necessary; Make sure the "Match" module is turned on for those types under "Admin / System / Project module settings" 8. Create an application period whose course start is today or earlier and includes project types that cover the three degree levels 9. Go to "Admin / Match / Manual matching" 10. Create one idea per type for the student, any supervisor will do (that exists as an employee in Daisy) 11. Run the job "Export eligible ideas" under "Admin / System / Maintenance" 12. Go to "Admin / Project Management / Projects" 13. Search up the student 14. See that all three projects were created
ansv7779 added 2 commits 2024-12-20 12:18:13 +01:00
Allow a single author to write a thesis on both one-year master and master at the same time.
All checks were successful
Build and test / build-and-test (push) Successful in 15m20s
Details
4863763f04
Clean up old code
All checks were successful
Build and test / build-and-test (push) Successful in 15m28s
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m46s
Details
ec85999a5e
ansv7779 added this to the SciPro project 2024-12-20 12:18:19 +01:00
gitea-actions commented 2024-12-20 12:21:58 +01:00
First-time contributor
Copy Link

Deployed to https://scipro-same-author-multiple-projects-different-levels.branch.dsv.su.se

Deployed to https://scipro-same-author-multiple-projects-different-levels.branch.dsv.su.se
ansv7779 removed this from the SciPro project 2025-01-09 13:20:24 +01:00
tozh4728 requested review from tozh4728 2025-01-09 14:33:25 +01:00
tozh4728 approved these changes 2025-01-13 11:33:23 +01:00
Dismissed
tozh4728 approved these changes 2025-01-13 11:33:39 +01:00
tozh4728 added 1 commit 2025-01-13 11:34:03 +01:00
Merge branch 'develop' into same-author-multiple-projects-different-levels
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 2m24s
Details
Build and test / build-and-test (push) Successful in 15m52s
Details
Remove branch deployment from branch.dsv.su.se / cleanup (pull_request) Successful in 11s
Details
8d6717a024
tozh4728 merged commit b99c458160 into develop 2025-01-13 12:17:53 +01:00
tozh4728 deleted branch same-author-multiple-projects-different-levels 2025-01-13 12:17:54 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
tozh4728
Labels
Clear labels
bug
Something is not working
discussion
duplicate
This issue or pull request already exists
enhancement
New feature
frozen
The issue is not solved, but it will be investigated in the future it the issue arises again
help wanted
Need some help
invalid
Something is wrong
new
To be discussed at the next meeting
po
approved
po
changes
PO has requested changes
po
needed
question
More information is needed
size
1
size
2
size
3
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/scipro#70
No description provided.
Delete Branch "same-author-multiple-projects-different-levels"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?