WIP: Allow supervisors to request improvements from final seminar opponents #78

Draft

ansv7779 wants to merge 12 commits from opponent-completion into develop

pull from: opponent-completion

merge into: DMC:develop

Conversation 1 Commits 12 Files Changed 21 +472 -79

ansv7779 commented 2025-01-13 16:28:56 +01:00

Owner

Copy Link

Fixes #36

How to test

1. Log in as eric@example.com
2. Go to the final seminar in the "Putting the it in supervising" project
3. Log in as sid@example.com
4. Follow the notification to submit the new opposition report

Fixes #36 ## How to test 1. Log in as `eric@example.com` 2. Go to the final seminar in the "Putting the it in supervising" project 3. Log in as `sid@example.com` 4. Follow the notification to submit the new opposition report

ansv7779 added 2 commits 2025-01-13 16:28:57 +01:00

GUI to request improvements 9d88c373f2

Create test data 8ce045b33c

gitea-actions commented 2025-01-13 16:32:42 +01:00

First-time contributor

Copy Link

Deployed to https://scipro-opponent-completion.branch.dsv.su.se

Deployed to https://scipro-opponent-completion.branch.dsv.su.se

ansv7779 added 3 commits 2025-01-14 15:33:23 +01:00

foo 3c83bdd067

Opposition grading is now based on the opponents grading report criteria 257536d856

Refactored away business logic from the Wicket panel ... 5c0238485e

Changed how data is moved from the opposition to the grading report

Fixed a completely broken integration test

ansv7779 added 3 commits 2025-01-17 12:36:22 +01:00

Use the same project type for opponent and seminar c4febb11e7

Verify that opposition criteria are based on the grading report template 46cc99972f

Implement gradeOpponent 49f14a00f0

ansv7779 added 2 commits 2025-01-17 13:19:43 +01:00

Fix test issues with multiple EventBus getting registered db38a70675

Fix compilation problem 54e6e5d787

ansv7779 added 1 commit 2025-01-17 15:18:41 +01:00

Save assessment fd01796121

ansv7779 added 1 commit 2025-01-17 15:21:21 +01:00

Fix test 7a3b8d4a98

Some checks failed

Hide all checks

Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 2m8s

Details

Build and test / build-and-test (push) Failing after 15m35s

Details

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin opponent-completion:opponent-completion

git checkout opponent-completion

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

discussion

duplicate

This issue or pull request already exists

enhancement

New feature

frozen

The issue is not solved, but it will be investigated in the future it the issue arises again

help wanted

Need some help

invalid

Something is wrong

new

To be discussed at the next meeting

po

approved

po

needed

question

More information is needed

size

1

size

2

size

3

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DMC/scipro#78

No description provided.