Allow supervisors to request improvements from final seminar opponents #78

Merged
niat8586 merged 41 commits from opponent-completion into develop 2025-03-05 10:05:38 +01:00
2 changed files with 12 additions and 2 deletions
Showing only changes of commit 1b36ad7987 - Show all commits

View File

@ -58,6 +58,11 @@
</form> </form>
<form wicket:id="request_improvements"> <form wicket:id="request_improvements">
<p>
Once you request improvements the student have a limited time to make the requested changes.
If they do not make the requested improvements in time, they will get an automatic failing grade.
You will be notified when they've submitted a new report.
</p>
<div class="mb-3"> <div class="mb-3">
<label class="form-label" wicket:for="feedback_to_opponent"> <label class="form-label" wicket:for="feedback_to_opponent">
Provide feedback to the opponent on how to improve the opposition Provide feedback to the opponent on how to improve the opposition

View File

@ -323,12 +323,17 @@ public class SeminarOppositionPanel extends Panel {
@Override @Override
protected void onConfigure() { protected void onConfigure() {
super.onConfigure(); super.onConfigure();
FinalSeminarOpposition opposition = getModelObject();
setVisibilityAllowed( setVisibilityAllowed(
startDateHasPassed() && startDateHasPassed() &&
getModelObject().getPoints() == null && opposition.getPoints() == null &&
getModelObject().getFeedback() == null && opposition.getFeedback() == null &&
isHeadSupervisor() isHeadSupervisor()
); );
boolean hasRequestedImprovements = opposition.getImprovementsRequestedAt() != null;
boolean reportIsSubmitted =
opposition.getOppositionReport() != null && opposition.getOppositionReport().isSubmitted();
setEnabled(!hasRequestedImprovements || reportIsSubmitted);
} }
} }