Allow supervisors to write a note associated with their projects #8

ansv7779 · 2024-07-03T15:48:09+02:00

ansv7779 commented

2024-07-03 15:48:09 +02:00

There is a need among supervisors to maintain some work notes for each project. Where they are in the process, what students need to do, and other such things.

This PR gives the supervisors the ability to write a note for each project on their overview page.

Card 3399

There is a need among supervisors to maintain some work notes for each project. Where they are in the process, what students need to do, and other such things. This PR gives the supervisors the ability to write a note for each project on their overview page. Card 3399

ansv7779 added 6 commits 2024-07-03 15:48:10 +02:00

View/edit project notes as supervisor de3803d9d1

Do not include milliseconds in feedback when saving the note f5a7b592c0

Update the note in the table when the user is done editing. 481d8cd76e

Hide the text area label since the modal title is enough 4facacb398

Allow supervisors to toggle showing the entire note ec6eb86f91

Fix test eeedd0cd56

niat8586 reviewed 2024-07-10 10:29:15 +02:00

view/src/main/java/se/su/dsv/scipro/supervisor/panels/ProjectNoteColumn.java

						
				@ -0,0 +96,4 @@

				                @Override

				                protected void onSubmit() {

				                    projectNoteService.setUserNote(

				                            model.getObject(),

niat8586 commented

2024-07-10 10:29:15 +02:00

Rename model.getObject to projectModel.getObject ?

Would make it more readable and conform with the projectNoteService.setUserNote method.

Rename model.getObject to projectModel.getObject ? Would make it more readable and conform with the projectNoteService.setUserNote method.

ansv7779 marked this conversation as resolved

niat8586 reviewed 2024-07-10 11:18:44 +02:00

view/src/main/java/se/su/dsv/scipro/supervisor/panels/ProjectNoteColumn.java

						
				@ -0,0 +62,4 @@

				            super(id, model);

				            ModalWindowPlus modal = new LargeModalWindow("edit_note_modal");

				            modal.setTitle(model.map(Project::getTitle).map(projectTitle -> "View/Edit note for " + projectTitle));

niat8586 commented

2024-07-10 11:18:44 +02:00

Use of String.format could work here?
Example
modal.setTitle(model.map(Project::getTitle).map(projectTitle -> String.format("View/Edit note for %s", projectTitle)));

What do you think?

Use of String.format could work here? Example ```modal.setTitle(model.map(Project::getTitle).map(projectTitle -> String.format("View/Edit note for %s", projectTitle)));``` What do you think?

ansv7779 commented

2024-07-10 13:37:36 +02:00

Replaced with proper i18n

ansv7779 marked this conversation as resolved

niat8586 requested review from niat8586 2024-07-10 12:34:25 +02:00

niat8586 commented

2024-07-10 12:58:20 +02:00

If note formatted and you look at it in full note mode then it removes the formatting. Would be prettier if it keeps it's formatting when looking at full note mode.

ansv7779 added 2 commits 2024-07-10 13:28:49 +02:00

Make the full view of project notes respect formatting (line breaks) 0684919bb2

Replace string concatenation with proper i18n 9f583f9e7a

ansv7779 added 1 commit 2024-07-10 13:38:34 +02:00

Rename variable to match other model variable names 0ffe1bd79a

niat8586 approved these changes 2024-07-10 13:42:09 +02:00

niat8586 left a comment

Excellent, thanks for changes. Have a great day.

ansv7779 added 1 commit 2024-07-10 13:42:33 +02:00

Merge branch 'develop' into 3399-supervisor-project-note e11b2cc22a

ansv7779 merged commit 949de4a260 into develop

2024-07-10 13:43:27 +02:00