DMC/scipro
7
0
Fork 0
Code Issues 31 Pull Requests 3 Actions Projects 1 Wiki Activity

Allow supervisors to write a note associated with their projects #8

Merged
ansv7779 merged 10 commits from 3399-supervisor-project-note into develop 2024-07-10 13:43:27 +02:00
Conversation 4 Commits 10 Files Changed 19 +5 -5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0ffe1bd79a - Show all commits

10
view/src/main/java/se/su/dsv/scipro/supervisor/panels/ProjectNoteColumn.java
View File

@ -97,16 +97,16 @@ public class ProjectNoteColumn extends AbstractExportableColumn<Project, String>
} }
private class ViewAndEditNoteForm extends GenericPanel<Project> { private class ViewAndEditNoteForm extends GenericPanel<Project> {
ansv7779 marked this conversation as resolved
niat8586 commented 2024-07-10 10:29:15 +02:00
Review
Copy Link

Rename model.getObject to projectModel.getObject ?

Would make it more readable and conform with the projectNoteService.setUserNote method.

Rename model.getObject to projectModel.getObject ? Would make it more readable and conform with the projectNoteService.setUserNote method.
public ViewAndEditNoteForm(String id, IModel<Project> model) { public ViewAndEditNoteForm(String id, IModel<Project> project) {
super(id, model); super(id, project);
IModel<String> note = getDataModel(model); IModel<String> note = getDataModel(project);
Form<Project> form = new Form<>("form", model) { Form<Project> form = new Form<>("form", project) {
@Override @Override
protected void onSubmit() { protected void onSubmit() {
projectNoteService.setUserNote( projectNoteService.setUserNote(
model.getObject(), project.getObject(),
user.getObject(), user.getObject(),
note.getObject() note.getObject()
); );