DMC/seshat
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure clean up of uploaded file if job fails. #9

Merged
niat8586 merged 1 commits from failed-job-cleanup into develop 2025-02-04 06:43:13 +01:00
Conversation 0 Commits 1 Files Changed 1 +1
niat8586 commented 2025-02-04 06:43:03 +01:00
Owner
Copy Link

Previously if a job failed and it's status was set to JobStatus.FAILED the uploaded
file was never removed. Which was the intended design. This was an omission.

Now if the job is set to FAILED, the uploaded file will be removed correctly.
This is to ensure that uploaded files do not persist in perpetuity on the file system.

FileMetadata will still be available in the DB (B.N. not the actual file).

Previously if a job failed and it's status was set to `JobStatus.FAILED` the uploaded file was never removed. Which was the intended design. This was an omission. Now if the job is set to FAILED, the uploaded file will be removed correctly. This is to ensure that uploaded files do not persist in perpetuity on the file system. FileMetadata will still be available in the DB (B.N. not the actual file).
niat8586 added 1 commit 2025-02-04 06:43:04 +01:00 
Previously if a job failed and it's status was set to `JobStatus.FAILED` the uploaded
file was never removed. Which was the intended design. This was an omission.

Now if the job is set to FAILED, the uploaded file will be removed correctly.
This is to ensure that uploaded files do not persist in perpetuity on the file system.

FileMetadata will still be available in the DB (B.N. not the actual file).
niat8586 merged commit 8430f36f50 into develop 2025-02-04 06:43:13 +01:00
niat8586 deleted branch failed-job-cleanup 2025-02-04 06:43:14 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/seshat#9
No description provided.
Delete Branch "failed-job-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?