DMC/studentportalen
1
1
Fork 0
Code Issues 24 Pull Requests 3 Actions Projects 1 Wiki Activity

button-component #29

Open
stne3960 wants to merge 13 commits from button-component into main
pull from: button-component
merge into: DMC:main
Conversation 4 Commits 13 Files Changed 23 +997 -66
stne3960 commented 2025-11-30 17:38:56 +01:00
Owner
Copy Link

Button component.
Addressing issues #15 and #16

Button component. Addressing issues #15 and #16
stne3960 added 5 commits 2025-11-30 17:38:56 +01:00
Add more colors
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Failing after 38s
Details
2b4236550c
stne3960 added the
Code Review
Design Review
 labels 2025-11-30 17:43:50 +01:00
stne3960 added 1 commit 2025-12-01 10:47:48 +01:00
Merge branch 'main' into button-component
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 5m26s
Details
617492a87f
stne3960 added 1 commit 2025-12-01 13:16:39 +01:00
Add component library to index, until routing is fixed
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Failing after 33s
Details
f2a5cd9d26
stne3960 added 1 commit 2025-12-01 13:18:14 +01:00
Remove import
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 4m4s
Details
32376bf9ac
stne3960 commented 2025-12-01 13:29:58 +01:00
Author
Owner
Copy Link

Can be viewed on:
https://studentportalen-button-component.branch.dsv.su.se/

Can be viewed on: https://studentportalen-button-component.branch.dsv.su.se/
jare2473 commented 2025-12-01 14:28:50 +01:00
Owner
Copy Link

Feedback:

  • Use correct font
  • cursor: pointer;-css on hover
  • There should be no "on click" styling - now the buttons get focus-styling when clicked.
  • The icon-only variant is missing. But maybe this should be a separate component? What do you think?
  • Focus-outline width (I updated Figma overview to include this)
Feedback: - [x] Use correct font - [x] `cursor: pointer;`-css on hover - [x] There should be no "on click" styling - now the buttons get focus-styling when clicked. - [x] The icon-only variant is missing. But maybe this should be a separate component? What do you think? - [x] Focus-outline width (I updated Figma overview to include this)
jare2473 requested review from jare2473 2025-12-02 10:00:43 +01:00
stne3960 added 2 commits 2025-12-02 13:44:01 +01:00
Add correct font
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 4m9s
Details
5f9e62569d
stne3960 added 1 commit 2025-12-02 14:08:36 +01:00
Add text styles
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 5m42s
Details
69cb86d417
stne3960 added 1 commit 2025-12-02 14:09:11 +01:00
Reconverted fonts
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m30s
Details
f37e55f34d
jare2473 refused to review 2025-12-02 14:09:15 +01:00
stne3960 added 1 commit 2025-12-02 14:55:03 +01:00
Fix borders and text style, run prettier
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m27s
Details
ed7fb36745
stne3960 requested review from jare2473 2025-12-02 15:01:20 +01:00
jare2473 commented 2025-12-02 16:38:14 +01:00
Owner
Copy Link

Looks good! I will make icon-only button as a separate component and issue.

Looks good! I will make icon-only button as a separate component and issue.
jare2473 approved these changes 2025-12-02 16:40:47 +01:00
stne3960 removed the
Design Review
 label 2025-12-03 22:59:35 +01:00
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m27s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin button-component:button-component
git checkout button-component
Sign in to join this conversation.
Reviewers
No Reviewers
jare2473
Labels
Clear labels
Code Review
Design Review
Design system
Front end
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Code Review
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/studentportalen#29
No description provided.
Delete Branch "button-component"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?