Text input component #30

Open

stne3960 wants to merge 26 commits from text_input into main

pull from: text_input

merge into: DMC:main

Conversation 4 Commits 26 Files Changed 24 +1215 -67

stne3960 commented 2025-11-30 17:47:50 +01:00

Owner

Copy Link

Addresses issue #17

Note: TheSans is a commercial font I don't have access to.

Addresses issue #17 Note: TheSans is a commercial font I don't have access to.

stne3960 added the

Design Review

Code Review

labels 2025-11-30 17:47:50 +01:00

stne3960 added 8 commits 2025-11-30 17:47:50 +01:00

Use tailwind 7bf1c01d10

Add color and size variables 354c923773

Create button component 15b50844cb

Add component library page 4b851595fd

Add more colors 2b4236550c

Add font family and text styles 91e7d0f770

Create TextInput component 8690658ac8

Add TextInput examples to component library bcbf17432b

stne3960 removed the

Code Review

label 2025-11-30 17:56:13 +01:00

stne3960 added 1 commit 2025-12-01 10:48:23 +01:00

Merge branch 'main' into text_input 3d93230d9a

stne3960 added 1 commit 2025-12-01 13:27:15 +01:00

Add component library to index, until routing is fixed 67f45746ca

stne3960 commented 2025-12-01 13:29:08 +01:00

Author

Owner

Copy Link

Can be viewed on:
https://studentportalen-textinput.branch.dsv.su.se/

Can be viewed on: https://studentportalen-textinput.branch.dsv.su.se/

jare2473 commented 2025-12-01 14:55:49 +01:00

Owner

Copy Link

• Wrong placeholder color (or not set)
• Wrong text input color (or not set)
• When focusing on an input with an error state, the error-styling should be replaced by focus-styling.
• Make sure the component have the option for an instance to not have any placeholder text (there is no example of this in the example)

- [x] Wrong placeholder color (or not set) - [x] Wrong text input color (or not set) - [x] When focusing on an input with an error state, the error-styling should be replaced by focus-styling. - [x] Make sure the component have the option for an instance to not have any placeholder text (there is no example of this in the example)

stne3960 added 13 commits 2025-12-02 15:19:51 +01:00

Merge branch 'main' into button-component 617492a87f

Add component library to index, until routing is fixed f2a5cd9d26

Remove import 32376bf9ac

Fix cursor, text style and focus 6a9f8ed9af

Add correct font 5f9e62569d

Add text styles 69cb86d417

Reconverted fonts f37e55f34d

Fix borders and text style, run prettier ed7fb36745

Add font family and text styles cb74baacee

Create TextInput component 7bfad4d8e8

Add TextInput examples to component library c640e4b54f

Merge branch 'text_input' of gitea.dsv.su.se:DMC/studentportalen into text_input edca5aec6f

Fix merge conflict 91f694b1c3

stne3960 added 2 commits 2025-12-02 21:44:30 +01:00

Fix text colors, focus state, outline 24d0db7045

Add no placeholder example 2f9dbc08aa

stne3960 requested review from jare2473 2025-12-03 10:32:08 +01:00

jare2473 requested changes 2025-12-03 10:59:26 +01:00

Dismissed

jare2473 left a comment

Owner

Copy Link

Perfect! The input text color did not feel right to me (not enough contrast to the placeholder), so I looked at the SU website and saw that they are using black (#FFFFFF) in (some) text input fields.

So I say, let us also "break the rules" of the SU graphic profile and add this to the color palette. I have updated the text input overview and the color overview in figma.

In short, change the text input color from Base/Ink/Strong to Base/Ink/Max.

Perfect! The input text color did not feel right to me (not enough contrast to the placeholder), so I looked at the SU website and saw that they are using black (#FFFFFF) in (some) text input fields. So I say, let us also "break the rules" of the SU graphic profile and add this to the color palette. I have updated the text input overview and the color overview in figma. In short, change the text input color from Base/Ink/Strong to Base/Ink/Max.

stne3960 added 1 commit 2025-12-03 13:00:22 +01:00

Use base-ink-max for text input bf5a7dc9aa

stne3960 requested review from jare2473 2025-12-04 09:07:26 +01:00

jare2473 approved these changes 2025-12-04 11:06:47 +01:00

jare2473 added

Code Review

and removed

Design Review

labels 2025-12-04 11:07:40 +01:00

All checks were successful

Hide all checks

Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 4m4s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin text_input:text_input

git checkout text_input

Sign in to join this conversation.

Reviewers

No Reviewers

jare2473

Labels

Clear labels

Code Review

Design Review

Design system

Front end

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No Label

Code Review

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DMC/studentportalen#30

No description provided.