DMC/studentportalen
1
1
Fork 0
Code Issues 50 Pull Requests Actions Projects 1 Wiki Activity

Add Checkstyle and Prettier to BFF #65

Merged
stne3960 merged 15 commits from chore/checkstyle into main 2026-01-13 13:17:19 +01:00
Conversation 1 Commits 15 Files Changed 18 +634 -149
stne3960 commented 2026-01-12 17:48:33 +01:00
Owner
Copy Link

This PR adds Checkstyle and Prettier configuration to BFF. It also adds a gitea action to run these.

This PR adds Checkstyle and Prettier configuration to BFF. It also adds a gitea action to run these.
stne3960 added 2 commits 2026-01-12 17:48:33 +01:00
Add checkstyle Maven plugin
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Failing after 1m42s
Details
d7932a5b7e
stne3960 changed title from Add Checkstyle to WIP: Add Checkstyle 2026-01-12 18:16:54 +01:00
stne3960 added 5 commits 2026-01-12 18:29:47 +01:00
Include checkstyle
All checks were successful
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m22s
Details
a403a01e07
stne3960 added 2 commits 2026-01-13 08:27:04 +01:00
Add gitea action to run validate
Some checks failed
Code style BFF / check (push) Failing after 21s
Details
Code style BFF / check (pull_request) Failing after 14s
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 4m16s
Details
33938f7f70
stne3960 added 2 commits 2026-01-13 08:30:56 +01:00
Use ./mvnw instead of mvn
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Failing after 20s
Details
Code style BFF / check (pull_request) Failing after 32s
Details
9de6d9611f
stne3960 added 1 commit 2026-01-13 08:34:17 +01:00
Run npm ci
All checks were successful
Code style BFF / check (pull_request) Successful in 1m27s
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 4m5s
Details
4a191ef8a9
stne3960 changed title from WIP: Add Checkstyle to Add Checkstyle and Prettier to BFF 2026-01-13 08:41:22 +01:00
stne3960 added the
Code Review
 label 2026-01-13 08:41:33 +01:00
stne3960 requested review from ansv7779 2026-01-13 08:42:35 +01:00
ansv7779 approved these changes 2026-01-13 10:30:03 +01:00
ansv7779 left a comment
Owner
Copy Link

One minor issue that would have been good to address is the need to run npm install in bff/ before you can run any Maven command. Running npm install (and maybe even installing Node and npm) via Maven before attempting to run Prettier would have been nice.

One minor issue that would have been good to address is the need to run `npm install` in `bff/` before you can run any Maven command. Running `npm install` (and maybe even installing Node and npm) via Maven before attempting to run Prettier would have been nice.
stne3960 added 1 commit 2026-01-13 12:15:37 +01:00
Use frontend-maven-plugin to install node and prettier-plugin-java
Some checks failed
Deploy to branch.dsv.su.se / deploy (pull_request) Failing after 1m54s
Details
Code style BFF / check (pull_request) Successful in 54s
Details
e5295f498d
stne3960 added 1 commit 2026-01-13 12:42:57 +01:00
Add workingDirectory
Some checks failed
Code style BFF / check (pull_request) Successful in 45s
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Failing after 1m16s
Details
be42b9a741
stne3960 added 1 commit 2026-01-13 12:48:38 +01:00
Remove unneeded directory, copy package and package-lock
All checks were successful
Code style BFF / check (pull_request) Successful in 42s
Details
Deploy to branch.dsv.su.se / deploy (pull_request) Successful in 3m48s
Details
Remove branch deployment from branch.dsv.su.se / cleanup (pull_request) Successful in 6s
Details
5478715a0f
stne3960 merged commit 15329b1d52 into main 2026-01-13 13:17:19 +01:00
stne3960 deleted branch chore/checkstyle 2026-01-13 13:17:19 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
ansv7779
Labels
Clear labels
Code Review
Design
Component
Design
Page
Design Review
Design in progress
Design system
Front end
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority
question
More information is needed
wontfix
This won't be fixed
No Label
Code Review
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DMC/studentportalen#65
No description provided.
Delete Branch "chore/checkstyle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?