Andreas Svanberg ansv7779
  • Joined on 2021-07-26
ansv7779 approved DMC/studentportalen#31 2025-12-17 21:15:43 +01:00
List components
ansv7779 commented on pull request DMC/studentportalen#31 2025-12-17 11:33:18 +01:00
List components

I think this component would have been better split into two, a single select and a multiple select version. If I use it with multiple={false} I would not want my onChange callback to be called with an array of choices.

ansv7779 commented on pull request DMC/studentportalen#31 2025-12-17 11:33:18 +01:00
List components

This is limiting. Often times you want to select some more complex object as you do in your examples in ComponentLibrary. Forcing all users of the component to do their own lookup when it should be handled by the Combobox/this component.

ansv7779 approved DMC/studentportalen#31 2025-12-17 11:33:18 +01:00
List components
ansv7779 approved DMC/studentportalen#30 2025-12-16 16:12:50 +01:00
Text input component
ansv7779 commented on pull request DMC/studentportalen#30 2025-12-16 14:02:26 +01:00
Text input component

Shouldn't icons inherit their size from their context? Like if I add an icon to a small button or a large heading I would assume it would scale to that context rather than having its own independent size.

ansv7779 commented on pull request DMC/studentportalen#30 2025-12-16 14:02:26 +01:00
Text input component

Should label really be optional? Will that not lead to accessibility issues?

ansv7779 commented on pull request DMC/studentportalen#30 2025-12-16 14:02:26 +01:00
Text input component

Icon with capital I?

ansv7779 commented on pull request DMC/studentportalen#30 2025-12-16 14:02:26 +01:00
Text input component

Without having seen an example of a full form with validation it's hard to tell if this is the path forward. We can probably leave it for now.

ansv7779 approved DMC/studentportalen#29 2025-12-12 10:31:29 +01:00
button-component
ansv7779 commented on pull request DMC/studentportalen#29 2025-12-10 17:06:34 +01:00
button-component

Needs to be ran through Prettier.

ansv7779 commented on pull request DMC/studentportalen#29 2025-12-10 17:06:34 +01:00
button-component

This file needs to be ran through Prettier.

ansv7779 commented on pull request DMC/studentportalen#29 2025-12-10 17:06:34 +01:00
button-component

This is unwieldy. Any way to break it down or group them somehow? Like the border styles, focus styles, colors, and so on.

ansv7779 commented on pull request DMC/studentportalen#29 2025-12-10 17:06:34 +01:00
button-component

What does this do? I assume it does some JavaScript type-coercion of strings/undefined/null to booleans but what about the empty string? Needs a clarification comment.

ansv7779 commented on pull request DMC/studentportalen#29 2025-12-10 17:06:34 +01:00
button-component

This file needs to be ran through Prettier.

ansv7779 suggested changes for DMC/studentportalen#29 2025-12-10 17:06:34 +01:00
button-component

Functionally it looks good and does what one would expect when using it.

ansv7779 pushed to java-25 at DMC/studentportalen 2025-12-01 11:23:04 +01:00
9f9e3e4dba Merge branch 'main' into java-25
e2a263ee03 Update automatic deployment action (#13)
Compare 2 commits »
ansv7779 pushed to main at ansv7779/action-branch-deploy 2025-10-24 16:23:48 +02:00
fa4a728c10 Update action version in README
ansv7779 created pull request DMC/studentportalen#13 2025-10-24 16:07:08 +02:00
Update automatic deployment action
ansv7779 created branch update-deploy-action in DMC/studentportalen 2025-10-24 16:05:42 +02:00